From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
Subject: Re: [PATCH 08/10] drm/i915: introduce
	haswell_init_clock_gating
Date: Tue, 03 Jul 2012 21:03:16 -0300
Message-ID: <4FF38844.6050707@linux.intel.com>
References: <1341240671-5843-1-git-send-email-eugeni.dodonov@intel.com>
	<1341240671-5843-9-git-send-email-eugeni.dodonov@intel.com>
	<20120703202418.GE5103@phenom.ffwll.local>
Reply-To: eugeni.dodonov@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id AF903A0898
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  3 Jul 2012 17:03:18 -0700 (PDT)
In-Reply-To: <20120703202418.GE5103@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov <eugeni.dodonov@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On 07/03/12 17:24, Daniel Vetter wrote:
> On Mon, Jul 02, 2012 at 11:51:09AM -0300, Eugeni Dodonov wrote:
>> This is based on Ivy Bridge clock gating for now, but is subject to
>> changes in the future.
>>
>> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> 
> This copy of presumeably the ivb clock gate code is missing the changes
> introduce in:
> 
> commit 208482232de3590cee4757dfabe5d8cee8c6e626
> Author: Ben Widawsky <ben@bwidawsk.net>
> Date:   Fri May 4 18:58:59 2012 -0700
> 
>     drm/i915: set IDICOS to medium uncore resources
> 
> I guess that's not quite intentional ...
> 
> All the previous patches up to here are queued for -next, thanks.

I thought that this one was specific for Ivy Bridge, so I just skipped it...

I have not tried setting these settings on Haswell, so I don't know if
it is useful here as well. I'll try later this week to see if there are
any visible effects.

Eugeni