From: Jaroslav Kysela <perex@perex.cz>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 0/4] ALSA: hda beep clean up
Date: Wed, 04 Jul 2012 09:43:23 +0200 [thread overview]
Message-ID: <4FF3F41B.2050107@perex.cz> (raw)
In-Reply-To: <s5h62a45cms.wl%tiwai@suse.de>
Date 4.7.2012 07:16, Takashi Iwai wrote:
> At Tue, 03 Jul 2012 22:01:45 +0200,
> Jaroslav Kysela wrote:
>>
>> Date 3.7.2012 18:31, Jaroslav Kysela wrote:
>>> Date 3.7.2012 18:03, Takashi Iwai wrote:
>>>> Hi,
>>>>
>>>> this is a series of small cleanups of HD-audio beep code.
>>>> Since the keyboard driver already handles the simultaneous outputs
>>>> from the multiple input beep instances, there is no merit to have
>>>> beep_mode=2 option to switch the beep input device.
>>>
>>> Acked-by: Jaroslav Kysela <perex@perex.cz>
>>
>> While I acked this, I vaguely remember now, that the event duplication
>> (simultaneous outputs) caused some issues on some Lenovo notebooks.
>>
>> When the pcspkr and HDA beep generator is connected to the same output
>> (integrated speakers), it may cause some issues (bad beep quality -
>> frequency etc.).
>>
>> I looked to the input code, and the kd_mksound() calls
>> input_handler_for_each_handle(), thus the event is duplicated to all
>> beep generators, right?
>
> Right.
>
>> The beep_mode=2 was introduced to let users to help with this issue with
>> a comfortable way.
>
> Not really. At the time this was introduced, the keyboard driver took
> only a single input handle exclusively, namely only the last
> registered one. Thus playing on both had never happened until
> recently.
OK, thanks for the clarification. The question is, if it's the desired
behaviour. Multiple outs can cause some harmonic effects. It would be
nice, if the input layer can turn on/off (filter) the beep events at
runtime separately for all registered drivers. The setup can be handled
using sysfs or so..
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project; Red Hat, Inc.
next prev parent reply other threads:[~2012-07-04 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 16:03 [PATCH 0/4] ALSA: hda beep clean up Takashi Iwai
2012-07-03 16:03 ` [PATCH 1/4] ALSA: hda - Remove beep_mode=2 Takashi Iwai
2012-07-03 16:03 ` [PATCH 2/4] ALSA: hda - Move beep helper functions to hda_beep.c Takashi Iwai
2012-07-03 16:03 ` [PATCH 3/4] ALSA: hda - Get rid of superfluous beep->mode field Takashi Iwai
2012-07-03 16:03 ` [PATCH 4/4] ALSA: hda - Avoid possible race of beep on/off Takashi Iwai
2012-07-03 16:31 ` [PATCH 0/4] ALSA: hda beep clean up Jaroslav Kysela
2012-07-03 20:01 ` Jaroslav Kysela
2012-07-04 5:16 ` Takashi Iwai
2012-07-04 7:43 ` Jaroslav Kysela [this message]
2012-07-04 7:46 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF3F41B.2050107@perex.cz \
--to=perex@perex.cz \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.