From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmNpB-0005m0-Bo for qemu-devel@nongnu.org; Wed, 04 Jul 2012 07:32:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmNp4-0002Qg-SM for qemu-devel@nongnu.org; Wed, 04 Jul 2012 07:32:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmNp4-0002Q2-KL for qemu-devel@nongnu.org; Wed, 04 Jul 2012 07:32:42 -0400 Message-ID: <4FF429D4.6090200@redhat.com> Date: Wed, 04 Jul 2012 05:32:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <20120615204648.9853.1225.sendpatchset@skannery.in.ibm.com> <20120615204800.9853.19740.sendpatchset@skannery.in.ibm.com> <4FDBB309.1050704@redhat.com> <4FF3D161.9050802@gmail.com> In-Reply-To: <4FF3D161.9050802@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig7BA349426C2DFD1DA4B3F52E" Subject: Re: [Qemu-devel] [v1 Patch 5/10]Qemu: raw-posix image file reopen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shrinidhi Joshi Cc: Kevin Wolf , Stefan Hajnoczi , jcody@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino , Christoph Hellwig This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7BA349426C2DFD1DA4B3F52E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/03/2012 11:15 PM, Shrinidhi Joshi wrote: > On Saturday 16 June 2012 03:41 AM, Eric Blake wrote: >> On 06/15/2012 02:48 PM, Supriya Kannery wrote: >> > raw-posix driver changes for bdrv_reopen_xx functions to >> > safely reopen image files. Reopening of image files while >> > changing hostcache dynamically is handled here. >> > > raw-posix driver changes for bdrv_reopen_xx functions to > safely reopen image files. Reopening of image files while > changing hostcache dynamically is handled here. A resubmission of a fixed patch is better handled as a new thread with a v2 in the subject line, rather than embedded as a reply to the v1 comment= s. > + raw_stash_state(raw_rs->stash_s, s); > + s->fd =3D dup3(raw_rs->stash_s->fd,s->fd,O_CLOEXEC); > + dup3() is not universally available (it is not in POSIX, yet). You need configure checks to determine if it exists, and a graceful fallback using dup2()/fcntl(F_GETFD/F_SETFD) if not. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig7BA349426C2DFD1DA4B3F52E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP9CnUAAoJEKeha0olJ0NqLiwIAIfCZ7cRWvykdtgzow/oXt4I dlO0Morh/cz4BcrxuvZiO7a7G/HVeIReM6rMs4sg0AlqbBamPuuewsFaxS9meybU +8ekaL44HjOrxDLF/P4sHCCTTnO/JXCTYQKQUOlME/nMvzb/zZRwVZxuSdGF87e4 G/oFcX+D3YRb9bLDAKUryZaU5XGxP/SQ/67Ef3ZXpzTgK22BLpBcLYR1UzHMmYy4 YWB8eRSi/pw8Uyh6W5wfXXAXSFAudNPRHNjh143g2l/N3Et4bRJdOYjXolIJnWU8 nuol+NOVymTACzmmbeAt4AmoZMU8A5dDbgXAl0weR0QxTKSZpUjk2aaMxYDT+AQ= =A52n -----END PGP SIGNATURE----- --------------enig7BA349426C2DFD1DA4B3F52E--