From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42523)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SmSIa-0001hb-8T
	for qemu-devel@nongnu.org; Wed, 04 Jul 2012 12:19:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SmSIY-0004q5-Ij
	for qemu-devel@nongnu.org; Wed, 04 Jul 2012 12:19:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34783)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SmSIY-0004pv-A6
	for qemu-devel@nongnu.org; Wed, 04 Jul 2012 12:19:26 -0400
Message-ID: <4FF46D00.9090008@redhat.com>
Date: Wed, 04 Jul 2012 18:19:12 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1340984094-5451-1-git-send-email-armbru@redhat.com>
	<1340984094-5451-19-git-send-email-armbru@redhat.com>
	<20120702125515.GA16482@stefanha-thinkpad.localdomain>
	<4FF19D21.20005@suse.de> <m3wr2m5jwz.fsf@blackfin.pond.sub.org>
	<CAJSP0QVDDYdymD3Lk-VVmSS9uPQ5RVahT4=s-qDv8EF2JSjJgA@mail.gmail.com>
	<CAAu8pHs4ejBMTkaMGGPtcUuKVsRq_HGrMz9tEJj7JjR4BVt0dA@mail.gmail.com>
	<4FF352C4.6040209@suse.de>
In-Reply-To: <4FF352C4.6040209@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to
 match BlockConf
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>

Il 03/07/2012 22:15, Andreas F=C3=A4rber ha scritto:
>> >=20
>> > I'd also vote for %u. PRI*32 do not seem very useful compared to pla=
in
>> > int versions.
> If it's not useful we should use unsigned int.

It just means that we're assuming 32-bit ints, which is a fact.  The day
an IL32 platform appears that has "typedef long int32_t", we'll worry
about PRIu32.

Paolo

> Mixing both is simply wrong. I'm okay with fixing it consistently in a
> follow-up though. The Broken Window theory scores again (lack of const,
> non-CamelCase type names, placement of {, wrong semicolons, etc.).