From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmSZT-000119-7n for qemu-devel@nongnu.org; Wed, 04 Jul 2012 12:37:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmSZR-00015J-CN for qemu-devel@nongnu.org; Wed, 04 Jul 2012 12:36:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmSZR-00015E-3R for qemu-devel@nongnu.org; Wed, 04 Jul 2012 12:36:53 -0400 Message-ID: <4FF4711E.1090107@redhat.com> Date: Wed, 04 Jul 2012 10:36:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1340984094-5451-1-git-send-email-armbru@redhat.com> <1340984094-5451-19-git-send-email-armbru@redhat.com> <20120702125515.GA16482@stefanha-thinkpad.localdomain> <4FF19D21.20005@suse.de> <4FF352C4.6040209@suse.de> <4FF46D00.9090008@redhat.com> In-Reply-To: <4FF46D00.9090008@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigC507FA4F27C66C98BE98F849" Subject: Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, aliguori@us.ibm.com, Stefan Hajnoczi , Stefan Hajnoczi , Markus Armbruster , qemu-devel@nongnu.org, Blue Swirl , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC507FA4F27C66C98BE98F849 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/04/2012 10:19 AM, Paolo Bonzini wrote: > Il 03/07/2012 22:15, Andreas F=C3=A4rber ha scritto: >>>> >>>> I'd also vote for %u. PRI*32 do not seem very useful compared to pla= in >>>> int versions. >> If it's not useful we should use unsigned int. >=20 > It just means that we're assuming 32-bit ints, which is a fact. The da= y > an IL32 platform appears that has "typedef long int32_t", we'll worry > about PRIu32. Newlib's does just that, on platforms that __have_long32. Which makes Cygwin a great platform for flushing out these sorts of type discrepancies (since cygwin inherits from newlib). http://sourceware.org/cgi-bin/cvsweb.cgi/src/newlib/libc/include/stdint.h= =2Ediff?r1=3D1.8&r2=3D1.9&cvsroot=3Dsrc&f=3Dh --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigC507FA4F27C66C98BE98F849 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP9HEfAAoJEKeha0olJ0NqkhYIAJkXO520WGC/f8JLCVU2hSFV 5n8yzf+SucYQcAVKoP4LORQgd+ZdtKutubLWZS4X8PVv9TLM6ZSCidZBx4TEOOYa 47tMDuGOgJBPOfaYxHo6eNZnOkTg1gCYYRiLyueI+HDj7uICChX2ImvD8TymuW5U Vnp05ruWOgDAadbWbYk+sqMzvJnq1rSccZ7LrGzwT9gqDaDIyJGhSCaF8jcDFt8+ SrflV4ojT2MwGeGi/PY2ZXVtS5V3rDtVMGWmKSdPZ4EOxB1BYJ/J7fZdJxw8N63Z EtazbTGpsxXLO3kkc8fPfepOGLj5UB4GH5+SWaPCZCKPOyg5x1lcmIYvpr441q0= =0isM -----END PGP SIGNATURE----- --------------enigC507FA4F27C66C98BE98F849--