From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smg9N-0004T0-E5 for qemu-devel@nongnu.org; Thu, 05 Jul 2012 03:06:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Smg9H-0007HY-5T for qemu-devel@nongnu.org; Thu, 05 Jul 2012 03:06:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smg9G-0007HI-Tn for qemu-devel@nongnu.org; Thu, 05 Jul 2012 03:06:47 -0400 Message-ID: <4FF53CFE.5050805@redhat.com> Date: Thu, 05 Jul 2012 09:06:38 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1340984094-5451-1-git-send-email-armbru@redhat.com> <1340984094-5451-5-git-send-email-armbru@redhat.com> <4FF46008.1080404@redhat.com> <4FF46E97.9050708@redhat.com> In-Reply-To: <4FF46E97.9050708@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, Markus Armbruster , stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org Am 04.07.2012 18:25, schrieb Paolo Bonzini: > Il 04/07/2012 17:23, Kevin Wolf ha scritto: >>>> opts LCHS def. PCHS >>>> :floppy: 80, 2,36 5,16,63 >>>> :32:floppy: 80, 2,36 5,16,63 >>>> :16:floppy: 80, 2,36 5,16,63 >>>> :12:floppy: 80, 2,18 2,16,63 >>>> >>>> Silly thing to do for use with a hard disk. >>>> >>>> However, the "raw" format can be suppressed by adding an >>>> redundant-looking "format=vvfat" to "file=fat:FOO". Then, vvfat's >>>> hint clobbers the user's geometry, i.e. -drive options cyls, heads, >>>> secs get silently ignored. Don't do that. >>>> >>>> No change without format=vvfat. With it, the user's hard disk >>>> geometry (-drive options cyls, heads, secs) is now obeyed, and the >>>> default hard disk geometry with :floppy: now matches the one without >>>> format=vvfat. >>>> >>>> Signed-off-by: Markus Armbruster >> For some values of "obeyed". If I understand correctly, the user defined >> geometry will indeed by visible for the device emulation now, but this >> still doesn't mean that vvfat also provides an image that matches this >> geometry. Not sure if it is a good idea to allow such mismatches. >> > > Does this only matter if you declare an image with :floppy: and pass it > as a hard disk? Then we can honestly say we don't care... As I understand it, the patch has two effect: 1. the user's hard disk geometry (-drive options cyls, heads, secs) is now obeyed 2. the default hard disk geometry with :floppy: now matches the one without format=vvfat I don't care about 2. indeed, but doing 1. right would be nice. Kevin