From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smny7-0007Vi-2C for qemu-devel@nongnu.org; Thu, 05 Jul 2012 11:27:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Smny1-0005li-NN for qemu-devel@nongnu.org; Thu, 05 Jul 2012 11:27:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smny1-0005lD-Fp for qemu-devel@nongnu.org; Thu, 05 Jul 2012 11:27:41 -0400 Message-ID: <4FF5B247.7070902@redhat.com> Date: Thu, 05 Jul 2012 17:27:03 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1340984094-5451-1-git-send-email-armbru@redhat.com> <1340984094-5451-33-git-send-email-armbru@redhat.com> In-Reply-To: <1340984094-5451-33-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 29.06.2012 17:34, schrieb Markus Armbruster: > New limits straight from ATA4 6.2 Register delivered data transfer > command sector addressing. > > I figure the old sector limit 63 was blindly copied from the BIOS > int 13 limit. Doesn't apply to the hardware. No idea where the old > cylinder limit comes from. > > Signed-off-by: Markus Armbruster Now I think we have the very same thing in IDE, SCSI and virtio-blk. Would it make sense to have a helper function in hd-geometry.c that takes and validates the geometry from a BlockConf, applies defaults and puts the result into device state fields passed by reference? Kevin