Re: [PATCH 0/4] can: gw: Netlink related fixes

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 05.07.2012 14:19, Thomas Graf wrote:


> These patches fix some Netlink quirks in the CAN gateway code.
> Unfortunately I do not own any CAN hardware so this is compile
> tested only. I'm fairly confident though as the changes are
> mostly straight forward. I would appreciate if someone could
> run them through a test suite or something though.
> 
> 
> Thomas Graf (4):
>   can: Don't bump nlmsg_len manually
>   can: Use nla_policy to validate netlink attributes
>   can: Properly fill the netlink header when responding to RTM_GETROUTE
>   can: Remove pointless casts
> 
>  net/can/gw.c |   90 +++++++++++++++++++++------------------------------------
>  1 files changed, 33 insertions(+), 57 deletions(-)
> 


Hi Thomas,

thanks for the cleanups!

The can-gw was my first netlink based project and i did the best i knew.

From the first sight it looks good. I now also got behind the nla_policy
trick, which checks the minimal length too.

I'll test the patches this weekend with the virtual CAN interfaces (no CAN HW
needed), so that we probably catch the current development window.

Best regards,
Oliver