From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smp4Z-00070u-OI for qemu-devel@nongnu.org; Thu, 05 Jul 2012 12:38:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Smp4T-0004uU-AF for qemu-devel@nongnu.org; Thu, 05 Jul 2012 12:38:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smp4T-0004tr-1f for qemu-devel@nongnu.org; Thu, 05 Jul 2012 12:38:25 -0400 Message-ID: <4FF5C2F6.3010000@redhat.com> Date: Thu, 05 Jul 2012 12:38:14 -0400 From: Jeff Cody MIME-Version: 1.0 References: <20120615204648.9853.1225.sendpatchset@skannery.in.ibm.com> <20120615204701.9853.3126.sendpatchset@skannery.in.ibm.com> In-Reply-To: <20120615204701.9853.3126.sendpatchset@skannery.in.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display host cache setting Reply-To: jcody@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Supriya Kannery Cc: Kevin Wolf , Shrinidhi Joshi , Stefan Hajnoczi , qemu-devel@nongnu.org, Luiz Capitulino , Paolo Bonzini , Christoph Hellwig On 06/15/2012 04:47 PM, Supriya Kannery wrote: > Enhance "info block" to display hostcache setting for each > block device. > > Example: > (qemu) info block > ide0-hd0: removable=0 file=../rhel6-32.raw ro=0 drv=raw encrypted=0 > > Enhanced to display "hostcache" setting: > (qemu) info block > ide0-hd0: removable=0 hostcache=1 file=../rhel6-32.raw ro=0 drv=raw encrypted=0 > > Signed-off-by: Supriya Kannery > This email is not about any changes per se, but just noting some conflicts (see below) with Paolo's blkmirror series (from his branch blkmirror-job-1.2 in git://github.com/bonzini/qemu.git). This is just for future reference, I don't know which will go in first. > --- > block.c | 20 ++++++++++++++++---- > qmp-commands.hx | 2 ++ > 2 files changed, 18 insertions(+), 4 deletions(-) > > Index: qemu/qapi-schema.json > =================================================================== > --- qemu.orig/qapi-schema.json > +++ qemu/qapi-schema.json > @@ -447,6 +447,8 @@ > # @locked: True if the guest has locked this device from having its media > # removed > # > +# @hostcache: True if host pagecache is enabled. > +# > # @tray_open: #optional True if the device has a tray and it is open > # (only present if removable is true) > # > @@ -460,7 +462,7 @@ > ## > { 'type': 'BlockInfo', > 'data': {'device': 'str', 'type': 'str', 'removable': 'bool', > - 'locked': 'bool', '*inserted': 'BlockDeviceInfo', > + 'locked': 'bool','hostcache': 'bool', '*inserted': 'BlockDeviceInfo', > '*tray_open': 'bool', '*io-status': 'BlockDeviceIoStatus'} } > Conflicts with 'block: make device optional in BlockInfo' (f6c1f133a8), but just in the contextual info (not in the actual change). > ## > Index: qemu/block.c > =================================================================== > --- qemu.orig/block.c > +++ qemu/block.c > @@ -2581,6 +2581,7 @@ BlockInfoList *qmp_query_block(Error **e > info->value->device = g_strdup(bs->device_name); > info->value->type = g_strdup("unknown"); > info->value->locked = bdrv_dev_is_medium_locked(bs); > + info->value->hostcache = !(bs->open_flags & BDRV_O_NOCACHE); > info->value->removable = bdrv_dev_has_removable_media(bs); > > if (bdrv_dev_has_removable_media(bs)) { Conflicts with 'block: add bdrv_query_info' (804ce1520d) This would probably go in his new function 'bdrv_query_info()'. > Index: qemu/hmp.c > =================================================================== > --- qemu.orig/hmp.c > +++ qemu/hmp.c > @@ -212,6 +212,8 @@ void hmp_info_block(Monitor *mon) > monitor_printf(mon, " tray-open=%d", info->value->tray_open); > } > > + monitor_printf(mon, " hostcache=%d", info->value->hostcache); > + > if (info->value->has_io_status) { > monitor_printf(mon, " io-status=%s", > BlockDeviceIoStatus_lookup[info->value->io_status]); > >