From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Mon, 9 Jul 2012 17:19:46 -0500
Subject: [U-Boot] [PATCH 02/13] S3C64XX: Switch to use readl/writel to
 operate nand flash
In-Reply-To: <1341655032-30201-3-git-send-email-bocui107@gmail.com>
References: <1341655032-30201-1-git-send-email-bocui107@gmail.com>
	<1341655032-30201-3-git-send-email-bocui107@gmail.com>
Message-ID: <4FFB5902.3040305@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 07/07/2012 04:57 AM, Zhong Hongbo wrote:
> +static inline unsigned int s3c64xx_get_base_nand(void)
> +{
> +	return ELFIN_NAND_BASE;
> +}

unsigned long or uintptr_t would be more appropriate, even if U-Boot is
unlikely to be 64-bit any time soon.

Or better, "struct s3c64xx_nand *".

> @@ -89,15 +96,16 @@ static void s3c_nand_select_chip(struct mtd_info *mtd, int chip)
>   */
>  static void s3c_nand_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int ctrl)
>  {
> +	struct s3c64xx_nand *const nand = s3c_get_base_nand();

Is there any benefit to declaring local variables const like this?  Why
this one and not all the others that never get altered?

-Scott