From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SocbL-0007YR-5t for qemu-devel@nongnu.org; Tue, 10 Jul 2012 11:43:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SocbG-0003Bl-3B for qemu-devel@nongnu.org; Tue, 10 Jul 2012 11:43:46 -0400 Received: from mail-qa0-f52.google.com ([209.85.216.52]:38317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SocbF-0003BZ-RX for qemu-devel@nongnu.org; Tue, 10 Jul 2012 11:43:42 -0400 Received: by qabj34 with SMTP id j34so262905qab.4 for ; Tue, 10 Jul 2012 08:43:39 -0700 (PDT) Message-ID: <4FFC4DA7.7040203@acm.org> Date: Tue, 10 Jul 2012 10:43:35 -0500 From: Corey Minyard MIME-Version: 1.0 References: <1341861429-6297-1-git-send-email-minyard@acm.org> <4FFBF77E.5030705@redhat.com> In-Reply-To: <4FFBF77E.5030705@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] First shot at adding IPMI to qemu Reply-To: minyard@acm.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 07/10/2012 04:35 AM, Paolo Bonzini wrote: > Il 09/07/2012 21:17, minyard@acm.org ha scritto: >> I had asked about getting an IPMI device into qemu and received some >> interest, and it's useful to me, so I've done some work to add it. >> The following patch set has a set of patches to add an IPMI KCS >> device, and IPMI BT device, a built-in BMC (IPMI management controller), >> and a way to attach an external BMC through a chardev. >> >> There was some discussion on whether to make the BMC internal or >> external, but I went ahead and added both. The internal one is >> fairly basic and not extensible, at least without adding code. >> I've modified the OpenIPMI library simulator to work with the >> external interface to allow it to receive connections from the >> qemu external simulator with a fairly basic protocol. >> >> I've also added the ability for the OpenIPMI library to manage >> a VM to power it on, power it off, reset it, and handle an IPMI >> watchdog timer. So it looks quite like a real system. Instructions >> for using it are in the OpenIPMI release candidate I uploaded to >> https://sourceforge.net/projects/openipmi >> >> Since IPMI can advertise its presence via SMBIOS, I added a >> way for a driver to add an SMBIOS entry. I also added a way >> to query a free interrupt from the ISA bus, since the interrupt >> is in the SMBIOS entry and nobody really cares which one is used. > I provided some feedback in the individual patches, it shouldn't be a > lot of work compared to what you have done already! Yes, looks like all good comments. I'll work on these over the next few days and resubmit. Thanks. > > It would be great if you could add a basic testcase using qtest, even if > only for the internal interface, to ensure it doesn't bitrot. Yes, certainly. Thanks again, -corey