From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756063Ab2GJQEi (ORCPT ); Tue, 10 Jul 2012 12:04:38 -0400 Received: from relay.parallels.com ([195.214.232.42]:47782 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752648Ab2GJQEf convert rfc822-to-8bit (ORCPT ); Tue, 10 Jul 2012 12:04:35 -0400 Message-ID: <4FFC5284.4040605@parallels.com> Date: Tue, 10 Jul 2012 20:04:20 +0400 From: Stanislav Kinsbursky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: "J. Bruce Fields" CC: "linux-nfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@openvz.org" Subject: Re: [PATCH] [RFC] nfsd: fix possible dereference of static NULL nfsd_serv pointer References: <20120706134548.7307.1133.stgit@localhost.localdomain> <20120706172630.GA11193@fieldses.org> <4FF7C8C2.8070203@parallels.com> <20120710155943.GB1947@fieldses.org> In-Reply-To: <20120710155943.GB1947@fieldses.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 10.07.2012 19:59, J. Bruce Fields пишет: > On Sat, Jul 07, 2012 at 09:27:30AM +0400, Stanislav Kinsbursky wrote: >> 06.07.2012 21:26, J. Bruce Fields пишет: >>> On Fri, Jul 06, 2012 at 05:45:56PM +0400, Stanislav Kinsbursky wrote: >>>> This is a bug fix for 3.5 kernel. >>>> In case on NFSd service start failure svc_shutdown_net() will call svc_destroy >>>> callback and zeroize global nfsd_serv pointer, this in turn will lead to Oops >>>> in svc_destroy(). >>>> >>>> This patch is marked as RFC, because to many lines were changed. It can be >>>> easely simplified if requested. >>>> Moreover, NFSd service shutdown is going to be converted into csomething on >>>> per-net basis. >>> Doesn't this leave error paths in e.g. __write_ports_addfd() and >>> __write_ports_addxprt() unfixed? >> >> Yes, sure it does... >> >>> I'm inclined to just submit your original fix (split up as in the last >>> version I sent) for 3.5 if you don't object. >> >> Not at all. >> Thanks, Bruce. > > OK. Actually, Linus is making noise about a release in the next week or > two, so given that this is about error paths, I'm going to queue it up > for the 3.6 and cc it to stable. It'll end up in 3.5.x pretty quickly > that way anyway. > Ok, Bruce. Sounds good. -- Best regards, Stanislav Kinsbursky