From: "Andreas Färber" <afaerber@suse.de>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Stefan Weil <sw@weilnetz.de>,
coreyb@linux.vnet.ibm.com, qemu-devel@nongnu.org,
Luiz Capitulino <lcapitulino@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag
Date: Tue, 10 Jul 2012 19:29:17 +0200 [thread overview]
Message-ID: <4FFC666D.2080703@suse.de> (raw)
In-Reply-To: <1341917019-23224-1-git-send-email-chouteau@adacore.com>
Am 10.07.2012 12:43, schrieb Fabien Chouteau:
> Bridge helper uses ioctl's not available on old Linux versions, we add
> this flag to disable the build.
>
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
> ---
> Makefile | 2 +-
> configure | 8 ++++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 34d6a9e..b46c6b0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -37,7 +37,7 @@ $(call set-vpath, $(SRC_PATH))
>
> LIBS+=-lz $(LIBS_TOOLS)
>
> -HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)
> +HELPERS-$(CONFIG_HELPERS) = qemu-bridge-helper$(EXESUF)
>
> ifdef BUILD_DOCS
> DOCS=qemu-doc.html qemu-tech.html qemu.1 qemu-img.1 qemu-nbd.8 QMP/qmp-commands.txt
Three quick comments:
We should also disable build of all helpers when compiling with --static.
I don't like the bridge helper being disabled based on CONFIG_HELPERS,
suggest specific CONFIG_BRIDGE_HELPER or so.
All --disable-* options should probably have an --enable-* counterpart.
Andreas
> diff --git a/configure b/configure
> index 500fe24..5566752 100755
> --- a/configure
> +++ b/configure
> @@ -195,6 +195,7 @@ zlib="yes"
> guest_agent="yes"
> libiscsi=""
> coroutine=""
> +bridge_helper="yes"
>
> # parse CC options first
> for opt do
> @@ -824,6 +825,8 @@ for opt do
> ;;
> --disable-guest-agent) guest_agent="no"
> ;;
> + --disable-bridge-helper) bridge_helper="no"
> + ;;
> *) echo "ERROR: unknown option $opt"; show_help="yes"
> ;;
> esac
> @@ -1110,6 +1113,7 @@ echo " --disable-guest-agent disable building of the QEMU Guest Agent"
> echo " --enable-guest-agent enable building of the QEMU Guest Agent"
> echo " --with-coroutine=BACKEND coroutine backend. Supported options:"
> echo " gthread, ucontext, sigaltstack, windows"
> +echo " --disable-bridge-helper disable building of the qemu-bridge-helper"
> echo ""
> echo "NOTE: The object files are built at the place where configure is launched"
> exit 1
> @@ -3896,6 +3900,10 @@ if test "$tcg_interpreter" = "yes" ; then
> echo "CONFIG_TCI_DIS=y" >> $libdis_config_mak
> fi
>
> +if test "$bridge_helper" = "yes" && test "$linux" = "yes" ; then
> + echo "CONFIG_HELPERS=y" >> $config_host_mak
> +fi
> +
> case "$ARCH" in
> alpha)
> # Ensure there's only a single GP
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-07-10 17:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 10:43 [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag Fabien Chouteau
2012-07-10 10:44 ` Paolo Bonzini
2012-07-10 11:02 ` Fabien Chouteau
2012-07-10 11:06 ` Paolo Bonzini
2012-07-10 13:37 ` Fabien Chouteau
2012-07-11 14:22 ` Corey Bryant
2012-07-11 14:56 ` Fabien Chouteau
2012-07-11 14:57 ` Paolo Bonzini
2012-07-11 15:27 ` Corey Bryant
2012-07-10 17:29 ` Andreas Färber [this message]
2012-07-11 8:56 ` Fabien Chouteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFC666D.2080703@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=chouteau@adacore.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.