From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoqvJ-0001jU-0H for qemu-devel@nongnu.org; Wed, 11 Jul 2012 03:01:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoqvB-0004Xh-Qw for qemu-devel@nongnu.org; Wed, 11 Jul 2012 03:01:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoqvB-0004XC-JC for qemu-devel@nongnu.org; Wed, 11 Jul 2012 03:01:13 -0400 Message-ID: <4FFD24B2.4010508@redhat.com> Date: Wed, 11 Jul 2012 09:01:06 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1341900967-4344-1-git-send-email-qemulist@gmail.com> <1341900967-4344-2-git-send-email-qemulist@gmail.com> <4FFBEBAE.7080200@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] qdev: introduce qdev_create_kid(Object *parent, const char *type) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liu ping fan Cc: Blue Swirl , Jan Kiszka , qemu-devel@nongnu.org, Anthony Liguori , =?ISO-8859-1?Q?Andreas_F=E4rber?= Il 11/07/2012 03:17, liu ping fan ha scritto: > OK, I will move the creation in the CPU. But I think as part of qom, > DeviceState can have a DeviceState child, so there is need for wrapper > for the function. Maybe just make the qdev_create_kid(Object*) -> > qdev_create_kid(DeviceState*) ? You can just use object_property_add_child whenever you would use qdev_create_kid. Paolo