From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SowCl-0005R5-0m for qemu-devel@nongnu.org; Wed, 11 Jul 2012 08:39:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SowCi-00012A-3a for qemu-devel@nongnu.org; Wed, 11 Jul 2012 08:39:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SowCh-00011v-Rh for qemu-devel@nongnu.org; Wed, 11 Jul 2012 08:39:40 -0400 Message-ID: <4FFD7404.7060709@redhat.com> Date: Wed, 11 Jul 2012 14:39:32 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1341983345-25255-1-git-send-email-sw@weilnetz.de> <4FFD0E48.4090800@msgid.tls.msk.ru> In-Reply-To: <4FFD0E48.4090800@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Stefan Weil , Anthony Liguori , qemu-devel@nongnu.org Am 11.07.2012 07:25, schrieb Michael Tokarev: > On 11.07.2012 09:09, Stefan Weil wrote: >> Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW) >> because it partially replaced "ret" by "count". >> >> It also changed the handling of EINTR in a wrong way. >> >> The patch restores the old code for these two changes. >> >> Signed-off-by: Stefan Weil > > Signed-off-by: Michael Tokarev > > Granted, I never _ever_ tested or even compiled this > part. Should have been. Thank you Stefan! Then I guess you should not have sent a pull request. :-) Kevin