From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH v2 20/21] Implement -dimms, -dimmspop command line options Date: Wed, 11 Jul 2012 17:55:25 +0300 Message-ID: <4FFD93DD.5060907@redhat.com> References: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1342002726-18258-21-git-send-email-vasilis.liaskovitis@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, seabios@seabios.org, anthony@codemonkey.ws, gleb@redhat.com, imammedo@redhat.com, kevin@koconnor.net, wency@cn.fujitsu.com To: Vasilis Liaskovitis Return-path: Received: from mx1.redhat.com ([209.132.183.28]:12285 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758011Ab2GKOzs (ORCPT ); Wed, 11 Jul 2012 10:55:48 -0400 In-Reply-To: <1342002726-18258-21-git-send-email-vasilis.liaskovitis@profitbricks.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/11/2012 01:32 PM, Vasilis Liaskovitis wrote: > Implement batch dimm creation command line options. These could be useful for > not bloating the command line with a large number of dimms. IMO this is unneeded. With a management tool there is no problem generating a long command line; from the command line -dimm will be a rarely used option. > > syntax: -dimms pfx=poolid,size=sz,num=n > Will create numdimms dimms with ids poolid0, ..., poolidn-1. Each dimm has a > size of sz. > > Implement -dimmpop option to populate dimms at bootup > syntax: -dimmpop pfx=poolid,num=n > This will populate n dimms with ids poolid0, ..., poolidn-1. > > (live-migration could break here without patch 12/21: -dimmspop > needs to be reworked to support populating of individual dimms with > same prefix, and not only a range of dimms starting from 0) > -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoyKQ-0007Us-J6 for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:55:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoyKK-0006tm-4j for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:55:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoyKJ-0006tM-TB for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:55:40 -0400 Message-ID: <4FFD93DD.5060907@redhat.com> Date: Wed, 11 Jul 2012 17:55:25 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1342002726-18258-21-git-send-email-vasilis.liaskovitis@profitbricks.com> In-Reply-To: <1342002726-18258-21-git-send-email-vasilis.liaskovitis@profitbricks.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 20/21] Implement -dimms, -dimmspop command line options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vasilis Liaskovitis Cc: kvm@vger.kernel.org, gleb@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, kevin@koconnor.net, anthony@codemonkey.ws, imammedo@redhat.com On 07/11/2012 01:32 PM, Vasilis Liaskovitis wrote: > Implement batch dimm creation command line options. These could be useful for > not bloating the command line with a large number of dimms. IMO this is unneeded. With a management tool there is no problem generating a long command line; from the command line -dimm will be a rarely used option. > > syntax: -dimms pfx=poolid,size=sz,num=n > Will create numdimms dimms with ids poolid0, ..., poolidn-1. Each dimm has a > size of sz. > > Implement -dimmpop option to populate dimms at bootup > syntax: -dimmpop pfx=poolid,num=n > This will populate n dimms with ids poolid0, ..., poolidn-1. > > (live-migration could break here without patch 12/21: -dimmspop > needs to be reworked to support populating of individual dimms with > same prefix, and not only a range of dimms starting from 0) > -- error compiling committee.c: too many arguments to function