From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52847)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1SoyL1-0008C9-Gl
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:56:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1SoyKu-0006zY-9z
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:56:23 -0400
Received: from mel.act-europe.fr ([194.98.77.210]:46344)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1SoyKt-0006zC-TK
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:56:16 -0400
Message-ID: <4FFD940D.30500@adacore.com>
Date: Wed, 11 Jul 2012 16:56:13 +0200
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
References: <1341917019-23224-1-git-send-email-chouteau@adacore.com>
	<4FFC079A.9090603@redhat.com> <4FFC0BB6.6080500@adacore.com>
	<4FFC0CA6.5060408@redhat.com> <4FFC3013.9040807@adacore.com>
	<4FFD8C12.6090609@linux.vnet.ibm.com>
In-Reply-To: <4FFD8C12.6090609@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Stefan Weil <sw@weilnetz.de>, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, =?ISO-8859-15?Q?Andreas_F=E4?= =?ISO-8859-15?Q?rber?= <afaerber@suse.de>

On 07/11/2012 04:22 PM, Corey Bryant wrote:
> 
> 
> On 07/10/2012 09:37 AM, Fabien Chouteau wrote:
>> On 07/10/2012 01:06 PM, Paolo Bonzini wrote:
>>> Il 10/07/2012 13:02, Fabien Chouteau ha scritto:
>>>>>>>> Bridge helper uses ioctl's not available on old Linux versions, we add
>>>>>>>> this flag to disable the build.
>>>>>>
>>>>>> Which ioctls?  Please detect them, so that we can also work around them
>>>>>> perhaps.
>>>>>>
>>>> There SIOCBRADDIF at least, maybe it's the only one.
>>>
>>> So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were
>>> inclined to do so...
>>>
>>
>> Unfortunately I don't have time to go deep into the code. It's not a
>> feature I plan to use, so the quickest solution for me is to disable it.
>>
>> Corey, I can see that you developed the bridge helper, can you please
>> take a look at this issue?
>>
> 
> Apologies, I was out yesterday.  I see your new patch series is progressing.  I'll take over if/when you want.
> 

Beside the --enable/--disable patch, there's another question for you.
Is it possible to implement qemu-bridge-adapter without SIOCBRADDIF?

Thanks,

-- 
Fabien Chouteau