From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58675)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SoycR-0005HH-Rx
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 11:14:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SoycH-0004CM-WB
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 11:14:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28710)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SoycH-0004C2-OL
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 11:14:13 -0400
Message-ID: <4FFD944E.8050004@redhat.com>
Date: Wed, 11 Jul 2012 16:57:18 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1341917019-23224-1-git-send-email-chouteau@adacore.com>
	<4FFC079A.9090603@redhat.com> <4FFC0BB6.6080500@adacore.com>
	<4FFC0CA6.5060408@redhat.com> <4FFC3013.9040807@adacore.com>
	<4FFD8C12.6090609@linux.vnet.ibm.com> <4FFD940D.30500@adacore.com>
In-Reply-To: <4FFD940D.30500@adacore.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Stefan Weil <sw@weilnetz.de>, Corey Bryant <coreyb@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>, Blue Swirl <blauwirbel@gmail.com>, Luiz Capitulino <lcapitulino@redhat.com>, =?ISO-8859-15?Q?Andreas_F=E4?= =?ISO-8859-15?Q?rber?= <afaerber@suse.de>

Il 11/07/2012 16:56, Fabien Chouteau ha scritto:
>>>> >>> So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were
>>>> >>> inclined to do so...
>>>> >>>
>>> >>
>>> >> Unfortunately I don't have time to go deep into the code. It's not a
>>> >> feature I plan to use, so the quickest solution for me is to disable it.
>>> >>
>>> >> Corey, I can see that you developed the bridge helper, can you please
>>> >> take a look at this issue?
>>> >>
>> > 
>> > Apologies, I was out yesterday.  I see your new patch series is progressing.  I'll take over if/when you want.
>> > 
> Beside the --enable/--disable patch, there's another question for you.
> Is it possible to implement qemu-bridge-adapter without SIOCBRADDIF?

Yes, with the (obsolete) SIOCDEVPRIVATE ioctl.  It has multiple
subcommands, one of which is BRCTL_ADD_IF.

Paolo