From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notification lists Date: Wed, 11 Jul 2012 08:59:03 -0600 Message-ID: <4FFD94B7.2000100@redhat.com> References: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1342002726-18258-14-git-send-email-vasilis.liaskovitis@profitbricks.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigC49DF483B7F1249510EEF5C8" Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, seabios@seabios.org, gleb@redhat.com, kevin@koconnor.net, avi@redhat.com, anthony@codemonkey.ws, imammedo@redhat.com To: Vasilis Liaskovitis Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52077 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755172Ab2GKO7M (ORCPT ); Wed, 11 Jul 2012 10:59:12 -0400 In-Reply-To: <1342002726-18258-14-git-send-email-vasilis.liaskovitis@profitbricks.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC49DF483B7F1249510EEF5C8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/11/2012 04:31 AM, Vasilis Liaskovitis wrote: > Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. > This patch implements a tail queue to store guest notifications for mem= ory > hot-add and hot-remove requests. >=20 > Guest responses for memory hotplug command on a per-dimm basis can be d= etected > with the new hmp command "info memhp" or the new qmp command "query-mem= hp" > Examples: > =20 > +++ b/qapi-schema.json > @@ -1862,3 +1862,29 @@ > # Since: 0.14.0 > ## > { 'command': 'netdev_del', 'data': {'id': 'str'} } > + > +## > +# @MemHpInfo: > +# > +# Information about status of a memory hotplug command > +# > +# @Dimm: the Dimm associated with the result > +# > +# @result: the result of the hotplug command > +# > +# Since: 1.1.3 Should probably be 1.2, not 1.1.3. > +# > +## > +{ 'type': 'MemHpInfo', > + 'data': {'Dimm': 'str', 'request': 'str', 'result': 'str'} } Why the upper case? Wouldn't 'dimm' be more consistent? > + > +## > +# @query-memhp: Why are we abbreviating? It might be better to name the QMP command query-memory-hotplug > +# > +# Returns a list of information about pending hotplug commands > +# > +# Returns: a list of @MemhpInfo > +# > +# Since: 1.1.3 Likewise for 1.2. > + > +- "Dimm": Dimm name (json-str) > +- "request": type of hot request: hot-add or hot-remove (json-str) > +- "result": result of the hotplug request for this Dimm success or fai= lure (json-str) This may need tweaks (such as s/Dimm/dimm/) based on resolution of above comments. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigC49DF483B7F1249510EEF5C8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP/ZS3AAoJEKeha0olJ0NqMEcIAIg9gfiGsQg9Oup8W/apIWbl 0esJ2Q3vt9LsAwQlMHXiNu9fGRNjK6BKxhFdOIhBVUbaBvsqLseZCKoDEHfEvnGS nppogJryWAEhx6ndhTrGi1pmE7lM0ecMWUzq5Hv1rAp+ZXpRmxProuDqq4fdn37B pDK7WnM0EzOJ6PfdwlgozFE4kii1ad2qydptbe3fk1r8c5OhBQSBgQu8EnFtbz4D JkraWJP+UcDoM5GVHltx/qpd86gEoUkZDBO56s46dpFZtJKwt5vOq+74boZakVE4 ie78xUeft91I2AQkPat7G22g/jYgk8nHbvJeQ+2IxkAYDZ3fW7JkQDhgho893Ik= =Sapv -----END PGP SIGNATURE----- --------------enigC49DF483B7F1249510EEF5C8-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoyNm-0001FE-BQ for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:59:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoyNg-0007iG-O2 for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:59:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoyNg-0007hj-GC for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:59:08 -0400 Message-ID: <4FFD94B7.2000100@redhat.com> Date: Wed, 11 Jul 2012 08:59:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1342002726-18258-14-git-send-email-vasilis.liaskovitis@profitbricks.com> In-Reply-To: <1342002726-18258-14-git-send-email-vasilis.liaskovitis@profitbricks.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigC49DF483B7F1249510EEF5C8" Subject: Re: [Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notification lists List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vasilis Liaskovitis Cc: kvm@vger.kernel.org, gleb@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, kevin@koconnor.net, avi@redhat.com, anthony@codemonkey.ws, imammedo@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC49DF483B7F1249510EEF5C8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/11/2012 04:31 AM, Vasilis Liaskovitis wrote: > Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. > This patch implements a tail queue to store guest notifications for mem= ory > hot-add and hot-remove requests. >=20 > Guest responses for memory hotplug command on a per-dimm basis can be d= etected > with the new hmp command "info memhp" or the new qmp command "query-mem= hp" > Examples: > =20 > +++ b/qapi-schema.json > @@ -1862,3 +1862,29 @@ > # Since: 0.14.0 > ## > { 'command': 'netdev_del', 'data': {'id': 'str'} } > + > +## > +# @MemHpInfo: > +# > +# Information about status of a memory hotplug command > +# > +# @Dimm: the Dimm associated with the result > +# > +# @result: the result of the hotplug command > +# > +# Since: 1.1.3 Should probably be 1.2, not 1.1.3. > +# > +## > +{ 'type': 'MemHpInfo', > + 'data': {'Dimm': 'str', 'request': 'str', 'result': 'str'} } Why the upper case? Wouldn't 'dimm' be more consistent? > + > +## > +# @query-memhp: Why are we abbreviating? It might be better to name the QMP command query-memory-hotplug > +# > +# Returns a list of information about pending hotplug commands > +# > +# Returns: a list of @MemhpInfo > +# > +# Since: 1.1.3 Likewise for 1.2. > + > +- "Dimm": Dimm name (json-str) > +- "request": type of hot request: hot-add or hot-remove (json-str) > +- "result": result of the hotplug request for this Dimm success or fai= lure (json-str) This may need tweaks (such as s/Dimm/dimm/) based on resolution of above comments. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigC49DF483B7F1249510EEF5C8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP/ZS3AAoJEKeha0olJ0NqMEcIAIg9gfiGsQg9Oup8W/apIWbl 0esJ2Q3vt9LsAwQlMHXiNu9fGRNjK6BKxhFdOIhBVUbaBvsqLseZCKoDEHfEvnGS nppogJryWAEhx6ndhTrGi1pmE7lM0ecMWUzq5Hv1rAp+ZXpRmxProuDqq4fdn37B pDK7WnM0EzOJ6PfdwlgozFE4kii1ad2qydptbe3fk1r8c5OhBQSBgQu8EnFtbz4D JkraWJP+UcDoM5GVHltx/qpd86gEoUkZDBO56s46dpFZtJKwt5vOq+74boZakVE4 ie78xUeft91I2AQkPat7G22g/jYgk8nHbvJeQ+2IxkAYDZ3fW7JkQDhgho893Ik= =Sapv -----END PGP SIGNATURE----- --------------enigC49DF483B7F1249510EEF5C8--