From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932946Ab2GKQHU (ORCPT ); Wed, 11 Jul 2012 12:07:20 -0400 Received: from usmamail.tilera.com ([12.216.194.151]:17575 "EHLO USMAMAIL.TILERA.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932824Ab2GKQHR (ORCPT ); Wed, 11 Jul 2012 12:07:17 -0400 Message-ID: <4FFDA4B5.9060005@tilera.com> Date: Wed, 11 Jul 2012 12:07:17 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Will Deacon CC: , , , , , , Subject: Re: [PATCH 2/3] ipc: allow compat IPC version field parsing if !ARCH_WANT_OLD_COMPAT_IPC References: <1342020741-12758-1-git-send-email-will.deacon@arm.com> <1342020741-12758-3-git-send-email-will.deacon@arm.com> In-Reply-To: <1342020741-12758-3-git-send-email-will.deacon@arm.com> X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/11/2012 11:32 AM, Will Deacon wrote: > Commit 48b25c43 ("[PATCH v3] ipc: provide generic compat versions of IPC > syscalls") added a new ARCH_WANT_OLD_COMPAT_IPC config option for > architectures to select if their compat target requires the old IPC > syscall interface. > > For architectures (such as AArch64) that do not require the internal > calling conventions provided by this option, but have a compat target > where the C library passes the IPC_64 flag explicitly, > compat_ipc_parse_version no longer strips out the flag before calling > the native system call implementation, resulting in unknown SHM/IPC > commands and -EINVAL being returned to userspace. > > This patch separates the selection of the internal calling conventions > for the IPC syscalls from the version parsing, allowing architectures to > select __ARCH_WANT_COMPAT_IPC_PARSE_VERSION if they want to use version > parsing whilst retaining the newer syscall calling conventions. > > Cc: Chris Metcalf > Cc: Arnd Bergmann > Acked-by: Catalin Marinas > Signed-off-by: Will Deacon > --- > include/linux/compat.h | 1 + > ipc/compat.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletions(-) > Acked-by: Chris Metcalf -- Chris Metcalf, Tilera Corp. http://www.tilera.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Metcalf Subject: Re: [PATCH 2/3] ipc: allow compat IPC version field parsing if !ARCH_WANT_OLD_COMPAT_IPC Date: Wed, 11 Jul 2012 12:07:17 -0400 Message-ID: <4FFDA4B5.9060005@tilera.com> References: <1342020741-12758-1-git-send-email-will.deacon@arm.com> <1342020741-12758-3-git-send-email-will.deacon@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from usmamail.tilera.com ([12.216.194.151]:17575 "EHLO USMAMAIL.TILERA.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932824Ab2GKQHR (ORCPT ); Wed, 11 Jul 2012 12:07:17 -0400 In-Reply-To: <1342020741-12758-3-git-send-email-will.deacon@arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Will Deacon Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, davem@davemloft.net, chris@zankel.net, catalin.marinas@arm.com, arnd@arndb.de, akpm@linux-foundation.org On 7/11/2012 11:32 AM, Will Deacon wrote: > Commit 48b25c43 ("[PATCH v3] ipc: provide generic compat versions of IPC > syscalls") added a new ARCH_WANT_OLD_COMPAT_IPC config option for > architectures to select if their compat target requires the old IPC > syscall interface. > > For architectures (such as AArch64) that do not require the internal > calling conventions provided by this option, but have a compat target > where the C library passes the IPC_64 flag explicitly, > compat_ipc_parse_version no longer strips out the flag before calling > the native system call implementation, resulting in unknown SHM/IPC > commands and -EINVAL being returned to userspace. > > This patch separates the selection of the internal calling conventions > for the IPC syscalls from the version parsing, allowing architectures to > select __ARCH_WANT_COMPAT_IPC_PARSE_VERSION if they want to use version > parsing whilst retaining the newer syscall calling conventions. > > Cc: Chris Metcalf > Cc: Arnd Bergmann > Acked-by: Catalin Marinas > Signed-off-by: Will Deacon > --- > include/linux/compat.h | 1 + > ipc/compat.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletions(-) > Acked-by: Chris Metcalf -- Chris Metcalf, Tilera Corp. http://www.tilera.com