From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Durgin Subject: Re: [PATCH 02/16] rbd: drop a useless local variable Date: Wed, 11 Jul 2012 11:36:02 -0700 Message-ID: <4FFDC792.5030401@inktank.com> References: <4FFD847C.7070205@inktank.com> <4FFD8710.60002@inktank.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:55343 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755082Ab2GKSgE (ORCPT ); Wed, 11 Jul 2012 14:36:04 -0400 Received: by pbbrp8 with SMTP id rp8so2377277pbb.19 for ; Wed, 11 Jul 2012 11:36:03 -0700 (PDT) In-Reply-To: <4FFD8710.60002@inktank.com> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Alex Elder Cc: ceph-devel@vger.kernel.org Reviewed-by: Josh Durgin On 07/11/2012 07:00 AM, Alex Elder wrote: > In rbd_req_sync_notify_ack(), a local variable was needlessly being > used to hold a null pointer. Just pass NULL instead. > > Signed-off-by: Alex Elder > --- > drivers/block/rbd.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index 8f428a8..2ae3bb0 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -1187,7 +1187,6 @@ static int rbd_req_sync_notify_ack(struct > rbd_device *dev, > const char *obj) > { > struct ceph_osd_req_op *ops; > - struct page **pages = NULL; > int ret; > > ret = rbd_create_rw_ops(&ops, 1, CEPH_OSD_OP_NOTIFY_ACK, 0); > @@ -1200,7 +1199,7 @@ static int rbd_req_sync_notify_ack(struct > rbd_device *dev, > > ret = rbd_do_request(NULL, dev, NULL, CEPH_NOSNAP, > obj, 0, 0, NULL, > - pages, 0, > + NULL, 0, > CEPH_OSD_FLAG_READ, > ops, > 1,