From: Gerd Hoffmann <kraxel@redhat.com> To: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com> Cc: kvm@vger.kernel.org, gleb@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, kevin@koconnor.net, avi@redhat.com, anthony@codemonkey.ws, imammedo@redhat.com Subject: Re: [RFC PATCH v2 05/21][SeaBIOS] pciinit: Fix pcimem_start value Date: Thu, 12 Jul 2012 09:22:14 +0200 [thread overview] Message-ID: <4FFE7B26.1060906@redhat.com> (raw) In-Reply-To: <20120711164528.GC15407@dhcp-192-168-178-175.profitbricks.localdomain> On 07/11/12 18:45, Vasilis Liaskovitis wrote: > Hi, > > On Wed, Jul 11, 2012 at 01:56:19PM +0200, Gerd Hoffmann wrote: >> On 07/11/12 12:31, Vasilis Liaskovitis wrote: >>> In order to hotplug memory between RamSize and BUILD_PCIMEM_START, the pci >>> window needs to start at BUILD_PCIMEM_START (0xe0000000). >>> Otherwise, the guest cannot online new dimms at those ranges due to pci_root >>> window conflicts. (workaround for linux guest is booting with pci=nocrs) >> >>> static void pci_bios_map_devices(struct pci_bus *busses) >>> { >>> - pcimem_start = RamSize; >>> + pcimem_start = BUILD_PCIMEM_START; >> >> It isn't that simple. For the 32bit pci window it will work, but will >> leaves address space unused instead of assigning it to the 32bit pci >> window. For the 64bit pci window it will not work. >> >> You have to walk the dimms and figure what the highest used address is, >> for both below-4g and above-4g. Then fill two variable with it and make >> the pci init code use that instead of RamSize and RamSizeOver4G. > > I see. I already have these values values computed in qemu-kvm, so I can pass > them in a paravirt struct, or infer them from the dimm/srat paravirt info that I > already pass to seabios. I'd suggest to infer from the dimm info, to limit the amout of information which needs to be passed from qemu to seabios. > If i understand correctly, we would like the pcimem windows to use the maximum > possible address space (constrained by the exact dimms/ranges which are defined) > instead of leaving unused space. Yes, for the 32bit pci window. The 64bit pci window is mapped above all memory, and it must likewise consider defined+unfilled dimms so the start address doesn't collide with memory hot-plugged above 4G later on. cheers, Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com> To: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com> Cc: kvm@vger.kernel.org, gleb@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, kevin@koconnor.net, avi@redhat.com, anthony@codemonkey.ws, imammedo@redhat.com Subject: Re: [Qemu-devel] [RFC PATCH v2 05/21][SeaBIOS] pciinit: Fix pcimem_start value Date: Thu, 12 Jul 2012 09:22:14 +0200 [thread overview] Message-ID: <4FFE7B26.1060906@redhat.com> (raw) In-Reply-To: <20120711164528.GC15407@dhcp-192-168-178-175.profitbricks.localdomain> On 07/11/12 18:45, Vasilis Liaskovitis wrote: > Hi, > > On Wed, Jul 11, 2012 at 01:56:19PM +0200, Gerd Hoffmann wrote: >> On 07/11/12 12:31, Vasilis Liaskovitis wrote: >>> In order to hotplug memory between RamSize and BUILD_PCIMEM_START, the pci >>> window needs to start at BUILD_PCIMEM_START (0xe0000000). >>> Otherwise, the guest cannot online new dimms at those ranges due to pci_root >>> window conflicts. (workaround for linux guest is booting with pci=nocrs) >> >>> static void pci_bios_map_devices(struct pci_bus *busses) >>> { >>> - pcimem_start = RamSize; >>> + pcimem_start = BUILD_PCIMEM_START; >> >> It isn't that simple. For the 32bit pci window it will work, but will >> leaves address space unused instead of assigning it to the 32bit pci >> window. For the 64bit pci window it will not work. >> >> You have to walk the dimms and figure what the highest used address is, >> for both below-4g and above-4g. Then fill two variable with it and make >> the pci init code use that instead of RamSize and RamSizeOver4G. > > I see. I already have these values values computed in qemu-kvm, so I can pass > them in a paravirt struct, or infer them from the dimm/srat paravirt info that I > already pass to seabios. I'd suggest to infer from the dimm info, to limit the amout of information which needs to be passed from qemu to seabios. > If i understand correctly, we would like the pcimem windows to use the maximum > possible address space (constrained by the exact dimms/ranges which are defined) > instead of leaving unused space. Yes, for the 32bit pci window. The 64bit pci window is mapped above all memory, and it must likewise consider defined+unfilled dimms so the start address doesn't collide with memory hot-plugged above 4G later on. cheers, Gerd
next prev parent reply other threads:[~2012-07-12 7:22 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-11 10:31 [RFC PATCH v2 00/21] ACPI memory hotplug Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 01/21][SeaBIOS] Add ACPI_EXTRACT_DEVICE* macros Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 02/21][SeaBIOS] Add SSDT memory device support Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 03/21][SeaBIOS] acpi-dsdt: Implement functions for memory hotplug Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-17 7:23 ` Wen Congyang 2012-07-17 7:23 ` [Qemu-devel] " Wen Congyang 2012-07-20 8:48 ` Vasilis Liaskovitis 2012-07-20 8:48 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 04/21][SeaBIOS] acpi: generate hotplug memory devices Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:48 ` Wen Congyang 2012-07-11 10:48 ` [Qemu-devel] " Wen Congyang 2012-07-11 16:39 ` Vasilis Liaskovitis 2012-07-11 16:39 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 05/21][SeaBIOS] pciinit: Fix pcimem_start value Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 11:56 ` Gerd Hoffmann 2012-07-11 11:56 ` [Qemu-devel] " Gerd Hoffmann 2012-07-11 16:45 ` Vasilis Liaskovitis 2012-07-11 16:45 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-12 7:22 ` Gerd Hoffmann [this message] 2012-07-12 7:22 ` Gerd Hoffmann 2012-07-12 9:09 ` Vasilis Liaskovitis 2012-07-12 9:09 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 06/21] dimm: Implement memory device abstraction Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-12 19:55 ` Blue Swirl 2012-07-12 19:55 ` [Qemu-devel] " Blue Swirl 2012-07-13 17:39 ` Vasilis Liaskovitis 2012-07-13 17:39 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 07/21] acpi_piix4: Implement memory device hotplug registers Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 08/21] pc: calculate dimm physical addresses and adjust memory map Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 09/21] pc: Add dimm paravirt SRAT info Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-12 19:48 ` Blue Swirl 2012-07-12 19:48 ` [Qemu-devel] " Blue Swirl 2012-07-13 17:40 ` Vasilis Liaskovitis 2012-07-13 17:40 ` Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 10/21] Implement "-dimm" command line option Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 11/21] Implement dimm_add and dimm_del hmp/qmp commands Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 12/21] fix live-migration when "populated=on" is missing Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 13/21] Implement memory hotplug notification lists Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 14:59 ` Eric Blake 2012-07-11 14:59 ` Eric Blake 2012-07-11 16:47 ` Vasilis Liaskovitis 2012-07-11 16:47 ` Vasilis Liaskovitis 2012-07-11 10:31 ` [RFC PATCH v2 14/21][SeaBIOS] acpi_dsdt: Support _OST dimm method Vasilis Liaskovitis 2012-07-11 10:31 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:32 ` [RFC PATCH v2 15/21] acpi_piix4: _OST dimm support Vasilis Liaskovitis 2012-07-11 10:32 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:32 ` [RFC PATCH v2 16/21] acpi_piix4: Update dimm state on VM reboot Vasilis Liaskovitis 2012-07-11 10:32 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:32 ` [RFC PATCH v2 17/21][SeaBIOS] acpi_dsdt: Revert internal dimm state on _OST failure Vasilis Liaskovitis 2012-07-11 10:32 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:32 ` [RFC PATCH v2 18/21] acpi_piix4: Update dimm bitmap state on hot-remove fail Vasilis Liaskovitis 2012-07-11 10:32 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:32 ` [RFC PATCH v2 19/21] Implement "info memtotal" and "query-memtotal" Vasilis Liaskovitis 2012-07-11 10:32 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 15:14 ` Eric Blake 2012-07-11 15:14 ` [Qemu-devel] " Eric Blake 2012-07-11 16:55 ` Vasilis Liaskovitis 2012-07-11 16:55 ` Vasilis Liaskovitis 2012-07-11 10:32 ` [RFC PATCH v2 20/21] Implement -dimms, -dimmspop command line options Vasilis Liaskovitis 2012-07-11 10:32 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 14:55 ` Avi Kivity 2012-07-11 14:55 ` [Qemu-devel] " Avi Kivity 2012-07-11 16:57 ` Vasilis Liaskovitis 2012-07-11 16:57 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-11 10:32 ` [RFC PATCH v2 21/21] Implement mem_increase, mem_decrease hmp/qmp commands Vasilis Liaskovitis 2012-07-11 10:32 ` [Qemu-devel] " Vasilis Liaskovitis 2012-07-12 20:04 ` [Qemu-devel] [RFC PATCH v2 00/21] ACPI memory hotplug Blue Swirl 2012-07-12 20:04 ` Blue Swirl 2012-07-13 17:49 ` Vasilis Liaskovitis 2012-07-13 17:49 ` Vasilis Liaskovitis 2012-07-14 9:08 ` Blue Swirl 2012-07-14 9:08 ` [Qemu-devel] " Blue Swirl
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4FFE7B26.1060906@redhat.com \ --to=kraxel@redhat.com \ --cc=anthony@codemonkey.ws \ --cc=avi@redhat.com \ --cc=gleb@redhat.com \ --cc=imammedo@redhat.com \ --cc=kevin@koconnor.net \ --cc=kvm@vger.kernel.org \ --cc=qemu-devel@nongnu.org \ --cc=seabios@seabios.org \ --cc=vasilis.liaskovitis@profitbricks.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.