All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Asias He <asias.hejun@gmail.com>
Cc: Pekka Enberg <penberg@kernel.org>,
	Sasha Levin <levinsasha928@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Cyrill Gorcunov <gorcunov@gmail.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 1/2] kvm tools: Fix VHOST_SET_MEM_TABLE failure
Date: Thu, 12 Jul 2012 11:19:47 +0300	[thread overview]
Message-ID: <4FFE88A3.8010408@redhat.com> (raw)
In-Reply-To: <CAFO3S42H7VWhpYYct8iNqEwBxcXsCS=p9Dvd6mgjV5cZJU1vag@mail.gmail.com>

On 07/12/2012 05:46 AM, Asias He wrote:
> On Thu, Jul 12, 2012 at 12:09 AM, Avi Kivity <avi@redhat.com> wrote:
>> On 07/11/2012 07:08 PM, Asias He wrote:
>>> VHOST_SET_MEM_TABLE failed: Operation not supported
>>>
>>> In vhost_set_memory(), We have
>>>
>>>         if (mem.padding)
>>>                 return -EOPNOTSUPP;
>>>
>>> So, we need to zero struct vhost_memory.
>>>
>>
>> Is this due to a change in vhost?
> 
> Seems we have this bit in the very beginning (commit 3a4d5c94).

Okay, so it's a documentation problem.  Michael, where is the
documentation for vhost-net?

Note we have to initialize it with memset(); presumably when we
repurpose it the name will change, and anonymous unions are not very
portable.

-- 
error compiling committee.c: too many arguments to function



  reply	other threads:[~2012-07-12  8:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 16:08 [PATCH v2 1/2] kvm tools: Fix VHOST_SET_MEM_TABLE failure Asias He
2012-07-11 16:08 ` [PATCH v2 2/2] kvm tools: Do not poll ioeventfd if vhost is enabled Asias He
2012-07-11 16:09 ` [PATCH v2 1/2] kvm tools: Fix VHOST_SET_MEM_TABLE failure Avi Kivity
2012-07-12  2:46   ` Asias He
2012-07-12  8:19     ` Avi Kivity [this message]
2012-07-12 23:27       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFE88A3.8010408@redhat.com \
    --to=avi@redhat.com \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=mingo@elte.hu \
    --cc=mst@redhat.com \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.