From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39059)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SpJi3-0008Cc-VL
	for qemu-devel@nongnu.org; Thu, 12 Jul 2012 09:45:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SpJhy-0001Ab-0B
	for qemu-devel@nongnu.org; Thu, 12 Jul 2012 09:45:35 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:46743)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SpJhx-0001AV-Ll
	for qemu-devel@nongnu.org; Thu, 12 Jul 2012 09:45:29 -0400
Received: by pbbro12 with SMTP id ro12so3968050pbb.4
	for <qemu-devel@nongnu.org>; Thu, 12 Jul 2012 06:45:28 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FFED4F2.50906@redhat.com>
Date: Thu, 12 Jul 2012 15:45:22 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com>
	<1339772759-31004-23-git-send-email-pbonzini@redhat.com>
	<4FDB7CE7.7090005@redhat.com>
In-Reply-To: <4FDB7CE7.7090005@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 22/36] block: add mirror job
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com, lcapitulino@redhat.com

Il 15/06/2012 20:20, Eric Blake ha scritto:
>> > The second phase is indicated by the progress in "info block-jobs"
>> > reporting the current offset to be equal to the length of the file.
>> > When the job is cancelled in the second phase, QEMU will run the
>> > job until the source is clean and quiescent, then it will report
>> > successful completion of the job.  (Note that it could already happen
>> > that management lost the race against QEMU and got a completion
>> > event instead of cancellation).
> Is this paragraph still accurate?  At any rate, it sounds a bit
> confusing - if I run 'block-job-cancel', do I get a 'complete' or a
> 'cancelled' event?  Or is it a question of _which_ event I get depending
> on how a race goes?

For streaming, the latter.  Same for mirroring in the first phase.

Mirroring in the second phase will always give you an error or completed
event.

Paolo