All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Subject: Re: [PATCH v4] iio: add adjd_s311 I2C digital color sensor driver
Date: Thu, 12 Jul 2012 20:26:48 +0100	[thread overview]
Message-ID: <4FFF24F8.8040304@kernel.org> (raw)
In-Reply-To: <4FF29F85.6050900@metafoo.de>

On 07/03/2012 08:30 AM, Lars-Peter Clausen wrote:
> On 07/02/2012 11:43 PM, Peter Meerwald wrote:
>> sensor has 4 channels (10-bit each, R/G/B and clear), sensitivity
>> and gain is controlled in the driver by ext_info integration_time
>> and CHAN_INFO_HARDWAREGAIN
>>
>> driver supports triggered buffer and IIO_CHAN_INFO_RAW to get the
>> sensor data
>>
>> patch depends on IIO_MOD_LIGHT_RED etc, the patch providing that
>> (http://permalink.gmane.org/gmane.linux.kernel.iio/4354) has not been
>> merged yet, a new proposal is following
>>
>> v4: address comments by Lars-Peter Clausen
>> * make sure trigger handler is exited with iio_trigger_notify_done()
>>   and IRQ_HANDLED
>> * kfree()/kalloc() -> krealloc()
>>
>> v3:
>> * fix warnings
>>
>> v2: address comments by Lars-Peter Clausen
>> * buffer allocation now in update_scan_mode instead of in trigger
>>   handler
>> * simplify trigger code (assume active_scan_mask is not empty, use
>>   for_each_set_bit, use iio_push_to_buffer)
>> * reorder entry in Makefile and Kconfig
>> * fix remove
>>
>> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> 
> Looks good,
> 
> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Sorry Lars-Peter, I'd forgotten you'd done that for this earlier
version so didn't add it to v5 when merging.  Peter, if you make minor
changes people 'normally' don't mind if you carry there acked-by
etc on with it.

  reply	other threads:[~2012-07-12 19:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 21:43 [PATCH v4] iio: add adjd_s311 I2C digital color sensor driver Peter Meerwald
2012-07-03  7:30 ` Lars-Peter Clausen
2012-07-12 19:26   ` Jonathan Cameron [this message]
2012-07-08  9:22 ` Jonathan Cameron
2012-07-10 21:29   ` Peter Meerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFF24F8.8040304@kernel.org \
    --to=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.