From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E92CC433F5 for ; Tue, 21 Dec 2021 08:23:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 72E368344C; Tue, 21 Dec 2021 09:23:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Ek1PWBH9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9960E832DE; Tue, 21 Dec 2021 09:23:26 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C7A32830A2 for ; Tue, 21 Dec 2021 09:23:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640074999; bh=LOcCSkI3mc3D/pH+uj9M5e2EH+n5uYzSa0+IuvYcQ2Y=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=Ek1PWBH97VbuCp0Ow0Dg4JQzd97puc6Vwz7gJGuz2Phu2dK21VuWxfIo3f9hJhYvk IWGXPWWomsY/1GLrkUXUykxslwVgtj9sbTuCt+kWLw2fuq64y8/te3HwoFVQ338A5o nx4rXlzx7PSUPvkytIDsI3JqASCCfG4d6ySkVTfQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N9Mta-1mN4BX2WQu-015J2B; Tue, 21 Dec 2021 09:23:19 +0100 Message-ID: <4a10fca0-f02d-5c41-8bd7-0cb5e83c7fee@gmx.de> Date: Tue, 21 Dec 2021 09:23:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v7 09/24] efi: Add a few comments to the stub Content-Language: en-US To: Simon Glass Cc: Tom Rini , Christian Melki , Ilias Apalodimas , Bin Meng , Alexander Graf , U-Boot Mailing List References: <20211218182850.1121923-1-sjg@chromium.org> <20211218182850.1121923-9-sjg@chromium.org> From: Heinrich Schuchardt In-Reply-To: <20211218182850.1121923-9-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:GAEDxJcQAsjASyC87aKKGZBLutzU0bcelnuZaMjpZwGrBb1AtA+ 1bkCget5CI0kjH9iYJvKB10YqA3mQfMLiG9gmSik/iL0t4+NqKrV0wPz5NySOIb1lvfbVCP McUS3jgO0tmMnoVo/02o9ocGKwoanzntfhxP9lK5vo4QcvSP/UoFysCP6M0xPLYQRBWrUkF gXGwP5Y2J44Stcws2Lkfw== X-UI-Out-Filterresults: notjunk:1;V03:K0:lXglUGkU+sI=:TYgoFp1KCP8xwNTFikuyA3 rZ0q36OrxQwo0CIFI9VGUpDBVtlPhXQXzBaU7tWmozHlPgZy28b+g9guUAOgfOna28/7tzuB4 7QpJG4PtzGCGDNOvzkRD0N1c7yuKExcNl2wgnT2cfvwpXFENcCpf6WKZKnojPpsOcmNkwEgIm s0Fe9bSocvnssvesVibjr5l5eaU7VutuiUbb2DvzVwy2NU6KswbGvp9lD8ktcZArqMgKeiQGR wZtdbG7+wbjhds8JEHwjUUdr3fHYOmAj7cynMqTEZ31VN9PaO86f92//ENstkdfAfEgZmWkmi LBW/6BcuFIQw58zE7fpqcFpfcPy/2V0ThqfOLxqiUsX6+wvwwZBGs/uQc9tIDvdgUJXUvhcmI TQBYPUAXO1+kIC/mCnxR8ss1tkXLvTxh2Yr3gTmi4WjeuopMDfd/KQMQGsYYVvNAbJab7GyVR 9p5lb9L0OacIU9x8MC5wcp8ieVoFR90r7Kh3v5DjS8LXVafu5/81e3nMhNe2wFfrF/AhkMXOb DvZ8WgFNSsLJTZ9Ik+Zb98azV+wqTZUPz63e1p2Cw3Dr7kYZ4JS7lIikER5DFezWAoDmKUXHU t1OkesZrCuVekQEzUTS/H2RroL8Kv4r+ZqhIYFG+LiUgC2LKHVGBTW1EBKSygyLfUmPGtN4m6 ubDVv9auTqLYvnGWB69Hb6CW2e50W8goRluabLIhnpOryx/SzwXAjp6m9zP4xBCnVnkjepOo9 HJWOp5MvWf3TRworB7NpHOQo77ylkGSge6ZYUIbsZmXtyPBEh3aIZqHfIR0SXm6bxLdYVQe5w vPXxIoBYOnYTg1wxl165R8P3XQCCYKmOyaULUydAz86iKvDvCMoGcG0Vk0EYJcyMCUz//tzpC RSgonu9h2221SLlBaHHgZHD3pBAQW3ahpSEbnt7MR4VNoqogPvtcydwaFph8lJSDEwcsVq8nb GMCInYb6GrtsT36zs1808m4nq87cb6km2D5BMTeZ1UIbLa6ekM7dRRzvnTINDwEQ+5nqSKc04 bDH5ZcvGjQ3UOH8sMgvtfdMgdPLBnyhZvEVZH7Q2R2aZ2HS+/gPvtBRSrTkBEBzXYn56f9BDY EjCdHF8gPHW8Cw= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/18/21 19:28, Simon Glass wrote: > Comment some functions that need more information. > > Signed-off-by: Simon Glass > --- > > (no changes since v6) > > Changes in v6: > - Fix comment style in setup_info_table() > > lib/efi/efi_stub.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/lib/efi/efi_stub.c b/lib/efi/efi_stub.c > index b3393e47fae..e8a594cb2aa 100644 > --- a/lib/efi/efi_stub.c > +++ b/lib/efi/efi_stub.c > @@ -225,6 +225,22 @@ static int get_codeseg32(void) > return cs32; > } > > +/** > + * setup_info_table() - sets up a table containing information from EFI > + * > + * We must call exit_boot_services() before jumping out of the stub int= o U-Boot > + * proper, so that U-Boot has full control of peripherals, memory, etc. > + * > + * Once we do this, we cannot call any boot-services functions so we mu= st find > + * out everything we need to before doing that. > + * > + * Set up a struct efi_info_hdr table which can hold various records (e= .g. > + * struct efi_entry_memmap) with information obtained from EFI. > + * > + * @priv: Pointer to our private information which contains the list > + * @size: Size of the table to allocate > + * Return: 0 if OK, non-zero on error > + */ > static int setup_info_table(struct efi_priv *priv, int size) > { > struct efi_info_hdr *info; > @@ -248,6 +264,12 @@ static int setup_info_table(struct efi_priv *priv, = int size) > return 0; > } > > +/** > + * add_entry_addr() - Add a new entry to the efi_info list > + * > + * @priv: Pointer to our private information which contains the list You missed a few arguments. Best regards Heinrich > + * > + */ > static void add_entry_addr(struct efi_priv *priv, enum efi_entry_t typ= e, > void *ptr1, int size1, void *ptr2, int size2) > {