From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE75C35E01 for ; Tue, 25 Feb 2020 13:24:14 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9245C20726 for ; Tue, 25 Feb 2020 13:24:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9245C20726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 2E15A10FC3590; Tue, 25 Feb 2020 05:25:06 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=fbarrat@linux.ibm.com; receiver= Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7E2C210FC33FB for ; Tue, 25 Feb 2020 05:25:04 -0800 (PST) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01PDNW5D040401 for ; Tue, 25 Feb 2020 08:24:12 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yb1b8k7kb-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 25 Feb 2020 08:24:11 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Feb 2020 13:24:08 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 25 Feb 2020 13:24:01 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01PDO0jc51773506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Feb 2020 13:24:00 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F0CB611C05B; Tue, 25 Feb 2020 13:23:59 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C212811C058; Tue, 25 Feb 2020 13:23:58 +0000 (GMT) Received: from bali.tlslab.ibm.com (unknown [9.101.4.17]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 25 Feb 2020 13:23:58 +0000 (GMT) Subject: Re: [PATCH v3 04/27] ocxl: Remove unnecessary externs To: "Alastair D'Silva" , alastair@d-silva.org References: <20200221032720.33893-1-alastair@au1.ibm.com> <20200221032720.33893-5-alastair@au1.ibm.com> From: Frederic Barrat Date: Tue, 25 Feb 2020 14:23:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200221032720.33893-5-alastair@au1.ibm.com> Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 20022513-4275-0000-0000-000003A552DA X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20022513-4276-0000-0000-000038B968AA Message-Id: <4a29677a-885e-d493-c9f0-2698ea41a58c@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-25_04:2020-02-21,2020-02-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 mlxscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 adultscore=0 impostorscore=0 clxscore=1011 priorityscore=1501 suspectscore=2 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002250106 Message-ID-Hash: EU7D43OKQYZ42RR3ASFYB65H3F5OEVF3 X-Message-ID-Hash: EU7D43OKQYZ42RR3ASFYB65H3F5OEVF3 X-MailFrom: fbarrat@linux.ibm.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: "Aneesh Kumar K . V" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , linux-kernel@vger.kernel.org, linuxppc-de v@lists.ozlabs.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 DQoNCkxlIDIxLzAyLzIwMjAgw6AgMDQ6MjYsIEFsYXN0YWlyIEQnU2lsdmEgYSDDqWNyaXTCoDoN Cj4gRnJvbTogQWxhc3RhaXIgRCdTaWx2YSA8YWxhc3RhaXJAZC1zaWx2YS5vcmc+DQo+IA0KPiBG dW5jdGlvbiBkZWNsYXJhdGlvbnMgZG9uJ3QgbmVlZCBleHRlcm5zLCByZW1vdmUgdGhlIGV4aXN0 aW5nIG9uZXMNCj4gc28gdGhleSBhcmUgY29uc2lzdGVudCB3aXRoIG5ld2VyIGNvZGUNCj4gDQo+ IFNpZ25lZC1vZmYtYnk6IEFsYXN0YWlyIEQnU2lsdmEgPGFsYXN0YWlyQGQtc2lsdmEub3JnPg0K PiAtLS0NCg0KVGhhbmtzIGZvciB0aGUgY2xlYW51cCENCkFja2VkLWJ5OiBGcmVkZXJpYyBCYXJy YXQgPGZiYXJyYXRAbGludXguaWJtLmNvbT4NCg0KDQoNCg0KPiAgIGFyY2gvcG93ZXJwYy9pbmNs dWRlL2FzbS9wbnYtb2N4bC5oIHwgMzIgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0NCj4g ICBpbmNsdWRlL21pc2Mvb2N4bC5oICAgICAgICAgICAgICAgICB8ICA2ICsrKy0tLQ0KPiAgIDIg ZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pDQo+IA0KPiBk aWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL3Budi1vY3hsLmggYi9hcmNoL3Bv d2VycGMvaW5jbHVkZS9hc20vcG52LW9jeGwuaA0KPiBpbmRleCAwYjJhNjcwN2U1NTUuLmIyM2M5 OWJjMGM4NCAxMDA2NDQNCj4gLS0tIGEvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL3Budi1vY3hs LmgNCj4gKysrIGIvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL3Budi1vY3hsLmgNCj4gQEAgLTks MjkgKzksMjcgQEANCj4gICAjZGVmaW5lIFBOVl9PQ1hMX1RMX0JJVFNfUEVSX1JBVEUgICAgICAg NA0KPiAgICNkZWZpbmUgUE5WX09DWExfVExfUkFURV9CVUZfU0laRSAgICAgICAoKFBOVl9PQ1hM X1RMX01BWF9URU1QTEFURSsxKSAqIFBOVl9PQ1hMX1RMX0JJVFNfUEVSX1JBVEUgLyA4KQ0KPiAg IA0KPiAtZXh0ZXJuIGludCBwbnZfb2N4bF9nZXRfYWN0YWcoc3RydWN0IHBjaV9kZXYgKmRldiwg dTE2ICpiYXNlLCB1MTYgKmVuYWJsZWQsDQo+IC0JCQl1MTYgKnN1cHBvcnRlZCk7DQo+IC1leHRl cm4gaW50IHBudl9vY3hsX2dldF9wYXNpZF9jb3VudChzdHJ1Y3QgcGNpX2RldiAqZGV2LCBpbnQg KmNvdW50KTsNCj4gK2ludCBwbnZfb2N4bF9nZXRfYWN0YWcoc3RydWN0IHBjaV9kZXYgKmRldiwg dTE2ICpiYXNlLCB1MTYgKmVuYWJsZWQsIHUxNiAqc3VwcG9ydGVkKTsNCj4gK2ludCBwbnZfb2N4 bF9nZXRfcGFzaWRfY291bnQoc3RydWN0IHBjaV9kZXYgKmRldiwgaW50ICpjb3VudCk7DQo+ICAg DQo+IC1leHRlcm4gaW50IHBudl9vY3hsX2dldF90bF9jYXAoc3RydWN0IHBjaV9kZXYgKmRldiwg bG9uZyAqY2FwLA0KPiAraW50IHBudl9vY3hsX2dldF90bF9jYXAoc3RydWN0IHBjaV9kZXYgKmRl diwgbG9uZyAqY2FwLA0KPiAgIAkJCWNoYXIgKnJhdGVfYnVmLCBpbnQgcmF0ZV9idWZfc2l6ZSk7 DQo+IC1leHRlcm4gaW50IHBudl9vY3hsX3NldF90bF9jb25mKHN0cnVjdCBwY2lfZGV2ICpkZXYs IGxvbmcgY2FwLA0KPiAraW50IHBudl9vY3hsX3NldF90bF9jb25mKHN0cnVjdCBwY2lfZGV2ICpk ZXYsIGxvbmcgY2FwLA0KPiAgIAkJCXVpbnQ2NF90IHJhdGVfYnVmX3BoeXMsIGludCByYXRlX2J1 Zl9zaXplKTsNCj4gICANCj4gLWV4dGVybiBpbnQgcG52X29jeGxfZ2V0X3hzbF9pcnEoc3RydWN0 IHBjaV9kZXYgKmRldiwgaW50ICpod2lycSk7DQo+IC1leHRlcm4gdm9pZCBwbnZfb2N4bF91bm1h cF94c2xfcmVncyh2b2lkIF9faW9tZW0gKmRzaXNyLCB2b2lkIF9faW9tZW0gKmRhciwNCj4gLQkJ CQl2b2lkIF9faW9tZW0gKnRmYywgdm9pZCBfX2lvbWVtICpwZV9oYW5kbGUpOw0KPiAtZXh0ZXJu IGludCBwbnZfb2N4bF9tYXBfeHNsX3JlZ3Moc3RydWN0IHBjaV9kZXYgKmRldiwgdm9pZCBfX2lv bWVtICoqZHNpc3IsDQo+IC0JCQkJdm9pZCBfX2lvbWVtICoqZGFyLCB2b2lkIF9faW9tZW0gKip0 ZmMsDQo+IC0JCQkJdm9pZCBfX2lvbWVtICoqcGVfaGFuZGxlKTsNCj4gK2ludCBwbnZfb2N4bF9n ZXRfeHNsX2lycShzdHJ1Y3QgcGNpX2RldiAqZGV2LCBpbnQgKmh3aXJxKTsNCj4gK3ZvaWQgcG52 X29jeGxfdW5tYXBfeHNsX3JlZ3Modm9pZCBfX2lvbWVtICpkc2lzciwgdm9pZCBfX2lvbWVtICpk YXIsDQo+ICsJCQkgICAgIHZvaWQgX19pb21lbSAqdGZjLCB2b2lkIF9faW9tZW0gKnBlX2hhbmRs ZSk7DQo+ICtpbnQgcG52X29jeGxfbWFwX3hzbF9yZWdzKHN0cnVjdCBwY2lfZGV2ICpkZXYsIHZv aWQgX19pb21lbSAqKmRzaXNyLA0KPiArCQkJICB2b2lkIF9faW9tZW0gKipkYXIsIHZvaWQgX19p b21lbSAqKnRmYywNCj4gKwkJCSAgdm9pZCBfX2lvbWVtICoqcGVfaGFuZGxlKTsNCj4gICANCj4g LWV4dGVybiBpbnQgcG52X29jeGxfc3BhX3NldHVwKHN0cnVjdCBwY2lfZGV2ICpkZXYsIHZvaWQg KnNwYV9tZW0sIGludCBQRV9tYXNrLA0KPiAtCQkJdm9pZCAqKnBsYXRmb3JtX2RhdGEpOw0KPiAt ZXh0ZXJuIHZvaWQgcG52X29jeGxfc3BhX3JlbGVhc2Uodm9pZCAqcGxhdGZvcm1fZGF0YSk7DQo+ IC1leHRlcm4gaW50IHBudl9vY3hsX3NwYV9yZW1vdmVfcGVfZnJvbV9jYWNoZSh2b2lkICpwbGF0 Zm9ybV9kYXRhLCBpbnQgcGVfaGFuZGxlKTsNCj4gK2ludCBwbnZfb2N4bF9zcGFfc2V0dXAoc3Ry dWN0IHBjaV9kZXYgKmRldiwgdm9pZCAqc3BhX21lbSwgaW50IFBFX21hc2ssIHZvaWQgKipwbGF0 Zm9ybV9kYXRhKTsNCj4gK3ZvaWQgcG52X29jeGxfc3BhX3JlbGVhc2Uodm9pZCAqcGxhdGZvcm1f ZGF0YSk7DQo+ICtpbnQgcG52X29jeGxfc3BhX3JlbW92ZV9wZV9mcm9tX2NhY2hlKHZvaWQgKnBs YXRmb3JtX2RhdGEsIGludCBwZV9oYW5kbGUpOw0KPiAgIA0KPiAtZXh0ZXJuIGludCBwbnZfb2N4 bF9hbGxvY194aXZlX2lycSh1MzIgKmlycSwgdTY0ICp0cmlnZ2VyX2FkZHIpOw0KPiAtZXh0ZXJu IHZvaWQgcG52X29jeGxfZnJlZV94aXZlX2lycSh1MzIgaXJxKTsNCj4gK2ludCBwbnZfb2N4bF9h bGxvY194aXZlX2lycSh1MzIgKmlycSwgdTY0ICp0cmlnZ2VyX2FkZHIpOw0KPiArdm9pZCBwbnZf b2N4bF9mcmVlX3hpdmVfaXJxKHUzMiBpcnEpOw0KPiAgICNpZmRlZiBDT05GSUdfTUVNT1JZX0hP VFBMVUdfU1BBUlNFDQo+ICAgdTY0IHBudl9vY3hsX3BsYXRmb3JtX2xwY19zZXR1cChzdHJ1Y3Qg cGNpX2RldiAqcGRldiwgdTY0IHNpemUpOw0KPiAgIHZvaWQgcG52X29jeGxfcGxhdGZvcm1fbHBj X3JlbGVhc2Uoc3RydWN0IHBjaV9kZXYgKnBkZXYpOw0KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9t aXNjL29jeGwuaCBiL2luY2x1ZGUvbWlzYy9vY3hsLmgNCj4gaW5kZXggMDZkZDU4MzllNDM4Li4w YTc2MmUzODc0MTggMTAwNjQ0DQo+IC0tLSBhL2luY2x1ZGUvbWlzYy9vY3hsLmgNCj4gKysrIGIv aW5jbHVkZS9taXNjL29jeGwuaA0KPiBAQCAtMTczLDcgKzE3Myw3IEBAIGludCBvY3hsX2NvbnRl eHRfZGV0YWNoKHN0cnVjdCBvY3hsX2NvbnRleHQgKmN0eCk7DQo+ICAgICoNCj4gICAgKiBSZXR1 cm5zIDAgb24gc3VjY2VzcywgbmVnYXRpdmUgb24gZmFpbHVyZQ0KPiAgICAqLw0KPiAtZXh0ZXJu IGludCBvY3hsX2FmdV9pcnFfYWxsb2Moc3RydWN0IG9jeGxfY29udGV4dCAqY3R4LCBpbnQgKmly cV9pZCk7DQo+ICtpbnQgb2N4bF9hZnVfaXJxX2FsbG9jKHN0cnVjdCBvY3hsX2NvbnRleHQgKmN0 eCwgaW50ICppcnFfaWQpOw0KPiAgIA0KPiAgIC8qKg0KPiAgICAqIEZyZWVzIGFuIElSUSBhc3Nv Y2lhdGVkIHdpdGggYW4gQUZVIGNvbnRleHQNCj4gQEAgLTE4Miw3ICsxODIsNyBAQCBleHRlcm4g aW50IG9jeGxfYWZ1X2lycV9hbGxvYyhzdHJ1Y3Qgb2N4bF9jb250ZXh0ICpjdHgsIGludCAqaXJx X2lkKTsNCj4gICAgKg0KPiAgICAqIFJldHVybnMgMCBvbiBzdWNjZXNzLCBuZWdhdGl2ZSBvbiBm YWlsdXJlDQo+ICAgICovDQo+IC1leHRlcm4gaW50IG9jeGxfYWZ1X2lycV9mcmVlKHN0cnVjdCBv Y3hsX2NvbnRleHQgKmN0eCwgaW50IGlycV9pZCk7DQo+ICtpbnQgb2N4bF9hZnVfaXJxX2ZyZWUo c3RydWN0IG9jeGxfY29udGV4dCAqY3R4LCBpbnQgaXJxX2lkKTsNCj4gICANCj4gICAvKioNCj4g ICAgKiBHZXRzIHRoZSBhZGRyZXNzIG9mIHRoZSB0cmlnZ2VyIHBhZ2UgZm9yIGFuIElSUQ0KPiBA QCAtMTkzLDcgKzE5Myw3IEBAIGV4dGVybiBpbnQgb2N4bF9hZnVfaXJxX2ZyZWUoc3RydWN0IG9j eGxfY29udGV4dCAqY3R4LCBpbnQgaXJxX2lkKTsNCj4gICAgKg0KPiAgICAqIHJldHVybnMgdGhl IHRyaWdnZXIgcGFnZSBhZGRyZXNzLCBvciAwIGlmIHRoZSBJUlEgaXMgbm90IHZhbGlkDQo+ICAg ICovDQo+IC1leHRlcm4gdTY0IG9jeGxfYWZ1X2lycV9nZXRfYWRkcihzdHJ1Y3Qgb2N4bF9jb250 ZXh0ICpjdHgsIGludCBpcnFfaWQpOw0KPiArdTY0IG9jeGxfYWZ1X2lycV9nZXRfYWRkcihzdHJ1 Y3Qgb2N4bF9jb250ZXh0ICpjdHgsIGludCBpcnFfaWQpOw0KPiAgIA0KPiAgIC8qKg0KPiAgICAq IFByb3ZpZGUgYSBjYWxsYmFjayB0byBiZSBjYWxsZWQgd2hlbiBhbiBJUlEgaXMgdHJpZ2dlcmVk DQo+IA0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGlu dXgtbnZkaW1tIG1haWxpbmcgbGlzdCAtLSBsaW51eC1udmRpbW1AbGlzdHMuMDEub3JnClRvIHVu c3Vic2NyaWJlIHNlbmQgYW4gZW1haWwgdG8gbGludXgtbnZkaW1tLWxlYXZlQGxpc3RzLjAxLm9y Zwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FFF9C35DF5 for ; Tue, 25 Feb 2020 13:24:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 251C221927 for ; Tue, 25 Feb 2020 13:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730193AbgBYNYM (ORCPT ); Tue, 25 Feb 2020 08:24:12 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43738 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729386AbgBYNYM (ORCPT ); Tue, 25 Feb 2020 08:24:12 -0500 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01PDNlkL090235 for ; Tue, 25 Feb 2020 08:24:11 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ycxcxvjwa-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 25 Feb 2020 08:24:11 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Feb 2020 13:24:08 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 25 Feb 2020 13:24:01 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01PDO0jc51773506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Feb 2020 13:24:00 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F0CB611C05B; Tue, 25 Feb 2020 13:23:59 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C212811C058; Tue, 25 Feb 2020 13:23:58 +0000 (GMT) Received: from bali.tlslab.ibm.com (unknown [9.101.4.17]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 25 Feb 2020 13:23:58 +0000 (GMT) Subject: Re: [PATCH v3 04/27] ocxl: Remove unnecessary externs To: "Alastair D'Silva" , alastair@d-silva.org Cc: "Aneesh Kumar K . V" , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org References: <20200221032720.33893-1-alastair@au1.ibm.com> <20200221032720.33893-5-alastair@au1.ibm.com> From: Frederic Barrat Date: Tue, 25 Feb 2020 14:23:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200221032720.33893-5-alastair@au1.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 20022513-4275-0000-0000-000003A552DA X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20022513-4276-0000-0000-000038B968AA Message-Id: <4a29677a-885e-d493-c9f0-2698ea41a58c@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-25_04:2020-02-21,2020-02-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 clxscore=1011 suspectscore=2 mlxlogscore=999 phishscore=0 mlxscore=0 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002250107 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 21/02/2020 à 04:26, Alastair D'Silva a écrit : > From: Alastair D'Silva > > Function declarations don't need externs, remove the existing ones > so they are consistent with newer code > > Signed-off-by: Alastair D'Silva > --- Thanks for the cleanup! Acked-by: Frederic Barrat > arch/powerpc/include/asm/pnv-ocxl.h | 32 ++++++++++++++--------------- > include/misc/ocxl.h | 6 +++--- > 2 files changed, 18 insertions(+), 20 deletions(-) > > diff --git a/arch/powerpc/include/asm/pnv-ocxl.h b/arch/powerpc/include/asm/pnv-ocxl.h > index 0b2a6707e555..b23c99bc0c84 100644 > --- a/arch/powerpc/include/asm/pnv-ocxl.h > +++ b/arch/powerpc/include/asm/pnv-ocxl.h > @@ -9,29 +9,27 @@ > #define PNV_OCXL_TL_BITS_PER_RATE 4 > #define PNV_OCXL_TL_RATE_BUF_SIZE ((PNV_OCXL_TL_MAX_TEMPLATE+1) * PNV_OCXL_TL_BITS_PER_RATE / 8) > > -extern int pnv_ocxl_get_actag(struct pci_dev *dev, u16 *base, u16 *enabled, > - u16 *supported); > -extern int pnv_ocxl_get_pasid_count(struct pci_dev *dev, int *count); > +int pnv_ocxl_get_actag(struct pci_dev *dev, u16 *base, u16 *enabled, u16 *supported); > +int pnv_ocxl_get_pasid_count(struct pci_dev *dev, int *count); > > -extern int pnv_ocxl_get_tl_cap(struct pci_dev *dev, long *cap, > +int pnv_ocxl_get_tl_cap(struct pci_dev *dev, long *cap, > char *rate_buf, int rate_buf_size); > -extern int pnv_ocxl_set_tl_conf(struct pci_dev *dev, long cap, > +int pnv_ocxl_set_tl_conf(struct pci_dev *dev, long cap, > uint64_t rate_buf_phys, int rate_buf_size); > > -extern int pnv_ocxl_get_xsl_irq(struct pci_dev *dev, int *hwirq); > -extern void pnv_ocxl_unmap_xsl_regs(void __iomem *dsisr, void __iomem *dar, > - void __iomem *tfc, void __iomem *pe_handle); > -extern int pnv_ocxl_map_xsl_regs(struct pci_dev *dev, void __iomem **dsisr, > - void __iomem **dar, void __iomem **tfc, > - void __iomem **pe_handle); > +int pnv_ocxl_get_xsl_irq(struct pci_dev *dev, int *hwirq); > +void pnv_ocxl_unmap_xsl_regs(void __iomem *dsisr, void __iomem *dar, > + void __iomem *tfc, void __iomem *pe_handle); > +int pnv_ocxl_map_xsl_regs(struct pci_dev *dev, void __iomem **dsisr, > + void __iomem **dar, void __iomem **tfc, > + void __iomem **pe_handle); > > -extern int pnv_ocxl_spa_setup(struct pci_dev *dev, void *spa_mem, int PE_mask, > - void **platform_data); > -extern void pnv_ocxl_spa_release(void *platform_data); > -extern int pnv_ocxl_spa_remove_pe_from_cache(void *platform_data, int pe_handle); > +int pnv_ocxl_spa_setup(struct pci_dev *dev, void *spa_mem, int PE_mask, void **platform_data); > +void pnv_ocxl_spa_release(void *platform_data); > +int pnv_ocxl_spa_remove_pe_from_cache(void *platform_data, int pe_handle); > > -extern int pnv_ocxl_alloc_xive_irq(u32 *irq, u64 *trigger_addr); > -extern void pnv_ocxl_free_xive_irq(u32 irq); > +int pnv_ocxl_alloc_xive_irq(u32 *irq, u64 *trigger_addr); > +void pnv_ocxl_free_xive_irq(u32 irq); > #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE > u64 pnv_ocxl_platform_lpc_setup(struct pci_dev *pdev, u64 size); > void pnv_ocxl_platform_lpc_release(struct pci_dev *pdev); > diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h > index 06dd5839e438..0a762e387418 100644 > --- a/include/misc/ocxl.h > +++ b/include/misc/ocxl.h > @@ -173,7 +173,7 @@ int ocxl_context_detach(struct ocxl_context *ctx); > * > * Returns 0 on success, negative on failure > */ > -extern int ocxl_afu_irq_alloc(struct ocxl_context *ctx, int *irq_id); > +int ocxl_afu_irq_alloc(struct ocxl_context *ctx, int *irq_id); > > /** > * Frees an IRQ associated with an AFU context > @@ -182,7 +182,7 @@ extern int ocxl_afu_irq_alloc(struct ocxl_context *ctx, int *irq_id); > * > * Returns 0 on success, negative on failure > */ > -extern int ocxl_afu_irq_free(struct ocxl_context *ctx, int irq_id); > +int ocxl_afu_irq_free(struct ocxl_context *ctx, int irq_id); > > /** > * Gets the address of the trigger page for an IRQ > @@ -193,7 +193,7 @@ extern int ocxl_afu_irq_free(struct ocxl_context *ctx, int irq_id); > * > * returns the trigger page address, or 0 if the IRQ is not valid > */ > -extern u64 ocxl_afu_irq_get_addr(struct ocxl_context *ctx, int irq_id); > +u64 ocxl_afu_irq_get_addr(struct ocxl_context *ctx, int irq_id); > > /** > * Provide a callback to be called when an IRQ is triggered > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA1C7C35DF5 for ; Tue, 25 Feb 2020 13:27:16 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17D7120658 for ; Tue, 25 Feb 2020 13:27:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17D7120658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48RfqN1cHZzDqS2 for ; Wed, 26 Feb 2020 00:27:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=fbarrat@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48Rflz1XxTzDqNS for ; Wed, 26 Feb 2020 00:24:14 +1100 (AEDT) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01PDNXLF040416 for ; Tue, 25 Feb 2020 08:24:12 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yb1b8k7kc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 25 Feb 2020 08:24:11 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Feb 2020 13:24:08 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 25 Feb 2020 13:24:01 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01PDO0jc51773506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Feb 2020 13:24:00 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F0CB611C05B; Tue, 25 Feb 2020 13:23:59 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C212811C058; Tue, 25 Feb 2020 13:23:58 +0000 (GMT) Received: from bali.tlslab.ibm.com (unknown [9.101.4.17]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 25 Feb 2020 13:23:58 +0000 (GMT) Subject: Re: [PATCH v3 04/27] ocxl: Remove unnecessary externs To: "Alastair D'Silva" , alastair@d-silva.org References: <20200221032720.33893-1-alastair@au1.ibm.com> <20200221032720.33893-5-alastair@au1.ibm.com> From: Frederic Barrat Date: Tue, 25 Feb 2020 14:23:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200221032720.33893-5-alastair@au1.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 20022513-4275-0000-0000-000003A552DA X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20022513-4276-0000-0000-000038B968AA Message-Id: <4a29677a-885e-d493-c9f0-2698ea41a58c@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-25_04:2020-02-21, 2020-02-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 mlxscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 adultscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 suspectscore=2 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002250106 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Madhavan Srinivasan , Alexey Kardashevskiy , Masahiro Yamada , Oliver O'Halloran , Mauro Carvalho Chehab , Ira Weiny , Thomas Gleixner , Rob Herring , Dave Jiang , linux-nvdimm@lists.01.org, "Aneesh Kumar K . V" , Krzysztof Kozlowski , Anju T Sudhakar , Mahesh Salgaonkar , Andrew Donnellan , Arnd Bergmann , Greg Kurz , Nicholas Piggin , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Dan Williams , Hari Bathini , linux-mm@kvack.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Vishal Verma , Paul Mackerras , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 21/02/2020 à 04:26, Alastair D'Silva a écrit : > From: Alastair D'Silva > > Function declarations don't need externs, remove the existing ones > so they are consistent with newer code > > Signed-off-by: Alastair D'Silva > --- Thanks for the cleanup! Acked-by: Frederic Barrat > arch/powerpc/include/asm/pnv-ocxl.h | 32 ++++++++++++++--------------- > include/misc/ocxl.h | 6 +++--- > 2 files changed, 18 insertions(+), 20 deletions(-) > > diff --git a/arch/powerpc/include/asm/pnv-ocxl.h b/arch/powerpc/include/asm/pnv-ocxl.h > index 0b2a6707e555..b23c99bc0c84 100644 > --- a/arch/powerpc/include/asm/pnv-ocxl.h > +++ b/arch/powerpc/include/asm/pnv-ocxl.h > @@ -9,29 +9,27 @@ > #define PNV_OCXL_TL_BITS_PER_RATE 4 > #define PNV_OCXL_TL_RATE_BUF_SIZE ((PNV_OCXL_TL_MAX_TEMPLATE+1) * PNV_OCXL_TL_BITS_PER_RATE / 8) > > -extern int pnv_ocxl_get_actag(struct pci_dev *dev, u16 *base, u16 *enabled, > - u16 *supported); > -extern int pnv_ocxl_get_pasid_count(struct pci_dev *dev, int *count); > +int pnv_ocxl_get_actag(struct pci_dev *dev, u16 *base, u16 *enabled, u16 *supported); > +int pnv_ocxl_get_pasid_count(struct pci_dev *dev, int *count); > > -extern int pnv_ocxl_get_tl_cap(struct pci_dev *dev, long *cap, > +int pnv_ocxl_get_tl_cap(struct pci_dev *dev, long *cap, > char *rate_buf, int rate_buf_size); > -extern int pnv_ocxl_set_tl_conf(struct pci_dev *dev, long cap, > +int pnv_ocxl_set_tl_conf(struct pci_dev *dev, long cap, > uint64_t rate_buf_phys, int rate_buf_size); > > -extern int pnv_ocxl_get_xsl_irq(struct pci_dev *dev, int *hwirq); > -extern void pnv_ocxl_unmap_xsl_regs(void __iomem *dsisr, void __iomem *dar, > - void __iomem *tfc, void __iomem *pe_handle); > -extern int pnv_ocxl_map_xsl_regs(struct pci_dev *dev, void __iomem **dsisr, > - void __iomem **dar, void __iomem **tfc, > - void __iomem **pe_handle); > +int pnv_ocxl_get_xsl_irq(struct pci_dev *dev, int *hwirq); > +void pnv_ocxl_unmap_xsl_regs(void __iomem *dsisr, void __iomem *dar, > + void __iomem *tfc, void __iomem *pe_handle); > +int pnv_ocxl_map_xsl_regs(struct pci_dev *dev, void __iomem **dsisr, > + void __iomem **dar, void __iomem **tfc, > + void __iomem **pe_handle); > > -extern int pnv_ocxl_spa_setup(struct pci_dev *dev, void *spa_mem, int PE_mask, > - void **platform_data); > -extern void pnv_ocxl_spa_release(void *platform_data); > -extern int pnv_ocxl_spa_remove_pe_from_cache(void *platform_data, int pe_handle); > +int pnv_ocxl_spa_setup(struct pci_dev *dev, void *spa_mem, int PE_mask, void **platform_data); > +void pnv_ocxl_spa_release(void *platform_data); > +int pnv_ocxl_spa_remove_pe_from_cache(void *platform_data, int pe_handle); > > -extern int pnv_ocxl_alloc_xive_irq(u32 *irq, u64 *trigger_addr); > -extern void pnv_ocxl_free_xive_irq(u32 irq); > +int pnv_ocxl_alloc_xive_irq(u32 *irq, u64 *trigger_addr); > +void pnv_ocxl_free_xive_irq(u32 irq); > #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE > u64 pnv_ocxl_platform_lpc_setup(struct pci_dev *pdev, u64 size); > void pnv_ocxl_platform_lpc_release(struct pci_dev *pdev); > diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h > index 06dd5839e438..0a762e387418 100644 > --- a/include/misc/ocxl.h > +++ b/include/misc/ocxl.h > @@ -173,7 +173,7 @@ int ocxl_context_detach(struct ocxl_context *ctx); > * > * Returns 0 on success, negative on failure > */ > -extern int ocxl_afu_irq_alloc(struct ocxl_context *ctx, int *irq_id); > +int ocxl_afu_irq_alloc(struct ocxl_context *ctx, int *irq_id); > > /** > * Frees an IRQ associated with an AFU context > @@ -182,7 +182,7 @@ extern int ocxl_afu_irq_alloc(struct ocxl_context *ctx, int *irq_id); > * > * Returns 0 on success, negative on failure > */ > -extern int ocxl_afu_irq_free(struct ocxl_context *ctx, int irq_id); > +int ocxl_afu_irq_free(struct ocxl_context *ctx, int irq_id); > > /** > * Gets the address of the trigger page for an IRQ > @@ -193,7 +193,7 @@ extern int ocxl_afu_irq_free(struct ocxl_context *ctx, int irq_id); > * > * returns the trigger page address, or 0 if the IRQ is not valid > */ > -extern u64 ocxl_afu_irq_get_addr(struct ocxl_context *ctx, int irq_id); > +u64 ocxl_afu_irq_get_addr(struct ocxl_context *ctx, int irq_id); > > /** > * Provide a callback to be called when an IRQ is triggered >