From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A7E2C433ED for ; Tue, 18 May 2021 09:44:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F62161184 for ; Tue, 18 May 2021 09:44:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F62161184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liwHa-00033P-4x for qemu-devel@archiver.kernel.org; Tue, 18 May 2021 05:44:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liw5x-00012b-8A for qemu-devel@nongnu.org; Tue, 18 May 2021 05:32:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liw5j-0002Ld-4G for qemu-devel@nongnu.org; Tue, 18 May 2021 05:32:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621330360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sFnVgdfg6fg6j1G5EfKILzynZzkVYUtjbjUu4t0lDYU=; b=eXat+vYhqeOicsqva7Zu1BSHdw9qqUA/DIWEmEo25wgzKwSNHkP1USAnRiKQNkZ/ZGIOrB y7Fl/gt0fQaAY9AqjbTNNzobiDFNSin1lDZ0J2YAOhfjXj8MZHqNX6RFeGDbPEpWkaWYfe eb9rVIHNEJYeyLnWplt5E2kAQJV05fw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-115-Wk13QpYTM_yvkX2tRz1B8g-1; Tue, 18 May 2021 05:32:38 -0400 X-MC-Unique: Wk13QpYTM_yvkX2tRz1B8g-1 Received: by mail-wr1-f70.google.com with SMTP id v5-20020adf9e450000b029010e708f05b3so5323617wre.6 for ; Tue, 18 May 2021 02:32:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sFnVgdfg6fg6j1G5EfKILzynZzkVYUtjbjUu4t0lDYU=; b=i2P3l6LJnD+bxpPKEC6JkoCHZ/fc113pcQpkYUT/xzkatf0+kNm1fE4CH+OXe6YApb 8ogKoVj1iyxX+TaenYBpVvUIueR0NUKk4klvr/RHj7VasNvopc5VYIyv1klluIWuNn2S qBVKwWg7jiU5UrIABtjDpsM4usfKYNMQsbV8RCDMgLK9SXkTl78PTKreHgc6uDzsA51D VxNn2cOZPgJPNKDLShXaU9Q30Y9IdR5ISXzliDcOP/uysfVkxzk5Y13UmoxZRm1VEhZB FCytftLBekhu7UWKrxYe372r1QnXyskcLYjRW3Ib/04G6GKvjX2ywyyRpXaq6RUrV9Ur 6YAw== X-Gm-Message-State: AOAM532ghgDJI03wvKmq1+CfACGVdtYqGhE4vgBviHsWA24iFBVNbAjF DN9o9Hg/x4IEIU8clh430OAwRrvav0b6AQ94cXnxWX6UcejknfDADUuSYwOdVjQ4G/CgPkqw75s YalWl1j9TyLpRMWE= X-Received: by 2002:a05:600c:3553:: with SMTP id i19mr4505202wmq.150.1621330357611; Tue, 18 May 2021 02:32:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwG10T8sO4hMw78FY5ANKjN0HjhAkzWfO7BtGe503/f0zhqshCIk5sOgRvUB5bDAiDY3R84LQ== X-Received: by 2002:a05:600c:3553:: with SMTP id i19mr4505186wmq.150.1621330357417; Tue, 18 May 2021 02:32:37 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id g5sm7294421wmi.8.2021.05.18.02.32.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 May 2021 02:32:36 -0700 (PDT) Subject: Re: [PATCH v2 23/50] target/i386: Reduce DisasContext.vex_[lv] to uint8_t To: Richard Henderson , qemu-devel@nongnu.org References: <20210514151342.384376-1-richard.henderson@linaro.org> <20210514151342.384376-24-richard.henderson@linaro.org> From: Paolo Bonzini Message-ID: <4a3155da-ff47-3325-f862-11785e93fa71@redhat.com> Date: Tue, 18 May 2021 11:32:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210514151342.384376-24-richard.henderson@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cfontana@suse.de, f4bug@amsat.org, ehabkost@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 14/05/21 17:13, Richard Henderson wrote: > Currently, vex_l is either {0,1}; if in the future we implement > AVX-512, the max value will be 2. In vex_v we store a register > number. This is 0-15 for SSE, and 0-31 for AVX-512. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- > target/i386/tcg/translate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c > index 61c0573c2f..1367e53e4e 100644 > --- a/target/i386/tcg/translate.c > +++ b/target/i386/tcg/translate.c > @@ -97,8 +97,8 @@ typedef struct DisasContext { > uint8_t rex_b; > bool rex_w; > #endif > - int vex_l; /* vex vector length */ > - int vex_v; /* vex vvvv register, without 1's complement. */ > + uint8_t vex_l; /* vex vector length */ > + uint8_t vex_v; /* vex vvvv register, without 1's complement. */ > CCOp cc_op; /* current CC operation */ > bool cc_op_dirty; > int tf; /* TF cpu flag */ > Reviewed-by: Paolo Bonzini