All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jan Blunck <jblunck@infradead.org>
Cc: dev@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>,
	David Marchand <david.marchand@6wind.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 4/9] virtio: Don't fill dev_info->driver_name
Date: Tue, 20 Dec 2016 12:58:26 +0000	[thread overview]
Message-ID: <4a3631af-85be-f5bc-53fd-eabc4ca51354@intel.com> (raw)
In-Reply-To: <CALe+Z021O=MyCLnPg0RYy6eKH2vTPazKD7i-nDvyGtFsFWJ4Ow@mail.gmail.com>

On 12/20/2016 12:40 PM, Jan Blunck wrote:
> On Tue, Dec 20, 2016 at 1:17 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> On 12/20/2016 11:11 AM, Jan Blunck wrote:
>>> This is overwritten in rte_eth_dev_info_get().
>>>
>>> Signed-off-by: Jan Blunck <jblunck@infradead.org>
>>> Reviewed-by: David Marchand <david.marchand@6wind.com>
>>> ---
>>>  drivers/net/virtio/virtio_ethdev.c | 4 ----
>>>  1 file changed, 4 deletions(-)
>>>
>>> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
>>> index 079fd6c..741688e 100644
>>> --- a/drivers/net/virtio/virtio_ethdev.c
>>> +++ b/drivers/net/virtio/virtio_ethdev.c
>>> @@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>>>       uint64_t tso_mask;
>>>       struct virtio_hw *hw = dev->data->dev_private;
>>>
>>> -     if (dev->pci_dev)
>>> -             dev_info->driver_name = dev->driver->pci_drv.driver.name;
>>> -     else
>>> -             dev_info->driver_name = "virtio_user PMD";
>>>       dev_info->max_rx_queues =
>>>               RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES);
>>>       dev_info->max_tx_queues =
>>>
>>
>>
>> This has been already removed in next-net with following commit:
>> 7c6c1857358c ("net: remove dead driver names")
> 
> Thanks. Do you want me to rebase against next-net and resend the
> series before continuing to review further?
> 

No, I thought this patch can be dropped from patchset, but no, you need
this for decoupling pci_dev.

So, this needs to be resolved in integration time.

I believe this patchset should be against main tree, because of eal and
ethdev patches in it.
And there are already a few patchset around for this area, let's not add
more complexity by adding next-net into the picture.

  reply	other threads:[~2016-12-20 12:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-20 11:11 [PATCH v3 0/9] Decouple ethdev from PCI device Jan Blunck
2016-12-20 11:11 ` [PATCH v3 1/9] eal: define container_of macro Jan Blunck
2016-12-20 11:11 ` [PATCH v3 2/9] ethdev: Helper to convert to struct rte_pci_device Jan Blunck
2016-12-20 15:38   ` Stephen Hemminger
2016-12-20 11:11 ` [PATCH v3 3/9] drivers: Use ETH_DEV_PCI_DEV() helper Jan Blunck
2016-12-21  9:50   ` Shreyansh Jain
2016-12-21  9:57     ` Shreyansh Jain
2016-12-20 11:11 ` [PATCH v3 4/9] virtio: Don't fill dev_info->driver_name Jan Blunck
2016-12-20 12:17   ` Ferruh Yigit
2016-12-20 12:40     ` Jan Blunck
2016-12-20 12:58       ` Ferruh Yigit [this message]
2016-12-20 11:11 ` [PATCH v3 5/9] virtio: Add vtpci_intr_handle() helper to get rte_intr_handle Jan Blunck
2016-12-20 11:11 ` [PATCH v3 6/9] virtio: Don't depend on struct rte_eth_dev's pci_dev Jan Blunck
2016-12-20 11:11 ` [PATCH v3 7/9] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get() Jan Blunck
2016-12-20 15:41   ` Stephen Hemminger
2016-12-21 15:35     ` Jan Blunck
2016-12-21  9:54   ` Shreyansh Jain
2016-12-20 11:11 ` [PATCH v3 8/9] ethdev: Decouple interrupt handling from PCI device Jan Blunck
2016-12-20 11:11 ` [PATCH v3 9/9] ethdev: Decouple struct rte_eth_dev from struct rte_pci_device Jan Blunck
2016-12-21 10:00 ` [PATCH v3 0/9] Decouple ethdev from PCI device Shreyansh Jain
2016-12-21 15:12   ` Jan Blunck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a3631af-85be-f5bc-53fd-eabc4ca51354@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jblunck@infradead.org \
    --cc=shreyansh.jain@nxp.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.