All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Johansen <strit@manjaro.org>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: knaerzche@gmail.com, U-Boot-Denx <u-boot@lists.denx.de>
Subject: Re: [PATCH] include: configs: move USB first in the boot order for rk3399
Date: Mon, 14 Mar 2022 08:58:38 +0100	[thread overview]
Message-ID: <4a3d6c64-1a27-ba67-3d6f-26bc0c9847c8@manjaro.org> (raw)
In-Reply-To: <CAKUh=Rz5P-svtNBaaDBghyf__GhmW_5h1NbZvjA_qBsATjpqkQ@mail.gmail.com>

Okay, no problem.

I was just asked to upstream it, so that was my attempt.

Have a good day.

Den 14.03.2022 kl. 08.57 skrev Kever Yang:
> Hi Dan,
>      Thanks for your patch.
>      Most of the board would like to boot from SD->MMC->NVME, only if
> there no firmware found in the onboard storage, them the U-Boot try
> with USB or network.
>      So I'm afraid this patch can not be applied.
>
> Thanks,
> - Kever
>
> Dan Johansen<strit@manjaro.org>  于2022年1月28日周五 05:56写道:
>> In Manjaro ARM we have used this patch for years now and it was
>> requested that we upstream it.
>>
>> This will make all rk3399 based boards try USB boot before
>> SD or eMMC. Can be quite handy on some devices, where the
>> other devices are not easy to get to.
>>
>> Signed-off-by: Dan Johansen<strit@manjaro.org>
>> ---
>>   include/configs/rockchip-common.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
>> index ba7061a287..5dc92373b2 100644
>> --- a/include/configs/rockchip-common.h
>> +++ b/include/configs/rockchip-common.h
>> @@ -55,9 +55,9 @@
>>
>>   #ifdef CONFIG_ROCKCHIP_RK3399
>>   #define BOOT_TARGET_DEVICES(func) \
>> +       BOOT_TARGET_USB(func) \
>>          BOOT_TARGET_MMC(func) \
>>          BOOT_TARGET_NVME(func) \
>> -       BOOT_TARGET_USB(func) \
>>          BOOT_TARGET_PXE(func) \
>>          BOOT_TARGET_DHCP(func) \
>>          BOOT_TARGET_SF(func)
>> --
>> 2.34.1
>>
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>

      reply	other threads:[~2022-03-14 11:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27  8:39 [PATCH] include: configs: move USB first in the boot order for rk3399 Dan Johansen
2022-03-14  7:57 ` Kever Yang
2022-03-14  7:58   ` Dan Johansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a3d6c64-1a27-ba67-3d6f-26bc0c9847c8@manjaro.org \
    --to=strit@manjaro.org \
    --cc=kever.yang@rock-chips.com \
    --cc=knaerzche@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.