From: Sagi Grimberg <sagi@grimberg.me>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"ngottlieb@nvidia.com" <ngottlieb@nvidia.com>,
"mgurtovoy@nvidia.com" <mgurtovoy@nvidia.com>,
"hch@lst.de" <hch@lst.de>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 1/1] nvmet: do not allow model_number exceed 40 bytes
Date: Mon, 15 Mar 2021 14:50:20 -0700 [thread overview]
Message-ID: <4a4a2b20-af9c-0474-a5b6-734158dafcb7@grimberg.me> (raw)
In-Reply-To: <BYAPR04MB49657B5E84CDE72510A5AB77866C9@BYAPR04MB4965.namprd04.prod.outlook.com>
>> According to the NVM specifications, the model number size should be
>> 40 bytes (bytes 63:24 of the Identify Controller data structure).
>> Therefore, any attempt to store a value into model_number which
>> exceeds 40 bytes should return an error.
>>
>> Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> Signed-off-by: Noam Gottlieb <ngottlieb@nvidia.com>
>
> The patch looks good to me, but is this patch not intended for 5.13 ?
>
> Since for 5.13 we have nvmet_subsys_attr_model_store_locked(), this
> patch uses nvmet_subsys_attr_model_store().
>
> Is this a fix for 5.12-rc ?
I think this patch can wait for 5.13 for sure, maybe needs a Fixes
tag to help it get back to stable...
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-15 21:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 14:56 [PATCH 1/1] nvmet: do not allow model_number exceed 40 bytes ngottlieb
2021-03-15 21:10 ` Chaitanya Kulkarni
2021-03-15 21:50 ` Sagi Grimberg [this message]
2021-03-16 3:40 ` Chaitanya Kulkarni
2021-03-16 8:35 ` Max Gurtovoy
2021-03-16 18:30 ` Sagi Grimberg
2021-03-16 18:32 ` Chaitanya Kulkarni
2021-03-18 5:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a4a2b20-af9c-0474-a5b6-734158dafcb7@grimberg.me \
--to=sagi@grimberg.me \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=ngottlieb@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.