From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [PATCH 8/8] target/arm: Use a non-overlapping group for misc control
Date: Mon, 18 May 2020 18:56:04 +0200 [thread overview]
Message-ID: <4a578b8c-bfcc-59ac-fc0a-af5947e0c114@amsat.org> (raw)
In-Reply-To: <20200518164052.18689-9-richard.henderson@linaro.org>
On 5/18/20 6:40 PM, Richard Henderson wrote:
> This sub-group in the t32 deocode are mutually exclusive.
"The miscellaneous control instructions are mutually exclusive within
the t32 decode sub-group."?
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/t32.decode | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/arm/t32.decode b/target/arm/t32.decode
> index c63082fc9c..c21a988f97 100644
> --- a/target/arm/t32.decode
> +++ b/target/arm/t32.decode
> @@ -312,13 +312,13 @@ CLZ 1111 1010 1011 ---- 1111 .... 1000 .... @rdm
> &cps
>
> # Miscellaneous control
> - {
> + [
> CLREX 1111 0011 1011 1111 1000 1111 0010 1111
> DSB 1111 0011 1011 1111 1000 1111 0100 ----
> DMB 1111 0011 1011 1111 1000 1111 0101 ----
> ISB 1111 0011 1011 1111 1000 1111 0110 ----
> SB 1111 0011 1011 1111 1000 1111 0111 0000
> - }
> + ]
>
> # Note that the v7m insn overlaps both the normal and banked insn.
> {
>
prev parent reply other threads:[~2020-05-18 16:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 16:40 [PATCH 0/8] decodetree: Add non-overlapping groups Richard Henderson
2020-05-18 16:40 ` [PATCH 1/8] decodetree: Remove python 3.4 check Richard Henderson
2020-05-18 16:46 ` Philippe Mathieu-Daudé
2020-05-29 9:35 ` Philippe Mathieu-Daudé
2020-05-18 16:40 ` [PATCH 2/8] decodetree: Tidy error_with_file Richard Henderson
2020-06-02 14:24 ` Peter Maydell
2020-05-18 16:40 ` [PATCH 3/8] decodetree: Rename MultiPattern to IncMultiPattern Richard Henderson
2020-05-18 16:47 ` Philippe Mathieu-Daudé
2020-05-18 16:40 ` [PATCH 4/8] decodetree: Split out MultiPattern from IncMultiPattern Richard Henderson
2020-05-18 16:47 ` Philippe Mathieu-Daudé
2020-05-18 16:40 ` [PATCH 5/8] decodetree: Allow group covering the entire insn space Richard Henderson
2020-06-02 14:35 ` Peter Maydell
2020-06-02 15:15 ` Richard Henderson
2020-06-02 19:11 ` Peter Maydell
2020-05-18 16:40 ` [PATCH 6/8] decodetree: Move semantic propagation into classes Richard Henderson
2020-06-02 19:12 ` Peter Maydell
2020-05-18 16:40 ` [PATCH 7/8] decodetree: Implement non-overlapping groups Richard Henderson
2020-05-18 16:53 ` Philippe Mathieu-Daudé
2020-06-02 19:13 ` Peter Maydell
2020-06-02 19:19 ` Richard Henderson
2020-05-18 16:40 ` [PATCH 8/8] target/arm: Use a non-overlapping group for misc control Richard Henderson
2020-05-18 16:56 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a578b8c-bfcc-59ac-fc0a-af5947e0c114@amsat.org \
--to=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.