From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 735E8C433FE for ; Wed, 22 Sep 2021 18:15:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 529B36120F for ; Wed, 22 Sep 2021 18:15:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237019AbhIVSQm (ORCPT ); Wed, 22 Sep 2021 14:16:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236988AbhIVSQk (ORCPT ); Wed, 22 Sep 2021 14:16:40 -0400 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A32F2C061757 for ; Wed, 22 Sep 2021 11:15:10 -0700 (PDT) Received: by mail-io1-xd2d.google.com with SMTP id s20so4646455ioa.4 for ; Wed, 22 Sep 2021 11:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZQV4XJx/DFSXSOOyfOEMFYhipz4Fl6dlEeGzliw9JTY=; b=bvxZ6G1NA+MLuCa5cGubm24q50H3hoy0Bog3f5krwJUlAuv9vo2dthuljO8qqFfBV5 ghKmtYxnqBFZiZPrqZl6ejmknepVPS99/2BLn/IEQJD3BXTsy/TtRAUNUDwysKTFMHwu d7BeHvj0WRfPQ0RsHMF/DF05SdFJ/9EyGoy/4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZQV4XJx/DFSXSOOyfOEMFYhipz4Fl6dlEeGzliw9JTY=; b=uokNwZhNJLXDQ+4DMLpBSYZsmdWiayHHt2jtQRtZuhJnOkutAq9zmGTORDgdG5LSGd HL8Ky7hViaaT1/a/qMR+ELH8YFEXbFp24ScAKKVXaJe6XShVzC+FdT+cVJIHO0KXJ1as i/K7w5PEd+dDW02XqhvC68NfYnxdwneuZH30ZEwTzr6wCTnzLHWm1Chd4Hx3IsPvXwL6 b17QI8BFlSG5CJAOx9a+ESq1adueSOWBX8EV/JcqqgZO+pn1d1TvaJWWxXPhjKaQlGDT d/lEFhSITeqcTmXx/yw773cSMTENzL0C92Tn+h5U2jqHNI8VotVrdICy8fwqcft6LMrl x+9g== X-Gm-Message-State: AOAM53037FUqsKkR8VjpP8RLBIipaRSjc22EFyJWJLbgQuFs82c9Z16m RT2LbrYQhLaXZ2RZcCZmmxn4sDDsmZbuVg== X-Google-Smtp-Source: ABdhPJzpGFKPcvQ1dQiq6NQIIOHRYCS0MNJZnb/XlexqCV8ZWYYGunxpKKLw9XZAalIae/yWYmYlbw== X-Received: by 2002:a5d:8d06:: with SMTP id p6mr295578ioj.7.1632334509796; Wed, 22 Sep 2021 11:15:09 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id b3sm1369122ile.37.2021.09.22.11.15.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 11:15:09 -0700 (PDT) Subject: Re: INFO: task hung in hub_port_init To: Alan Stern , Hao Sun , Shuah Khan Cc: Greg KH , linux-usb@vger.kernel.org, a.darwish@linutronix.de, johan@kernel.org, Linux Kernel Mailing List , oneukum@suse.com, Shuah Khan References: <20210913135459.GA120302@rowland.harvard.edu> <20210918020245.GA69263@rowland.harvard.edu> <20210918135301.GA79656@rowland.harvard.edu> <2d776f5b-c6b5-1c05-de37-493fc10a97af@linuxfoundation.org> From: Shuah Khan Message-ID: <4a59e9e7-4501-4328-f985-0a82593af282@linuxfoundation.org> Date: Wed, 22 Sep 2021 12:15:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <2d776f5b-c6b5-1c05-de37-493fc10a97af@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hao Sun, On 9/20/21 8:31 AM, Shuah Khan wrote: > On 9/18/21 7:53 AM, Alan Stern wrote: >> On Sat, Sep 18, 2021 at 10:17:26AM +0800, Hao Sun wrote: >>> Alan Stern 于2021年9月18日周六 上午10:02写道： >>>> >>>> On Sat, Sep 18, 2021 at 09:56:52AM +0800, Hao Sun wrote: >>>>> Hi Alan, >>>>> >>>>> Alan Stern 于2021年9月13日周一 下午9:55写道： >>>>>> >>>>>> On Mon, Sep 13, 2021 at 11:13:15AM +0800, Hao Sun wrote: >>>>>>> Hello, >>>>>>> >>>>>>> When using Healer to fuzz the Linux kernel, the following crash was triggered. >>>>>>> >>>>>>> HEAD commit: ac08b1c68d1b Merge tag 'pci-v5.15-changes' >>>>>>> git tree: upstream >>>>>>> console output: >>>>>>> https://drive.google.com/file/d/1ZeDIMe-DoY3fB32j2p5ifgpq-Lc5N74I/view?usp=sharing >>>>>>> kernel config: https://drive.google.com/file/d/1qrJUXD8ZIeAkg-xojzDpp04v9MtQ8RR6/view?usp=sharing >>>>>>> Syzlang reproducer: >>>>>>> https://drive.google.com/file/d/1tZe8VmXfxoPqlNpzpGOd-e5WCSWgbkxB/view?usp=sharing >>>>>>> Similar report: >>>>>>> https://groups.google.com/g/syzkaller-bugs/c/zX55CUzjBOY/m/uf91r0XqAgAJ >>>>>>> >>>>>>> Sorry, I don't have a C reproducer for this crash but have a Syzlang >>>>>>> reproducer. Also, hope the symbolized report can help. >>>>>>> Here are the instructions on how to execute Syzlang prog: >>>>>>> https://github.com/google/syzkaller/blob/master/docs/executing_syzkaller_programs.md >>>>>>> >>>>>>> If you fix this issue, please add the following tag to the commit: >>>>>>> Reported-by: Hao Sun >>>>>> >>>>>> There's not much hope of finding the cause of a problem like this >>>>>> without seeing the kernel log. >>>>>> >>>>> >>>>> Healer found another Syzlang prog to reproduce this task hang: >>>>> https://paste.ubuntu.com/p/HCNYbKJYtx/ >>>>> >>>>> Also here is a very simple script to execute the reproducer: >>>>> https://paste.ubuntu.com/p/ZTGmvFSP6d/ >>>>> >>>>> The `syz-execprog` and `syz-executor` are needed, so please build >>>>> Syzkaller first before running the script. >>>>> Hope this can help to find the root cause of the problem. >>>> >>>> I don't have time to install and figure out how to use Healer and >>>> Syzkaller.  But if you run the reproducer and post the kernel log, >>>> I'll take a look at it. >>>> >>> >>> Just executed the reproducer, here is the full log: >>> https://paste.ubuntu.com/p/x43SqQy8PX/ >> >> The log indicates that the problem is related to the vhci-hcd driver >> somehow.  I don't know why those "Module has invalid ELF structures" >> errors keep appearing, starting in line 1946 of the log. >> Can you send me your config? This message is rather odd. [ 82.249631][ T6679] Module has invalid ELF structures It is right below: [ 82.248529][ T6679] vhci_hcd vhci_hcd.0: Device attached or [ 83.860819][ T6710] vhci_hcd vhci_hcd.0: port 0 already used My guess is this isn't the vhci_hcd module that gets loaded at this point when we see this message, but another module that gets loaded when vhci_hcd initiates probe after device attach. Note that vhci_hcd is loaded earlier. It is possible, the hung task might be related to load_module() failure. Unfortunately load_module() doesn't print elf_validity_check() error. Would you be able to add this patch and run the reproducer again? -------------------------------------------------------------------- diff --git a/kernel/module.c b/kernel/module.c index 40ec9a030eec..02f758b04f05 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -3941,7 +3941,8 @@ static int load_module(struct load_info *info, const char __user *uargs, */ err = elf_validity_check(info); if (err) { - pr_err("Module has invalid ELF structures\n"); + pr_err("Module has invalid ELF structures error (%ld)\n", + err); goto free_copy; } -------------------------------------------------------------------- thanks, -- Shuah