From: Julien Grall <julien@xen.org>
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
bertrand.marquis@arm.com
Subject: Re: [PATCH v2] xen/arm64: Remove vreg_emulate_sysreg32
Date: Thu, 29 Jul 2021 12:20:01 +0100 [thread overview]
Message-ID: <4a5ac822-3078-de0e-8f84-6881d47ad3eb@xen.org> (raw)
In-Reply-To: <20210729104258.6320-1-michal.orzel@arm.com>
Hi Michal,
On 29/07/2021 11:42, Michal Orzel wrote:
> According to ARMv8A architecture, AArch64 registers
> are 64bit wide even though in many cases the upper
> 32bit is reserved. Therefore there is no need for
> function vreg_emulate_sysreg32 on arm64. This means
> that we can have just one function vreg_emulate_sysreg
> using new function pointer:
> typedef bool (*vreg_reg_fn_t)(struct cpu_user_regs *regs,
> register_t *r, bool read);
>
> Modify vreg_emulate_cp32 to use the new function pointer
> as well.
>
> This change allows to properly use 64bit registers in AArch64
> state and in case of AArch32 the upper 32 bits of AArch64
> registers are inaccessible and are ignored(D1.20.1 ARM DDI 0487A.j).
What you wrote only says that the bits are ignored. It doesn't say
whether the bits will be 0.
They are probably, but as I wrote yesterday, I couldn't confirm it.
>
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Please provide a change log.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2021-07-29 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 10:42 [PATCH v2] xen/arm64: Remove vreg_emulate_sysreg32 Michal Orzel
2021-07-29 11:20 ` Julien Grall [this message]
2021-07-29 11:47 ` Michal Orzel
2021-08-06 11:12 ` Julien Grall
2021-09-01 9:38 ` Michal Orzel
2021-09-02 12:50 ` Julien Grall
2021-09-03 9:16 ` Michal Orzel
2021-09-06 8:52 ` Julien Grall
2021-09-06 9:07 ` Julien Grall
2021-09-06 9:09 ` Michal Orzel
2021-09-06 17:48 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a5ac822-3078-de0e-8f84-6881d47ad3eb@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=michal.orzel@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.