From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE42C433EF for ; Wed, 1 Jun 2022 19:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbiFATnj (ORCPT ); Wed, 1 Jun 2022 15:43:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbiFATni (ORCPT ); Wed, 1 Jun 2022 15:43:38 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E17341E2243 for ; Wed, 1 Jun 2022 12:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1654112515; x=1685648515; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=EnpJATC61A1PapJaFkGkKHryWmutU5vYtbP0p2Sgvxo=; b=eyneKueBJXk0aPi2/gYGgcwyEfr7Fv1ONqFUDIz0fcxZgIABI0qcD4VY VWTEIJj0QrjwgAe0/sbjCQ+kuWY8jR9ronA3PhUPdL4y/wZfoXB4kaSNF MnvA1rvbiNkXVYzQtqwz08P6bPUQ96k+MEWklSJIWSHZl4pUBNhF9V21s I=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-02.qualcomm.com with ESMTP; 01 Jun 2022 12:31:15 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2022 12:31:14 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 1 Jun 2022 12:31:14 -0700 Received: from [10.110.9.238] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 1 Jun 2022 12:31:13 -0700 Message-ID: <4a74852a-0a19-7fe5-95e6-09317bfe0eb3@quicinc.com> Date: Wed, 1 Jun 2022 12:31:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 01/15] mac80211: split bss_info_changed method Content-Language: en-US To: Johannes Berg , CC: Johannes Berg References: <20220601073958.8345-1-johannes@sipsolutions.net> <20220601093922.347d47c279fe.I15937cfe8405999084f164ddf57390f8b8d2bc61@changeid> From: Jeff Johnson In-Reply-To: <20220601093922.347d47c279fe.I15937cfe8405999084f164ddf57390f8b8d2bc61@changeid> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 6/1/2022 12:39 AM, Johannes Berg wrote: > From: Johannes Berg > > Split the bss_info_changed method to vif_cfg_changed and > link_info_changed, with the latter getting a link ID. > Also change the 'changed' parameter to u64 already, we > know we need that. [snip] > - wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss info changed vif %p changed 0x%08x\n", > - vif, changed); > + wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss info changed vif %p changed 0x%llx\n", > + vif, (unsigned long long)changed); just curious about the typecasting. https://www.kernel.org/doc/html/latest/core-api/printk-formats.html indicates we should always be able to use %lld or %llx for u64 hence no typecasting should be needed