From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72160C43334 for ; Wed, 1 Jun 2022 16:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356053AbiFAQUZ (ORCPT ); Wed, 1 Jun 2022 12:20:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353912AbiFAQUX (ORCPT ); Wed, 1 Jun 2022 12:20:23 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAE7879387 for ; Wed, 1 Jun 2022 09:20:21 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id v15so2324225pgk.11 for ; Wed, 01 Jun 2022 09:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to; bh=wOuHAe/UCPXCVWmhImfI3HLWugnRgMhk0OKlk9MR+eA=; b=hwLoC+ZH4qO69CJeUjyyFZYaEZNIWjiWJvwQaOkl5pwDV7tTutLzu2aeYcde16dbPS Vfhyewc0BZMyOli1NTsiF9W4tMIUgAkF8w/4ZpWb6/yrvXzwsc4JsCyi0nPL9duLRRWx 4BNsITI8xcW5+cSRtP1kHP3E9KJXg5dR8VQGA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to; bh=wOuHAe/UCPXCVWmhImfI3HLWugnRgMhk0OKlk9MR+eA=; b=olqJCxeAZoDSyufpYauXSVTHvoMiLa/O1VfJDsyCNK2R08uXu7HIVKqd5PYU5xA+sF cSbJNhpCEg+fXqLsKN7ES2LLzeoU+mVLAP7skwqeSIcIwWIryvc+MclWmF2aTPR650TI BQgX7fBXmzoHMkifvegkRuOjd8iMlfod6TVMLmKNOMXB/NzWp2g7GVg9qQB7A7iJF7Ux lrJarH7mu9sCTzS3rqI2tnPYVZ+0ujCy7bhPMlLugv3nrfZ14xaif2Dg7RWiYWSp9xtv z0mtKUdQoAaeaMXt/AO9VNSzYbbkrlwNNWvmmICigDFSmNx4kIELMlfrZVQMQAdB5wsE L9rg== X-Gm-Message-State: AOAM5337ni2qJy04A6NaQHHW3miW/Zwguq3ts9eZL4zzs8cIF6sNhGKC LjVAC/UXIYkirnalo4wHpt2UPw== X-Google-Smtp-Source: ABdhPJzbmQCXVR+bl5y97gY4EEvUQGzrAzCL2ePNSA1f0s/iJYCNhKMqmgigXiyBqjxHyCX5vCjiig== X-Received: by 2002:a05:6a00:1503:b0:518:c689:518d with SMTP id q3-20020a056a00150300b00518c689518dmr412470pfu.37.1654100421072; Wed, 01 Jun 2022 09:20:21 -0700 (PDT) Received: from [10.67.99.21] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id dw15-20020a17090b094f00b001e0b971196csm4064003pjb.57.2022.06.01.09.20.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 09:20:19 -0700 (PDT) Message-ID: <4a78703b-7c58-913c-3c36-1fec4455b946@broadcom.com> Date: Wed, 1 Jun 2022 09:20:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 2/3] arm64: dts: add dts files for bcmbca SoC bcm4912 To: Florian Fainelli , Linux ARM List Cc: dan.beygelman@broadcom.com, philippe.reynes@softathome.com, anand.gore@broadcom.com, tomer.yacoby@broadcom.com, samyon.furman@broadcom.com, kursad.oney@broadcom.com, joel.peshkin@broadcom.com, Broadcom internal kernel review list , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220601004244.27394-1-william.zhang@broadcom.com> <20220601004244.27394-3-william.zhang@broadcom.com> <0b4abf17-f44d-dec4-56f4-0ae12e49b05b@gmail.com> From: William Zhang In-Reply-To: <0b4abf17-f44d-dec4-56f4-0ae12e49b05b@gmail.com> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000000b088905e06544a9" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0000000000000b088905e06544a9 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/1/22 02:47, Florian Fainelli wrote: > > > On 5/31/2022 5:42 PM, William Zhang wrote: >> Add dts for ARMv8 based broadband SoC BCM4912. bcm4912.dtsi is the >> SoC description dts header and bcm94912.dts is a simple dts file for >> Broadcom BCM94912 Reference board that only enable the UART port. >> >> Signed-off-by: William Zhang >> >> --- > > [snip] > >> + >> +    axi@81000000 { >> +        compatible = "simple-bus"; >> +        #address-cells = <2>; >> +        #size-cells = <2>; > > See comment below for the ubus node. > >> +        ranges = <0x0 0x0 0x0 0x81000000 0x0 0x8000>; >> + >> +        gic: interrupt-controller@1000 { >> +            compatible = "arm,gic-400"; >> +            #interrupt-cells = <3>; >> +            interrupt-controller; >> +            interrupts = > IRQ_TYPE_LEVEL_HIGH)>; >> +            reg = <0x0 0x1000 0x0 0x1000>, >> +                <0x0 0x2000 0x0 0x2000>, >> +                <0x0 0x4000 0x0 0x2000>, >> +                <0x0 0x6000 0x0 0x2000>; >> +        }; >> +    }; >> + >> +    bus@ff800000 { >> +        compatible = "simple-bus"; >> +        #address-cells = <2>; >> +        #size-cells = <2>; > > This does not quite make sense, as I doubt that this part of the bus is > 64-bit capable, rather, I would expect to find both #address-cells and > #size-cells to be set to 1 and ... (see below) > Agree. It can be simplified to use 32 bit address and size. >> +        ranges = <0x0 0x0 0x0 0xff800000 0x0 0x800000>; >> + >> +        uart0: serial@12000 { >> +            compatible = "arm,pl011", "arm,primecell"; >> +            reg = <0x0 0x12000 0x0 0x1000>; > > ... have this become simply: > >             reg = <0x12000 0x1000>: > > which also looks awfully big for an UART block, an entire 4KB worth of > register space? That is the correct based on the rdb. --0000000000000b088905e06544a9 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQcAYJKoZIhvcNAQcCoIIQYTCCEF0CAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3HMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBU8wggQ3oAMCAQICDDbx5fpN++xs1+5IgzANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIwODA1MjJaFw0yMjA5MDUwODEwMTZaMIGQ MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFjAUBgNVBAMTDVdpbGxpYW0gWmhhbmcxKTAnBgkqhkiG9w0B CQEWGndpbGxpYW0uemhhbmdAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB CgKCAQEA4fxIZbzNLvB+7yJE8mbojRaOoaK1uZy1/etc55NzisSJJfY36BAlb7LlMDsza2/BcjXh lSACuzeOyI8sy2pKHGt5SZCMHeHaxP8q4ZNR6EGz7+5Lopw6ies8fkDoZ/XFIHpfU2eKcIYrxI25 bTaYAPDA50BHTPDFzPNkWEIIQaSBBkk55bndnMmB/pPR/IhKjLefDIhIsiWLrvQstTiSf7iUCwMf TltlrAeBKRJ1M9O/DY5v7L1Yrs//7XIRg/d2ZPAOSGBQzFYjYTFWwNBiR1s1zP0m2y56DPbS5gwj fqAN/I4PJHIvTh3zUgHXNKadYoYRiPHXfaTWO9UhzysOpQIDAQABo4IB2zCCAdcwDgYDVR0PAQH/ BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3VyZS5nbG9i YWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEGCCsGAQUF BzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAy MDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93d3cuZ2xv YmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6hjhodHRw Oi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNybDAlBgNV HREEHjAcgRp3aWxsaWFtLnpoYW5nQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAf BgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUohM5GmNlGWe5wpzDxzIy +EgzbRswDQYJKoZIhvcNAQELBQADggEBACKu9JSQAYTlmC+JTniO/C/UcXGonATI/muBjWTxtkHc abZtz0uwzzrRrpV+mbHLGVFFeRbXSLvcEzqHp8VomXifEZlfsE9LajSehzaqhd+np+tmUPz1RlI/ ibZ7vW+1VF18lfoL+wHs2H0fsG6JfoqZldEWYXASXnUrs0iTLgXxvwaQj69cSMuzfFm1X5kWqWCP W0KkR8025J0L5L4yXfkSO6psD/k4VcTsMJHLN4RfMuaXIT6EM0cNO6h3GypyTuPf1N1X+F6WQPKb 1u+rvdML63P9fX7e7mwwGt5klRnf8aK2VU7mIdYCcrFHaKDTW3fkG6kIgrE1wWSgiZYL400xggJt MIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYD VQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgw28eX6TfvsbNfu SIMwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIKcs12Q4kxd6ebatGcxwxvzQSed/ fOUwyRihn949dpUWMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIy MDYwMTE2MjAyMVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsG CWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFl AwQCATANBgkqhkiG9w0BAQEFAASCAQBR7BZUApgJEILqS8Ba/cr+vzbWldwkx2Rd6RbXy4QV7AZ1 yM/C54zlpRptMEhFrPd0scTL98tmITB1PplroBtz7O2l6awlKSNtTCxj2CGI/33pjlZzpw1uyHBL GC/5RQWZfsRBb3OW2lV9X6nwjncnrZntkphlhw0jvrTkVOnGlbTZK9PGQkjMKVUcyB+DB82IsbFb +Fr0cXUvAt0PtvPFCKVOrFZumja0v2ln908JRNRQ5fyzA7LppQm9/t1gImI7Nr1ibjaXlObUfqPb i1R7sIHkZBTKnqIvcasuKK3rp2yjkuX2Ox2JLlRyIsYBFBE3SDQ2JL+INU+NASssUfAp --0000000000000b088905e06544a9-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86AC7CCA477 for ; Wed, 1 Jun 2022 16:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=STbs8doCxg+D6ho8u86orIoe4dl+zLe9Gdnc2/RPzAw=; b=ezIZTtwWxY4/o3QhfQxqaLu5oU pOku8LC7DKjpJZ3u8mXHwij+0j4TGDOy8JTANwqCQ7kjJbkLeu9FWScCUD5eSHSbvFDOCWhh16r69 QWjmGhLvmfBwT8WYZ+gXQeZ3gVqoPFC6vI3NTYnLYem3QfqmbrHXkQIq6RSeqijjcURK2k15c1/Wy m0OtusBbxe9e6LVtN6oJx9fGzcwGobDPdSAHjPN5VYDZMFQe1gDSj+HCJmlACR/W6aKU8bABR3HFQ RT2u1igM37E0l+V9akU1FPbe0PvlM6EG+tlXMI9zTucDE9ucRzogF5hodDVdENAOiKFmJCj9jFkXC URJFtVbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwR59-00H4BT-Ky; Wed, 01 Jun 2022 16:20:27 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwR56-00H4AN-1d for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 16:20:25 +0000 Received: by mail-pg1-x52c.google.com with SMTP id s68so2334516pgs.10 for ; Wed, 01 Jun 2022 09:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to; bh=eosD2PI5Xrr596l7lmIJv6C2CVfAuOUBLj7fB6pjd78=; b=h7Aism25fMUZMYJfTdkrkFt2+3zAAc8nRgsmQyR7DIWcAEvd9F1GamkDHyf6mlvQSG 0fCpOCkkZP6A88Ye2LaiNGDIBBENKIkeOUQjlyTnrajY6UX4gM/CneBzFsFgml4EPpws IsepyQtLis3Vwe8QnpMDwKpwMIXokEYICuqcY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to; bh=eosD2PI5Xrr596l7lmIJv6C2CVfAuOUBLj7fB6pjd78=; b=alVfp3TysZgemC76jW+bCpeWPXNfa5naK4jGC0Fbt2KDbGF4QaE4QGH42HAjn5nAc4 28HfVRIBQlQ2asx7M0BcKkFiMI4a/qWVEuYekxwUioh/LLZxGNLBm2EtLWmy4aervAeB vXoliv1JFVpFOTi3gH7Gd3r2tDMdWGbBvhTnW9TknTTEWt5mOlt8M70VaLuMVBuObaxb a4DveUembE65HZ96EJsvbJysS1TQkYBMDAol+mHFlPiMuNVQY5KqGCzrDnxMEFN0l98l D91MEjWrUF73EX+IPbAVxhW6bfRMY4whLz3KKR3WXVrfh3EFUb4mhoh6/PO2ywqV15MC Um7w== X-Gm-Message-State: AOAM5311D+T49cMyXe4p3L611Bvlpo0M7oP8NsdvFSkHCUVNQMbm64uP ueGmTp41KRQWdrAim2vwDJC3OQ== X-Google-Smtp-Source: ABdhPJzbmQCXVR+bl5y97gY4EEvUQGzrAzCL2ePNSA1f0s/iJYCNhKMqmgigXiyBqjxHyCX5vCjiig== X-Received: by 2002:a05:6a00:1503:b0:518:c689:518d with SMTP id q3-20020a056a00150300b00518c689518dmr412470pfu.37.1654100421072; Wed, 01 Jun 2022 09:20:21 -0700 (PDT) Received: from [10.67.99.21] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id dw15-20020a17090b094f00b001e0b971196csm4064003pjb.57.2022.06.01.09.20.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 09:20:19 -0700 (PDT) Message-ID: <4a78703b-7c58-913c-3c36-1fec4455b946@broadcom.com> Date: Wed, 1 Jun 2022 09:20:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 2/3] arm64: dts: add dts files for bcmbca SoC bcm4912 To: Florian Fainelli , Linux ARM List Cc: dan.beygelman@broadcom.com, philippe.reynes@softathome.com, anand.gore@broadcom.com, tomer.yacoby@broadcom.com, samyon.furman@broadcom.com, kursad.oney@broadcom.com, joel.peshkin@broadcom.com, Broadcom internal kernel review list , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220601004244.27394-1-william.zhang@broadcom.com> <20220601004244.27394-3-william.zhang@broadcom.com> <0b4abf17-f44d-dec4-56f4-0ae12e49b05b@gmail.com> From: William Zhang In-Reply-To: <0b4abf17-f44d-dec4-56f4-0ae12e49b05b@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_092024_200183_5790380E X-CRM114-Status: GOOD ( 21.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0868696092591248788==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0868696092591248788== Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000000aef4a05e065447c" --0000000000000aef4a05e065447c Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/1/22 02:47, Florian Fainelli wrote: > > > On 5/31/2022 5:42 PM, William Zhang wrote: >> Add dts for ARMv8 based broadband SoC BCM4912. bcm4912.dtsi is the >> SoC description dts header and bcm94912.dts is a simple dts file for >> Broadcom BCM94912 Reference board that only enable the UART port. >> >> Signed-off-by: William Zhang >> >> --- > > [snip] > >> + >> +    axi@81000000 { >> +        compatible = "simple-bus"; >> +        #address-cells = <2>; >> +        #size-cells = <2>; > > See comment below for the ubus node. > >> +        ranges = <0x0 0x0 0x0 0x81000000 0x0 0x8000>; >> + >> +        gic: interrupt-controller@1000 { >> +            compatible = "arm,gic-400"; >> +            #interrupt-cells = <3>; >> +            interrupt-controller; >> +            interrupts = > IRQ_TYPE_LEVEL_HIGH)>; >> +            reg = <0x0 0x1000 0x0 0x1000>, >> +                <0x0 0x2000 0x0 0x2000>, >> +                <0x0 0x4000 0x0 0x2000>, >> +                <0x0 0x6000 0x0 0x2000>; >> +        }; >> +    }; >> + >> +    bus@ff800000 { >> +        compatible = "simple-bus"; >> +        #address-cells = <2>; >> +        #size-cells = <2>; > > This does not quite make sense, as I doubt that this part of the bus is > 64-bit capable, rather, I would expect to find both #address-cells and > #size-cells to be set to 1 and ... (see below) > Agree. It can be simplified to use 32 bit address and size. >> +        ranges = <0x0 0x0 0x0 0xff800000 0x0 0x800000>; >> + >> +        uart0: serial@12000 { >> +            compatible = "arm,pl011", "arm,primecell"; >> +            reg = <0x0 0x12000 0x0 0x1000>; > > ... have this become simply: > >             reg = <0x12000 0x1000>: > > which also looks awfully big for an UART block, an entire 4KB worth of > register space? That is the correct based on the rdb. --0000000000000aef4a05e065447c Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQcAYJKoZIhvcNAQcCoIIQYTCCEF0CAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3HMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBU8wggQ3oAMCAQICDDbx5fpN++xs1+5IgzANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIwODA1MjJaFw0yMjA5MDUwODEwMTZaMIGQ MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFjAUBgNVBAMTDVdpbGxpYW0gWmhhbmcxKTAnBgkqhkiG9w0B CQEWGndpbGxpYW0uemhhbmdAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB CgKCAQEA4fxIZbzNLvB+7yJE8mbojRaOoaK1uZy1/etc55NzisSJJfY36BAlb7LlMDsza2/BcjXh lSACuzeOyI8sy2pKHGt5SZCMHeHaxP8q4ZNR6EGz7+5Lopw6ies8fkDoZ/XFIHpfU2eKcIYrxI25 bTaYAPDA50BHTPDFzPNkWEIIQaSBBkk55bndnMmB/pPR/IhKjLefDIhIsiWLrvQstTiSf7iUCwMf TltlrAeBKRJ1M9O/DY5v7L1Yrs//7XIRg/d2ZPAOSGBQzFYjYTFWwNBiR1s1zP0m2y56DPbS5gwj fqAN/I4PJHIvTh3zUgHXNKadYoYRiPHXfaTWO9UhzysOpQIDAQABo4IB2zCCAdcwDgYDVR0PAQH/ BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3VyZS5nbG9i YWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEGCCsGAQUF BzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAy MDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93d3cuZ2xv YmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6hjhodHRw Oi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNybDAlBgNV HREEHjAcgRp3aWxsaWFtLnpoYW5nQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAf BgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUohM5GmNlGWe5wpzDxzIy +EgzbRswDQYJKoZIhvcNAQELBQADggEBACKu9JSQAYTlmC+JTniO/C/UcXGonATI/muBjWTxtkHc abZtz0uwzzrRrpV+mbHLGVFFeRbXSLvcEzqHp8VomXifEZlfsE9LajSehzaqhd+np+tmUPz1RlI/ ibZ7vW+1VF18lfoL+wHs2H0fsG6JfoqZldEWYXASXnUrs0iTLgXxvwaQj69cSMuzfFm1X5kWqWCP W0KkR8025J0L5L4yXfkSO6psD/k4VcTsMJHLN4RfMuaXIT6EM0cNO6h3GypyTuPf1N1X+F6WQPKb 1u+rvdML63P9fX7e7mwwGt5klRnf8aK2VU7mIdYCcrFHaKDTW3fkG6kIgrE1wWSgiZYL400xggJt MIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYD VQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgw28eX6TfvsbNfu SIMwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIKcs12Q4kxd6ebatGcxwxvzQSed/ fOUwyRihn949dpUWMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIy MDYwMTE2MjAyMVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsG CWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFl AwQCATANBgkqhkiG9w0BAQEFAASCAQBR7BZUApgJEILqS8Ba/cr+vzbWldwkx2Rd6RbXy4QV7AZ1 yM/C54zlpRptMEhFrPd0scTL98tmITB1PplroBtz7O2l6awlKSNtTCxj2CGI/33pjlZzpw1uyHBL GC/5RQWZfsRBb3OW2lV9X6nwjncnrZntkphlhw0jvrTkVOnGlbTZK9PGQkjMKVUcyB+DB82IsbFb +Fr0cXUvAt0PtvPFCKVOrFZumja0v2ln908JRNRQ5fyzA7LppQm9/t1gImI7Nr1ibjaXlObUfqPb i1R7sIHkZBTKnqIvcasuKK3rp2yjkuX2Ox2JLlRyIsYBFBE3SDQ2JL+INU+NASssUfAp --0000000000000aef4a05e065447c-- --===============0868696092591248788== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0868696092591248788==--