From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F023AC433DB for ; Wed, 6 Jan 2021 01:39:47 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31ABB22D04 for ; Wed, 6 Jan 2021 01:39:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31ABB22D04 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chinatelecom.cn Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-4N-10cOgNKu7Vqb1_gqe8A-1; Tue, 05 Jan 2021 20:39:41 -0500 X-MC-Unique: 4N-10cOgNKu7Vqb1_gqe8A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4472B1800D41; Wed, 6 Jan 2021 01:39:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A7CC7100AE2D; Wed, 6 Jan 2021 01:39:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4FC9C4A7C6; Wed, 6 Jan 2021 01:39:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1061dQGF019413 for ; Tue, 5 Jan 2021 20:39:28 -0500 Received: by smtp.corp.redhat.com (Postfix) id 08F4D2166B2B; Wed, 6 Jan 2021 01:39:26 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0360A2166B2A for ; Wed, 6 Jan 2021 01:39:21 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF231858281 for ; Wed, 6 Jan 2021 01:39:20 +0000 (UTC) Received: from chinatelecom.cn (prt-mail.chinatelecom.cn [42.123.76.227]) by relay.mimecast.com with ESMTP id us-mta-133-VmNab9akPWOIyXX8ZV7Lxw-1; Tue, 05 Jan 2021 20:39:18 -0500 X-MC-Unique: VmNab9akPWOIyXX8ZV7Lxw-1 HMM_SOURCE_IP: 172.18.0.92:39498.940160285 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-202.80.192.21?logid-3deb66b94880473280264ba746cc7a1c (unknown [172.18.0.92]) by chinatelecom.cn (HERMES) with SMTP id BEF332800C0; Wed, 6 Jan 2021 09:39:14 +0800 (CST) X-189-SAVE-TO-SEND: wucy11@chinatelecom.cn Received: from ([172.18.0.92]) by App0021 with ESMTP id 3deb66b94880473280264ba746cc7a1c for zhangzijian@chinatelecom.cn; Wed Jan 6 09:39:15 2021 X-Transaction-ID: 3deb66b94880473280264ba746cc7a1c X-filter-score: filter<0> X-Real-From: wucy11@chinatelecom.cn X-Receive-IP: 172.18.0.92 X-MEDUSA-Status: 0 From: Chongyun Wu To: "mwilck@suse.com" , "bmarzins@redhat.com" , "dm-devel@redhat.com" Message-ID: <4a94424e-5fae-0f7f-b9be-56ccb5f1a0df@chinatelecom.cn> Date: Wed, 6 Jan 2021 09:39:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: dm-devel@redhat.com Cc: yubin1@chinatelecom.cn, zhangzijian@chinatelecom.cn Subject: [dm-devel] [PATCH v3 resend] multipathd: fix path checkint not changed when path state changed from delay to failed X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Thank you, Ben and Martin, this is the resend version in text format. From 45dad5fa6a9fb42648c8f5f54d6db974974d9612 Mon Sep 17 00:00:00 2001 From: Chongyun Wu Date: Wed, 16 Dec 2020 13:59:16 +0800 Subject: [PATCH] multipathd: fix path checkint not changed when path state changed from delay to failed Check_path: when path state change back to failed from delay state, should change this path's check interval time to the shortest delay to faster path state check. Reviewed-by: Benjamin Marzinski Signed-off-by: Chongyun Wu --- multipathd/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/multipathd/main.c b/multipathd/main.c index a4abbb27..9fd34e97 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -2166,6 +2166,11 @@ check_path (struct vectors * vecs, struct path * pp, unsigned int ticks) (pp->state == PATH_DELAYED)) { /* If path state become failed again cancel path delay state */ pp->state = newstate; + /* + * path state bad again should change the check interval time + * to the shortest delay + */ + pp->checkint = checkint; return 1; } if (!pp->mpp) { -- 2.29.2.windows.3 -- Best Regard, Chongyun Wu -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel