All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Andrii Anisov' <andrii.anisov@gmail.com>,
	'Julien Grall' <julien.grall@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Andrii Anisov <andrii_anisov@epam.com>
Subject: Re: [RFC] arm/p2m: call iommu iotlb flush if iommu exists and enabled
Date: Wed, 23 Jan 2019 12:41:27 +0000	[thread overview]
Message-ID: <4a9586dac80748f0a8b0f575792cbbb8@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5ff8a4ec-dc2f-488e-d462-794e72a942bc@gmail.com>

> -----Original Message-----
> From: Andrii Anisov [mailto:andrii.anisov@gmail.com]
> Sent: 23 January 2019 12:40
> To: Paul Durrant <Paul.Durrant@citrix.com>; 'Julien Grall'
> <julien.grall@arm.com>; xen-devel@lists.xenproject.org
> Cc: Stefano Stabellini <sstabellini@kernel.org>; Andrii Anisov
> <andrii_anisov@epam.com>
> Subject: Re: [RFC] arm/p2m: call iommu iotlb flush if iommu exists and
> enabled
> 
> Hello Paul,
> 
> On 23.01.19 13:45, Paul Durrant wrote:
> > Yes, this was a mistake when moving from the old macros and need_iommu.
> Andrii is correct that need_iommu_pt_sync() is supposed to gate whether an
> explicit map/unmap is needed. The need for flush should only depend on
> has_iommu_pt().
> So I fix the commit message and send V2 for XEN 4.12.

Cool.

> 
> > There is also iommu_use_hap_pt() which is actually defined as
> has_iommu_pt(), but I wonder whether that should just go away for ARM
> since the page tables are always shared.
> Actually, the mainline currently supports only SMMU, which does share the
> page table.
> But it is not always true, we are using HW, where PT is not shared. And
> going to upstream that support one day.

Oh, ok. Leave it in then :-)

  Paul

> 
> --
> Sincerely,
> Andrii Anisov.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-01-23 12:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 10:12 [RFC] arm/p2m: call iommu iotlb flush if iommu exists and enabled Andrii Anisov
2019-01-23 11:33 ` Julien Grall
2019-01-23 11:45   ` Paul Durrant
2019-01-23 12:40     ` Andrii Anisov
2019-01-23 12:41       ` Paul Durrant [this message]
2019-01-23 12:35   ` Andrii Anisov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a9586dac80748f0a8b0f575792cbbb8@AMSPEX02CL03.citrite.net \
    --to=paul.durrant@citrix.com \
    --cc=andrii.anisov@gmail.com \
    --cc=andrii_anisov@epam.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.