From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B2DC433B4 for ; Tue, 18 May 2021 20:41:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAA8C6112F for ; Tue, 18 May 2021 20:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352232AbhERUnL (ORCPT ); Tue, 18 May 2021 16:43:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:33070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234956AbhERUnJ (ORCPT ); Tue, 18 May 2021 16:43:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 567CB61059; Tue, 18 May 2021 20:41:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621370511; bh=aIgBwh8ikO9n9G42hk2Its108dIO1H+qNOHk38ZgjLk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=aG21jQtYqlcxI5n380BGG/YRCkivqS3rHteMFSS5ekJWaMUDcF5IAbMKzDeehytga FwB7699dQbeuqRYyfqFyvb00y2VuuyGg6NCuFfZEi/aFCEKeCgab7Ybpgoxxh2cbZf n8stjw/J5+1K9Az7aNdYzi+BboXCFaWT/HzxQohchVrsnIoWGmmSmEjfZD+OaSjrlA clV9mNMOQ2IO6Le8Qc5SnzUE2Vr9keWifP6e4jwwiVqyeZnKRqMvpWm4MP0/GqXBTo J1YRHO4JvKuvoFaZfvIhFk8xnKT1W4Xw3LDAXYEyRALoVH1S1tpKrHt4UWFtUc1w4M 888BhJMp9LqHA== Subject: Re: [PATCH v2] powerpc/powernv/pci: fix header guard To: Nick Desaulniers , Michael Ellerman Cc: Oliver O'Halloran , Joe Perches , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <87cztok1r5.fsf@mpe.ellerman.id.au> <20210518204044.2390064-1-ndesaulniers@google.com> From: Nathan Chancellor Message-ID: <4aa06438-7bea-a5a6-ff64-0cf8c28e2511@kernel.org> Date: Tue, 18 May 2021 13:41:49 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210518204044.2390064-1-ndesaulniers@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/18/2021 1:40 PM, Nick Desaulniers wrote: > While looking at -Wundef warnings, the #if CONFIG_EEH stood out as a > possible candidate to convert to #ifdef CONFIG_EEH. > > It seems that based on Kconfig dependencies it's not possible to build > this file without CONFIG_EEH enabled, but based on upstream discussion, > it's not clear yet that CONFIG_EEH should be enabled by default. > > For now, simply fix the -Wundef warning. > > Suggested-by: Nathan Chancellor > Suggested-by: Joe Perches > Link: https://github.com/ClangBuiltLinux/linux/issues/570 > Link: https://lore.kernel.org/lkml/67f6cd269684c9aa8463ff4812c3b4605e6739c3.camel@perches.com/ > Link: https://lore.kernel.org/lkml/CAOSf1CGoN5R0LUrU=Y=UWho1Z_9SLgCX8s3SbFJXwJXc5BYz4A@mail.gmail.com/ > Signed-off-by: Nick Desaulniers Makes sense, thanks for the patch! Reviewed-by: Nathan Chancellor > --- > arch/powerpc/platforms/powernv/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/pci.c b/arch/powerpc/platforms/powernv/pci.c > index b18468dc31ff..6bb3c52633fb 100644 > --- a/arch/powerpc/platforms/powernv/pci.c > +++ b/arch/powerpc/platforms/powernv/pci.c > @@ -711,7 +711,7 @@ int pnv_pci_cfg_write(struct pci_dn *pdn, > return PCIBIOS_SUCCESSFUL; > } > > -#if CONFIG_EEH > +#ifdef CONFIG_EEH > static bool pnv_pci_cfg_check(struct pci_dn *pdn) > { > struct eeh_dev *edev = NULL; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E018C433B4 for ; Tue, 18 May 2021 20:42:19 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1CBD6112F for ; Tue, 18 May 2021 20:42:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1CBD6112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Fl7Gd3DKWz3096 for ; Wed, 19 May 2021 06:42:17 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=aG21jQtY; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=nathan@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=aG21jQtY; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Fl7G93cW2z2xZD for ; Wed, 19 May 2021 06:41:53 +1000 (AEST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 567CB61059; Tue, 18 May 2021 20:41:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621370511; bh=aIgBwh8ikO9n9G42hk2Its108dIO1H+qNOHk38ZgjLk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=aG21jQtYqlcxI5n380BGG/YRCkivqS3rHteMFSS5ekJWaMUDcF5IAbMKzDeehytga FwB7699dQbeuqRYyfqFyvb00y2VuuyGg6NCuFfZEi/aFCEKeCgab7Ybpgoxxh2cbZf n8stjw/J5+1K9Az7aNdYzi+BboXCFaWT/HzxQohchVrsnIoWGmmSmEjfZD+OaSjrlA clV9mNMOQ2IO6Le8Qc5SnzUE2Vr9keWifP6e4jwwiVqyeZnKRqMvpWm4MP0/GqXBTo J1YRHO4JvKuvoFaZfvIhFk8xnKT1W4Xw3LDAXYEyRALoVH1S1tpKrHt4UWFtUc1w4M 888BhJMp9LqHA== Subject: Re: [PATCH v2] powerpc/powernv/pci: fix header guard To: Nick Desaulniers , Michael Ellerman References: <87cztok1r5.fsf@mpe.ellerman.id.au> <20210518204044.2390064-1-ndesaulniers@google.com> From: Nathan Chancellor Message-ID: <4aa06438-7bea-a5a6-ff64-0cf8c28e2511@kernel.org> Date: Tue, 18 May 2021 13:41:49 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210518204044.2390064-1-ndesaulniers@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy , linux-kernel@vger.kernel.org, Oliver O'Halloran , Greg Kroah-Hartman , Joe Perches , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 5/18/2021 1:40 PM, Nick Desaulniers wrote: > While looking at -Wundef warnings, the #if CONFIG_EEH stood out as a > possible candidate to convert to #ifdef CONFIG_EEH. > > It seems that based on Kconfig dependencies it's not possible to build > this file without CONFIG_EEH enabled, but based on upstream discussion, > it's not clear yet that CONFIG_EEH should be enabled by default. > > For now, simply fix the -Wundef warning. > > Suggested-by: Nathan Chancellor > Suggested-by: Joe Perches > Link: https://github.com/ClangBuiltLinux/linux/issues/570 > Link: https://lore.kernel.org/lkml/67f6cd269684c9aa8463ff4812c3b4605e6739c3.camel@perches.com/ > Link: https://lore.kernel.org/lkml/CAOSf1CGoN5R0LUrU=Y=UWho1Z_9SLgCX8s3SbFJXwJXc5BYz4A@mail.gmail.com/ > Signed-off-by: Nick Desaulniers Makes sense, thanks for the patch! Reviewed-by: Nathan Chancellor > --- > arch/powerpc/platforms/powernv/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/pci.c b/arch/powerpc/platforms/powernv/pci.c > index b18468dc31ff..6bb3c52633fb 100644 > --- a/arch/powerpc/platforms/powernv/pci.c > +++ b/arch/powerpc/platforms/powernv/pci.c > @@ -711,7 +711,7 @@ int pnv_pci_cfg_write(struct pci_dn *pdn, > return PCIBIOS_SUCCESSFUL; > } > > -#if CONFIG_EEH > +#ifdef CONFIG_EEH > static bool pnv_pci_cfg_check(struct pci_dn *pdn) > { > struct eeh_dev *edev = NULL; >