All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Artur Petrosyan <Arthur.Petrosyan@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: John Youn <John.Youn@synopsys.com>
Subject: Re: [PATCH 03/12] usb: dwc2: Allow entering clock gating from USB_SUSPEND interrupt
Date: Tue, 13 Apr 2021 12:25:20 +0300	[thread overview]
Message-ID: <4aace947-826f-7e45-f2f8-2bbfaf9f1420@gmail.com> (raw)
In-Reply-To: <58dc1c1805b583fa87f9615e9d17e9ff88644718.1618297800.git.Arthur.Petrosyan@synopsys.com>

On 13.04.2021 10:16, Artur Petrosyan wrote:

> If core doesn't support hibernation or partial power
> down power saving options, power can still be saved
> using clock gating on all the clocks.
> 
> - Added entering clock gating state from USB_SUSPEND
>    interrupt.
> 
> Signed-off-by: Artur Petrosyan <Arthur.Petrosyan@synopsys.com>
> Acked-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
> ---
>   drivers/usb/dwc2/core_intr.c | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
> index 8c0152b514be..ab7fe303c0f9 100644
> --- a/drivers/usb/dwc2/core_intr.c
> +++ b/drivers/usb/dwc2/core_intr.c
> @@ -529,14 +529,18 @@ static void dwc2_handle_usb_suspend_intr(struct dwc2_hsotg *hsotg)
>   				/* Ask phy to be suspended */
>   				if (!IS_ERR_OR_NULL(hsotg->uphy))
>   					usb_phy_set_suspend(hsotg->uphy, true);
> -			}
> -
> -			if (hsotg->hw_params.hibernation) {
> +			} else if (hsotg->hw_params.hibernation) {
>   				ret = dwc2_enter_hibernation(hsotg, 0);
>   				if (ret && ret != -ENOTSUPP)
>   					dev_err(hsotg->dev,
>   						"%s: enter hibernation failed\n",
>   						__func__);
> +			} else {
> +				/*
> +				 * If not hibernation nor partial power down are supported,

    s/not/neither/?

[...]

MBR, Sergei

  reply	other threads:[~2021-04-13  9:25 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1618297800.git.Arthur.Petrosyan@synopsys.com>
2021-04-13  7:16 ` [PATCH 01/12] usb: dwc2: Add device clock gating support functions Artur Petrosyan
2021-04-13  7:16 ` [PATCH 02/12] usb: dwc2: Add host " Artur Petrosyan
2021-04-13  7:16 ` [PATCH 03/12] usb: dwc2: Allow entering clock gating from USB_SUSPEND interrupt Artur Petrosyan
2021-04-13  9:25   ` Sergei Shtylyov [this message]
2021-04-13  7:16 ` [PATCH 04/12] usb: dwc2: Add exit clock gating from wakeup interrupt Artur Petrosyan
2021-04-13  7:16 ` [PATCH 05/12] usb: dwc2: Add exit clock gating from session request interrupt Artur Petrosyan
2021-04-13  7:16 ` [PATCH 06/12] usb: dwc2: Add exit clock gating when port reset is asserted Artur Petrosyan
2021-04-13  7:17 ` [PATCH 07/12] usb: dwc2: Update enter clock gating when port is suspended Artur Petrosyan
2021-04-13  9:22   ` Sergei Shtylyov
2021-04-13 10:24     ` Greg Kroah-Hartman
2021-04-13  7:17 ` [PATCH 08/12] usb: dwc2: Update exit clock gating when port is resumed Artur Petrosyan
2021-04-13  7:17 ` [PATCH 09/12] usb: dwc2: Allow exit clock gating in urb enqueue Artur Petrosyan
2021-04-13  7:17 ` [PATCH 10/12] usb: dwc2: Add clock gating entering flow by system suspend Artur Petrosyan
2021-04-13  7:17 ` [PATCH 11/12] usb: dwc2: Add clock gating exiting flow by system resume Artur Petrosyan
2021-04-13  7:17 ` [PATCH 12/12] usb: dwc2: Add exit clock gating before removing driver Artur Petrosyan
2021-04-13  7:36 ` [PATCH v2 01/12] usb: dwc2: Add device clock gating support functions Artur Petrosyan
2021-04-13  7:36 ` [PATCH v2 02/12] usb: dwc2: Add host " Artur Petrosyan
2021-04-13  7:36 ` [PATCH v2 03/12] usb: dwc2: Allow entering clock gating from USB_SUSPEND interrupt Artur Petrosyan
2021-04-13  7:36 ` [PATCH v2 04/12] usb: dwc2: Add exit clock gating from wakeup interrupt Artur Petrosyan
2021-04-13  7:36 ` [PATCH v2 05/12] usb: dwc2: Add exit clock gating from session request interrupt Artur Petrosyan
2021-04-13  7:36 ` [PATCH v2 06/12] usb: dwc2: Add exit clock gating when port reset is asserted Artur Petrosyan
2021-04-13  7:36 ` [PATCH v2 07/12] usb: dwc2: Update enter clock gating when port is suspended Artur Petrosyan
2021-04-13  7:37 ` [PATCH v2 08/12] usb: dwc2: Update exit clock gating when port is resumed Artur Petrosyan
2021-04-13  7:37 ` [PATCH v2 09/12] usb: dwc2: Allow exit clock gating in urb enqueue Artur Petrosyan
2021-04-13  7:37 ` [PATCH v2 10/12] usb: dwc2: Add clock gating entering flow by system suspend Artur Petrosyan
2021-04-13  9:29   ` Sergei Shtylyov
2021-04-13  7:37 ` [PATCH v2 11/12] usb: dwc2: Add clock gating exiting flow by system resume Artur Petrosyan
2021-04-13  9:30   ` Sergei Shtylyov
2021-04-13  7:37 ` [PATCH v2 12/12] usb: dwc2: Add exit clock gating before removing driver Artur Petrosyan
     [not found] ` <20210413073600.57846A0094@mailhost.synopsys.com>
2021-04-13  8:03   ` [PATCH v2 00/12] usb: dwc2: Add clock gating support Artur Petrosyan
2021-04-13 10:26     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4aace947-826f-7e45-f2f8-2bbfaf9f1420@gmail.com \
    --to=sergei.shtylyov@gmail.com \
    --cc=Arthur.Petrosyan@synopsys.com \
    --cc=John.Youn@synopsys.com \
    --cc=Minas.Harutyunyan@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.