From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vincent JARDIN <vincent.jardin@6wind.com>
Subject: Re: [PATCH v5 23/29] app/testpmd: handle i40e in VF VLAN
 filter command
Date: Fri, 16 Dec 2016 21:31:58 +0100
Message-ID: <4ab71f12-5352-fa36-3691-929c8a2b8bbf@6wind.com>
References: <20161216143919.4909-1-ferruh.yigit@intel.com>
 <20161216190257.6921-1-ferruh.yigit@intel.com>
 <20161216190257.6921-24-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Cc: Jingjing Wu <jingjing.wu@intel.com>, Helin Zhang <helin.zhang@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 2C8CD2BF6
 for <dev@dpdk.org>; Fri, 16 Dec 2016 21:32:04 +0100 (CET)
Received: by mail-wm0-f54.google.com with SMTP id g23so45404911wme.1
 for <dev@dpdk.org>; Fri, 16 Dec 2016 12:32:04 -0800 (PST)
In-Reply-To: <20161216190257.6921-24-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Le 16/12/2016 à 20:02, Ferruh Yigit a écrit :
> +#ifdef RTE_LIBRTE_IXGBE_PMD
> +	if (strstr(dev_info.driver_name, "ixgbe") != NULL)
> +		ret = rte_pmd_ixgbe_set_vf_vlan_filter(res->port_id,
> +				res->vlan_id, res->vf_mask, is_add);
> +#endif
> +#ifdef RTE_LIBRTE_I40E_PMD
> +	if (strstr(dev_info.driver_name, "i40e") != NULL)
> +		ret = rte_pmd_i40e_set_vf_vlan_filter(res->port_id,
> +				res->vlan_id, res->vf_mask, is_add);
> +#endif

That's exactly what we need to avoid, it won't scale to many PMDs.