All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/4] btrfs: Fix split-brain handling when changing FSID to metadata uuid
Date: Fri, 10 Jan 2020 10:58:04 -0500	[thread overview]
Message-ID: <4acd7424-1279-c988-51e1-02112b8d6c62@toxicpanda.com> (raw)
In-Reply-To: <20200110121135.7386-5-nborisov@suse.com>

On 1/10/20 7:11 AM, Nikolay Borisov wrote:
> Current code doesn't correctly handle the situation which arises when
> a file system that has METADATA_UUID_INCOMPAT flag set  has its FSID
> changed to the one in metadata uuid. This causes the incompat flag to
> disappear. In case of a power failure we could end up in a situation
> where part of the disks in a multi-disk filesystem are correctly
> reverted to METADATA_UUID_INCOMPAT flag unset state, while others have
> METADATA_UUID_INCOMPAT set and CHANGING_FSID_V2_IN_PROGRESS.
> 
> This patch corrects the behavior required to handle the case where a
> disk of the second type is scanned first, creating the necessary
> btrfs_fs_devices. Subsequently, when a disk which has already completed
> the transition is scanned it should overwrite the data in
> btrfs_fs_devices.
> 
> Reported-by: Su Yue <Damenly_Su@gmx.com>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

  reply	other threads:[~2020-01-10 15:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 12:11 [PATCH 0/4] More split-brain fixes for metadata uuid feature Nikolay Borisov
2020-01-10 12:11 ` [PATCH 1/4] btrfs: Call find_fsid from find_fsid_inprogress Nikolay Borisov
2020-01-10 15:24   ` Josef Bacik
2020-01-10 12:11 ` [PATCH 2/4] btrfs: Factor out metadata_uuid code from find_fsid Nikolay Borisov
2020-01-10 15:25   ` Josef Bacik
2020-01-10 12:11 ` [PATCH 3/4] btrfs: Handle another split brain scenario with metadata uuid feature Nikolay Borisov
2020-01-10 15:29   ` Josef Bacik
2020-01-21 15:16   ` David Sterba
2020-01-10 12:11 ` [PATCH 4/4] btrfs: Fix split-brain handling when changing FSID to metadata uuid Nikolay Borisov
2020-01-10 15:58   ` Josef Bacik [this message]
2020-01-14 17:14 ` [PATCH 0/4] More split-brain fixes for metadata uuid feature David Sterba
2020-01-21 15:23   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4acd7424-1279-c988-51e1-02112b8d6c62@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    --subject='Re: [PATCH 4/4] btrfs: Fix split-brain handling when changing FSID to metadata uuid' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.