From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v1 23/29] memory: tegra124-emc: Register as interconnect provider Date: Tue, 19 Nov 2019 19:57:50 +0300 Message-ID: <4ad5dca2-12c9-8e96-c68c-0dcdb9860fd9@gmail.com> References: <20191118200247.3567-1-digetx@gmail.com> <20191118200247.3567-24-digetx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20191118200247.3567-24-digetx@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Thierry Reding , Jonathan Hunter , Peter De Schrijver , Mikko Perttunen , Georgi Djakov , Rob Herring Cc: linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org List-Id: linux-tegra@vger.kernel.org 18.11.2019 23:02, Dmitry Osipenko пишет: > EMC now provides MC with memory bandwidth using interconnect API. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/tegra124-emc.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c > index 2c73260654ba..c9478dcbeece 100644 > --- a/drivers/memory/tegra/tegra124-emc.c > +++ b/drivers/memory/tegra/tegra124-emc.c > @@ -25,6 +25,7 @@ > #define EMC_FBIO_CFG5 0x104 > #define EMC_FBIO_CFG5_DRAM_TYPE_MASK 0x3 > #define EMC_FBIO_CFG5_DRAM_TYPE_SHIFT 0 > +#define EMC_FBIO_CFG5_DRAM_WIDTH_X64 BIT(4) > > #define EMC_INTSTATUS 0x0 > #define EMC_INTSTATUS_CLKCHANGE_COMPLETE BIT(4) > @@ -1080,11 +1081,28 @@ static void emc_debugfs_init(struct device *dev, struct tegra_emc *emc) > dev_err(dev, "failed to create debugfs entry\n"); > } > > +static unsigned int emc_dram_data_bus_width_bytes(struct tegra_emc *emc) > +{ > + unsigned int bus_width; > + u32 emc_cfg; > + > + emc_cfg = readl_relaxed(emc->regs + EMC_FBIO_CFG5); > + if (emc_cfg & EMC_FBIO_CFG5_DRAM_WIDTH_X64) > + bus_width = 64; > + else > + bus_width = 32; Looks like I got a bit confused while was looking at TRMs before, seems this width is unrelated to the EMC channel at all. I'll try to revisit this again. > + dev_info(emc->dev, "DRAM data-bus width: %ubit\n", bus_width); > + > + return bus_width / 8; > +} > + > static int tegra_emc_probe(struct platform_device *pdev) > { > struct platform_device *mc; > struct device_node *np; > struct tegra_emc *emc; > + unsigned int bus_width; > u32 ram_code; > int err; > > @@ -1146,6 +1164,12 @@ static int tegra_emc_probe(struct platform_device *pdev) > if (IS_ENABLED(CONFIG_DEBUG_FS)) > emc_debugfs_init(&pdev->dev, emc); > > + bus_width = emc_dram_data_bus_width_bytes(emc); > + > + err = tegra_icc_emc_setup_interconnect(&pdev->dev, bus_width); > + if (err) > + dev_err(&pdev->dev, "failed to initialize ICC: %d\n", err); > + > return 0; > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7AA8C432C0 for ; Tue, 19 Nov 2019 23:28:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8536020674 for ; Tue, 19 Nov 2019 23:28:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8536020674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0220B6EA0D; Tue, 19 Nov 2019 23:28:12 +0000 (UTC) Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F19E6E9D1 for ; Tue, 19 Nov 2019 16:57:53 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id a17so1532962lfi.13 for ; Tue, 19 Nov 2019 08:57:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j+gYl8HldvGbyx97hnAX9xUoG7AkMiMS7oU+UeQIp7E=; b=sBBhNLR/dnBc1/PCLGavXH9osf/+ijWFJxnZplkG+I1Zm+aU0Ke5YoKukUObWLOH6i qnOYQ1H7EZY8IIYZPQ8JaOw1MZWa4myi1/KW1jnqlWQHKeu5R7zzaBg5zGfF/WDwrBkt TGd6O4VCaWi7O4vG/Oc4AfUCXoe5kuTZ178TPTZ1EdHCT5UEcbehZO3QdUY2pC7ALwaq IJy9pxDqp7yaaixpi127pd6QxjWUmSRf0SyAS5j1Uiaaq2wY0juMoour6BOmO8ZANjzs aJPAB8Eu6rnXxOz6aT10o+4p9KblfhWK0s5sQFDdqDoHq2+DwsOrRTAW596YgdphCYLO qXzg== X-Gm-Message-State: APjAAAXX9n+d8ySVBhSucHcBzGELw343xnAQF80Bw2B9yPvxuTM03UUR jwl4c5neGqiLsXl0awvprnA= X-Google-Smtp-Source: APXvYqz8vet4QWY5IUi4C6ihSYs+/14tbC3f6wpa0eTLtn7PYqBbI69ydT5j/A2C2hRcVFQx+8A1eQ== X-Received: by 2002:ac2:44d4:: with SMTP id d20mr4812970lfm.88.1574182671483; Tue, 19 Nov 2019 08:57:51 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id 3sm10781212lfq.55.2019.11.19.08.57.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2019 08:57:51 -0800 (PST) Subject: Re: [PATCH v1 23/29] memory: tegra124-emc: Register as interconnect provider From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Peter De Schrijver , Mikko Perttunen , Georgi Djakov , Rob Herring References: <20191118200247.3567-1-digetx@gmail.com> <20191118200247.3567-24-digetx@gmail.com> Message-ID: <4ad5dca2-12c9-8e96-c68c-0dcdb9860fd9@gmail.com> Date: Tue, 19 Nov 2019 19:57:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191118200247.3567-24-digetx@gmail.com> Content-Language: en-US X-Mailman-Approved-At: Tue, 19 Nov 2019 23:28:08 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j+gYl8HldvGbyx97hnAX9xUoG7AkMiMS7oU+UeQIp7E=; b=CuLivwxbWs7Wcoly7djIIVs9XgobzAL92vYSDeyg8DXLNM9dqJ87GCy2z05epyY/eH k2bniNhos/o7H5rA/XSVuuk7+EmuPuUdUcl7yDpq+goMg3V4cw/kD4sjKcvfqiElIo8j SvpUlWocaA52Oa+7Dw0HHiq6SM+UXZmx4VLf0zqE45psgcevhHkOWm49io2COxxv7dAR +FNtQfbJj+E6WU+zgrMbvYmmoaB5Qiopf4PEFT6BjQGTc/xDXp1br0Lk8o8uLoo+F4RD RZ4JrOOy6YuNJm1HxeO65M8ezAMXMYywgX8F5iEKh07EKN1Bilh1PWDsh8WdnzP5itd0 R7XQ== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191119165750.-u_2kIJgYTmu18Lclt14nII7yTTS7UjOFYbSkcRQ-JU@z> MTguMTEuMjAxOSAyMzowMiwgRG1pdHJ5IE9zaXBlbmtvINC/0LjRiNC10YI6Cj4gRU1DIG5vdyBw cm92aWRlcyBNQyB3aXRoIG1lbW9yeSBiYW5kd2lkdGggdXNpbmcgaW50ZXJjb25uZWN0IEFQSS4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBEbWl0cnkgT3NpcGVua28gPGRpZ2V0eEBnbWFpbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvbWVtb3J5L3RlZ3JhL3RlZ3JhMTI0LWVtYy5jIHwgMjQgKysrKysrKysr KysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVtb3J5L3RlZ3JhL3RlZ3JhMTI0LWVtYy5jIGIvZHJpdmVy cy9tZW1vcnkvdGVncmEvdGVncmExMjQtZW1jLmMKPiBpbmRleCAyYzczMjYwNjU0YmEuLmM5NDc4 ZGNiZWVjZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21lbW9yeS90ZWdyYS90ZWdyYTEyNC1lbWMu Ywo+ICsrKyBiL2RyaXZlcnMvbWVtb3J5L3RlZ3JhL3RlZ3JhMTI0LWVtYy5jCj4gQEAgLTI1LDYg KzI1LDcgQEAKPiAgI2RlZmluZSBFTUNfRkJJT19DRkc1CQkJCTB4MTA0Cj4gICNkZWZpbmUJRU1D X0ZCSU9fQ0ZHNV9EUkFNX1RZUEVfTUFTSwkJMHgzCj4gICNkZWZpbmUJRU1DX0ZCSU9fQ0ZHNV9E UkFNX1RZUEVfU0hJRlQJCTAKPiArI2RlZmluZSBFTUNfRkJJT19DRkc1X0RSQU1fV0lEVEhfWDY0 CQlCSVQoNCkKPiAgCj4gICNkZWZpbmUgRU1DX0lOVFNUQVRVUwkJCQkweDAKPiAgI2RlZmluZSBF TUNfSU5UU1RBVFVTX0NMS0NIQU5HRV9DT01QTEVURQlCSVQoNCkKPiBAQCAtMTA4MCwxMSArMTA4 MSwyOCBAQCBzdGF0aWMgdm9pZCBlbWNfZGVidWdmc19pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwg c3RydWN0IHRlZ3JhX2VtYyAqZW1jKQo+ICAJCWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIGNyZWF0 ZSBkZWJ1Z2ZzIGVudHJ5XG4iKTsKPiAgfQo+ICAKPiArc3RhdGljIHVuc2lnbmVkIGludCBlbWNf ZHJhbV9kYXRhX2J1c193aWR0aF9ieXRlcyhzdHJ1Y3QgdGVncmFfZW1jICplbWMpCj4gK3sKPiAr CXVuc2lnbmVkIGludCBidXNfd2lkdGg7Cj4gKwl1MzIgZW1jX2NmZzsKPiArCj4gKwllbWNfY2Zn ID0gcmVhZGxfcmVsYXhlZChlbWMtPnJlZ3MgKyBFTUNfRkJJT19DRkc1KTsKPiArCWlmIChlbWNf Y2ZnICYgRU1DX0ZCSU9fQ0ZHNV9EUkFNX1dJRFRIX1g2NCkKPiArCQlidXNfd2lkdGggPSA2NDsK PiArCWVsc2UKPiArCQlidXNfd2lkdGggPSAzMjsKCkxvb2tzIGxpa2UgSSBnb3QgYSBiaXQgY29u ZnVzZWQgd2hpbGUgd2FzIGxvb2tpbmcgYXQgVFJNcyBiZWZvcmUsIHNlZW1zCnRoaXMgd2lkdGgg aXMgdW5yZWxhdGVkIHRvIHRoZSBFTUMgY2hhbm5lbCBhdCBhbGwuIEknbGwgdHJ5IHRvIHJldmlz aXQKdGhpcyBhZ2Fpbi4KCj4gKwlkZXZfaW5mbyhlbWMtPmRldiwgIkRSQU0gZGF0YS1idXMgd2lk dGg6ICV1Yml0XG4iLCBidXNfd2lkdGgpOwo+ICsKPiArCXJldHVybiBidXNfd2lkdGggLyA4Owo+ ICt9Cj4gKwo+ICBzdGF0aWMgaW50IHRlZ3JhX2VtY19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICptYzsKPiAgCXN0cnVj dCBkZXZpY2Vfbm9kZSAqbnA7Cj4gIAlzdHJ1Y3QgdGVncmFfZW1jICplbWM7Cj4gKwl1bnNpZ25l ZCBpbnQgYnVzX3dpZHRoOwo+ICAJdTMyIHJhbV9jb2RlOwo+ICAJaW50IGVycjsKPiAgCj4gQEAg LTExNDYsNiArMTE2NCwxMiBAQCBzdGF0aWMgaW50IHRlZ3JhX2VtY19wcm9iZShzdHJ1Y3QgcGxh dGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJaWYgKElTX0VOQUJMRUQoQ09ORklHX0RFQlVHX0ZTKSkK PiAgCQllbWNfZGVidWdmc19pbml0KCZwZGV2LT5kZXYsIGVtYyk7Cj4gIAo+ICsJYnVzX3dpZHRo ID0gZW1jX2RyYW1fZGF0YV9idXNfd2lkdGhfYnl0ZXMoZW1jKTsKPiArCj4gKwllcnIgPSB0ZWdy YV9pY2NfZW1jX3NldHVwX2ludGVyY29ubmVjdCgmcGRldi0+ZGV2LCBidXNfd2lkdGgpOwo+ICsJ aWYgKGVycikKPiArCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJmYWlsZWQgdG8gaW5pdGlhbGl6ZSBJ Q0M6ICVkXG4iLCBlcnIpOwo+ICsKPiAgCXJldHVybiAwOwo+ICB9Owo+ICAKPiAKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==