All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v1] hwmon: (lm90) Use edge-triggered interrupt
Date: Fri, 18 Jun 2021 11:55:13 +0300	[thread overview]
Message-ID: <4ae32e69-1d2f-f75b-ad86-10eac15606df@gmail.com> (raw)
In-Reply-To: <20210617214257.GD2244035@roeck-us.net>

18.06.2021 00:42, Guenter Roeck пишет:
> On Thu, Jun 17, 2021 at 06:27:50PM +0300, Dmitry Osipenko wrote:
>> 17.06.2021 18:12, Guenter Roeck пишет:
>>>> For now I see that the rising edge isn't needed, the TEMP_ALERT goes
>>>> HIGH by itself when temperature backs to normal. But I will try to
>>>> double check.
>>>>
>>> The point is that a sysfs event should be sent to userspace on both
>>> edges, not only when an alarm is raised. But, you are correct,
>>> IRQ_TYPE_EDGE_RISING is currently not needed since sysfs events
>>> are not generated.
>>
>> Ok, thank you for the clarification.
>>
>>>>> Anyway, the tegra30 dts files in the upstream kernel either use
>>>>> IRQ_TYPE_LEVEL_LOW or no interrupts for nct1008. The Nexus 7 dts file
>>>>> in the upstream kernel has no interrupt configured (and coincidentally
>>>>> it was you who added that entry). Where do you see IRQ_TYPE_LEVEL_HIGH ?
>>>> I have a patch that will add the interrupt property, it's stashed
>>>> locally for the next kernel release.
>>>>
>>>> IIUC, it's not only the Tegra30 dts, but all the TegraXXX boards that
>>>> use IRQ_TYPE_LEVEL_LOW are in the same position.
>>> I still don't see a IRQ_TYPE_LEVEL_HIGH, though.
>>
>> Could you please clarify why you're looking for HIGH and not for LOW?
>> The TEMP_ALERT is active-low.
> 
> Because you stated earlier:
> 
> "... cargo-culted and wrong because they use IRQ_TYPE_LEVEL_HIGH ..."
>                                              ^^^^^^^^^^^^^^^^^^^

That was a typo, my bad.

      reply	other threads:[~2021-06-18  8:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 19:07 Dmitry Osipenko
2021-06-17  0:12 ` Guenter Roeck
2021-06-17  7:11   ` Dmitry Osipenko
2021-06-17 13:12     ` Guenter Roeck
2021-06-17 13:48       ` Dmitry Osipenko
2021-06-17 14:13         ` Guenter Roeck
2021-06-17 14:46           ` Dmitry Osipenko
2021-06-17 15:12             ` Guenter Roeck
2021-06-17 15:27               ` Dmitry Osipenko
2021-06-17 21:42                 ` Guenter Roeck
2021-06-18  8:55                   ` Dmitry Osipenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ae32e69-1d2f-f75b-ad86-10eac15606df@gmail.com \
    --to=digetx@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --subject='Re: [PATCH v1] hwmon: (lm90) Use edge-triggered interrupt' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.