From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: "Phillip Wood" <phillip.wood123@gmail.com>,
"Lénaïc Huard" <lenaic@lhuard.fr>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>
Subject: Re: What's cooking in git.git (Aug 2021, #02; Tue, 3)
Date: Wed, 4 Aug 2021 10:22:41 -0400 [thread overview]
Message-ID: <4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com> (raw)
In-Reply-To: <xmqqfsvpr8t5.fsf@gitster.g>
On 8/4/2021 3:03 AM, Junio C Hamano wrote:
...
> --------------------------------------------------
> [Stalled]
...
> * lh/systemd-timers (2021-07-02) 3 commits
> - maintenance: add support for systemd timers on Linux
> - maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
> - cache.h: Introduce a generic "xdg_config_home_for(…)" function
>
> "git maintenance" scheduler learned to use systemd timers as a
> possible backend.
>
> Waiting for reviews.
I just took another look at this series and see that there were a few
items that have yet to be addressed. CC'ing Lénaïc and reviewers to
see if those items will come in a v8. Here is a quick summary of my
understanding:
* There are some non-ASCII characters in a code comment that are a
bit non-standard and could be replaced with ASCII representations.
(nit, but if re-rolling already this might be worth doing.)
* There is some discussion about using string_list_split() instead
of hand-rolling a string splitter. Discussion decided that we
should _not_ use strbuf_split_buf(). It would be nice to later
create a version of strvec_split() that takes an arbitrary
delimiter, but isn't necessary for this series.
* There was some discussion about using #ifdef to make certain
logic be compiled in or not. This seems (to me) less important
in the case of returning 0 or 1, but in the third patch there
is a large set of logic that is only compiled on Linux, which
seems like it should match the pattern of the other methods,
if possible.
Again, this is just my drive-by summary, but hopefully it renews
work on this topic.
Thanks,
-Stolee
next prev parent reply other threads:[~2021-08-04 14:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 7:03 What's cooking in git.git (Aug 2021, #02; Tue, 3) Junio C Hamano
2021-08-04 10:22 ` Ævar Arnfjörð Bjarmason
2021-08-04 17:57 ` Junio C Hamano
2021-08-04 20:06 ` Ævar Arnfjörð Bjarmason
2021-08-04 18:06 ` Junio C Hamano
2021-08-04 19:53 ` Ævar Arnfjörð Bjarmason
2021-08-04 20:10 ` Junio C Hamano
2021-08-04 21:28 ` SZEDER Gábor
2021-08-04 21:36 ` SZEDER Gábor
2021-08-04 23:06 ` Ævar Arnfjörð Bjarmason
2021-08-05 2:08 ` Junio C Hamano
2021-08-05 2:53 ` Ævar Arnfjörð Bjarmason
2021-08-30 21:03 ` SZEDER Gábor
2021-08-04 18:06 ` SZEDER Gábor
2021-08-04 14:22 ` Derrick Stolee [this message]
2021-08-04 21:03 ` Jeff King
2021-08-05 9:55 ` Phillip Wood
2021-08-05 1:37 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com \
--to=stolee@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lenaic@lhuard.fr \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.