All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 10/26] object: add object_property_set_defaut_{bool, str,  int, uint}()
Date: Thu, 23 Jan 2020 15:34:03 +0100	[thread overview]
Message-ID: <4b16b6d0-ff8d-5810-b49c-c0d2f1e0d7c0@redhat.com> (raw)
In-Reply-To: <CAJ+F1CJBFT7j6qenmD-C053dN4p3YgXFzi3ed=e9vXzr4Hr_ng@mail.gmail.com>

On 23/01/20 12:39, Marc-André Lureau wrote:
> Hi
> 
> On Thu, Jan 23, 2020 at 3:29 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> This patch caught my attention because of the typo in the function, but
> 
> Ah! a french "défaut".

I suspected that. :)

>> I also noticed that get_default is never set to anything but
>> object_property_get_defval.
>>
>> What do you think about removing the method and just relying on defval?
>> In practice there would be a new patch that squashes 7, 10 and the thing
>> after my signature.
> 
> Indeed, we could remove the get_default callback. I can't find the
> reason I added it now.
> 
> Are you resending the series then?

I have already sent a pull request.  In the end even
object_property_get_default was only used once so I just inlined it and
dropped patch 7.

Paolo



  reply	other threads:[~2020-01-23 17:10 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 15:30 [PATCH 00/26] Various qom & qdev enhancements Marc-André Lureau
2020-01-10 15:30 ` [PATCH 01/26] object: add extra sanity checks Marc-André Lureau
2020-01-10 19:18   ` Philippe Mathieu-Daudé
2020-01-10 15:30 ` [PATCH 02/26] qdev: remove duplicated qdev_property_add_static() doc Marc-André Lureau
2020-01-10 15:30 ` [PATCH 03/26] qdev: remove extraneous error Marc-André Lureau
2020-01-10 15:30 ` [PATCH 04/26] qdev: move helper function to monitor/misc Marc-André Lureau
2020-01-10 19:18   ` Philippe Mathieu-Daudé
2020-01-10 15:30 ` [PATCH 05/26] object: avoid extra class property key duplication Marc-André Lureau
2020-01-10 15:30 ` [PATCH 06/26] object: add class property initializer Marc-André Lureau
2020-01-10 15:30 ` [PATCH 07/26] object: add object_property_get_defaut() Marc-André Lureau
2020-01-10 15:30 ` [PATCH 08/26] object: make object_class_property_add* return property Marc-André Lureau
2020-01-10 15:30 ` [PATCH 09/26] qstring: add qstring_free() Marc-André Lureau
2020-01-10 15:30 ` [PATCH 10/26] object: add object_property_set_defaut_{bool, str, int, uint}() Marc-André Lureau
2020-01-23 11:28   ` Paolo Bonzini
2020-01-23 11:39     ` Marc-André Lureau
2020-01-23 14:34       ` Paolo Bonzini [this message]
2020-01-10 15:30 ` [PATCH 11/26] object: do not free class properties Marc-André Lureau
2020-01-10 15:30 ` [PATCH 12/26] object: check strong flag with & Marc-André Lureau
2020-01-10 15:30 ` [PATCH 13/26] object: rename link "child" to "target" Marc-André Lureau
2020-01-10 15:30 ` [PATCH 14/26] object: add direct link flag Marc-André Lureau
2020-01-10 15:30 ` [PATCH 15/26] object: express const link with link property Marc-André Lureau
2020-01-10 15:30 ` [PATCH 16/26] object: add object_class_property_add_link() Marc-André Lureau
2020-01-10 15:30 ` [PATCH 17/26] object: release all props Marc-André Lureau
2020-01-10 15:30 ` [PATCH 18/26] object: return self in object_ref() Marc-André Lureau
2020-01-10 19:22   ` Philippe Mathieu-Daudé
2020-01-10 15:30 ` [PATCH 19/26] qdev: set properties with device_class_set_props() Marc-André Lureau
2020-01-23 11:08   ` Paolo Bonzini
2020-01-23 11:11     ` Marc-André Lureau
2020-01-10 15:30 ` [PATCH 20/26] qdev: move instance properties to class properties Marc-André Lureau
2020-01-10 15:30 ` [PATCH 21/26] qdev: register properties as " Marc-André Lureau
2020-01-10 15:30 ` [PATCH 22/26] vl: print default value in object help Marc-André Lureau
2020-01-10 15:30 ` [PATCH 23/26] qom: simplify qmp_device_list_properties() Marc-André Lureau
2020-01-10 15:30 ` [PATCH 24/26] qom: introduce object_property_help() Marc-André Lureau
2021-03-12 12:54   ` Thomas Huth
2021-03-12 13:00     ` Marc-André Lureau
2020-01-10 15:30 ` [PATCH 25/26] qapi/qmp: add ObjectPropertyInfo.default-value Marc-André Lureau
2020-01-10 15:30 ` [PATCH 26/26] qdev: use object_property_help() Marc-André Lureau
2020-01-10 15:38 ` [PATCH 00/26] Various qom & qdev enhancements Marc-André Lureau
2020-01-20 16:45   ` Stefan Hajnoczi
2020-01-21 16:57   ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2019-12-01 11:15 [PATCH 00/26] Make QDev use class properties Marc-André Lureau
2019-12-01 11:15 ` [PATCH 10/26] object: add object_property_set_defaut_{bool, str, int, uint}() Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b16b6d0-ff8d-5810-b49c-c0d2f1e0d7c0@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.