Re: [PATCH 2/2] iproute2: enable build tipc by default

[Yi Zhao <yi.zhao@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]



在 2017年08月30日 15:43, Jussi Kukkonen 写道:
> On 30 August 2017 at 03:35, Yi Zhao <yi.zhao@windriver.com 
> <mailto:yi.zhao@windriver.com>> wrote:
>
>
>
>     在 2017年08月30日 00:13, Burton, Ross 写道:
>>     On 29 August 2017 at 08:25, Yi Zhao <yi.zhao@windriver.com
>>     <mailto:yi.zhao@windriver.com>> wrote:
>>
>>         -PACKAGECONFIG ??= ""
>>         -PACKAGECONFIG[tipc] = ",,libmnl,"
>>
>>
>>     Surely it would be a lot better to just add tipc to the default
>>     PACKAGECONFIG, so this support and dependencies can be turned off
>>     if required?
>
>     There is no easy way to turn off the support with this patch. User
>     should remove tipc from EXTRA_OEMAKE manually.
>     The package isn't installed to rootfs by default if no package
>     requires it.
>
>
> The question is why not leave the PACKAGECONFIG there so there would 
> be an easy way to turn it off?

I just thought this would make the code more clear. The source doesn't 
build with autotools,  PACKAGECONFIG[tipc] = ",,libmnl," looks a little 
strange.
If it is not a good idea, I will send a v2 patch to keep the PACKAGECONFIG.

Thanks,
Yi


>
> Jussi


[-- Attachment #2: Type: text/html, Size: 3843 bytes --]