From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vidya Sagar Subject: Re: [PATCH V5 10/16] dt-bindings: PCI: tegra: Add device tree support for T194 Date: Tue, 14 May 2019 11:55:48 +0530 Message-ID: <4b1fe488-c99f-3deb-e6f0-a67eb65b2278@nvidia.com> References: <20190424052004.6270-1-vidyas@nvidia.com> <20190424052004.6270-11-vidyas@nvidia.com> <20190426154306.GA16455@bogus> <504abd8f-9eb3-1089-953c-a6372c34b346@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Lorenzo Pieralisi , Bjorn Helgaas , Mark Rutland , Thierry Reding , Jon Hunter , Kishon Vijay Abraham I , Catalin Marinas , Will Deacon , Jingoo Han , Gustavo Pimentel , Mikko Perttunen , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , kthota@nvidia.com, Manikanta Maddireddy List-Id: linux-tegra@vger.kernel.org On 5/13/2019 8:50 PM, Rob Herring wrote: > On Tue, May 7, 2019 at 4:20 AM Vidya Sagar wrote: >> >> On 4/26/2019 9:13 PM, Rob Herring wrote: >>> On Wed, Apr 24, 2019 at 10:49:58AM +0530, Vidya Sagar wrote: >>>> Add support for Tegra194 PCIe controllers. These controllers are based >>>> on Synopsys DesignWare core IP. >>>> >>>> Signed-off-by: Vidya Sagar >>>> --- > >>>> +- nvidia,bpmp: Must contain a phandle to BPMP controller node. >>>> +- nvidia,controller-id : Controller specific ID >>>> + 0: C0 >>>> + 1: C1 >>>> + 2: C2 >>>> + 3: C3 >>>> + 4: C4 >>>> + 5: C5 >>> >>> We don't normal put device indexes into DT. Why do you need this. >>> Perhaps for accessing the BPMP? If so, make nvidia,bpmp a phandle+cell. >> BPMP needs to know the controller number to enable it hence it needs to be >> passed to BPMP. Just for accessing BPMP, I already added 'nvidia,bpmp' property. > > Then make nvidia,bpmp take the phandle and this number. Ok. I'll take care of it in next patch series. > > >>>> +- nvidia,disable-aspm-states: Controls advertisement of ASPM states >>>> + bit-0 to '1': Disables advertisement of ASPM-L0s >>>> + bit-1 to '1': Disables advertisement of ASPM-L1. This also disables >>>> + advertisement of ASPM-L1.1 and ASPM-L1.2 >>>> + bit-2 to '1': Disables advertisement of ASPM-L1.1 >>>> + bit-3 to '1': Disables advertisement of ASPM-L1.2 >>> >>> Can't this cover what 'supports-clkreq' does? >> Well, they are related partially. i.e. if a platform doesn't have 'supports-clkreq' set, >> then, by definition, it can't advertise support for ASPM L1.1 and L1.2 states. But, ASPM-L0s >> and ASPM-L1 states don't depend on 'supports-clkreq' property. >> Having this property gives more granularity as to support for which particular ASPM state >> shouldn't be advertised by the root port. > > Okay, then it should be a common property then. I'm planning to remove this given we have sysfs way (Heiner's patch series @ http://patchwork.ozlabs.org/project/linux-pci/list/?series=107392 to control which ASPM states can be enabled run time. In case if that is not going to work for a given use case, I'll push patches separately for controlling ASPM states advertisement/working. > > Rob > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6658DC04AB7 for ; Tue, 14 May 2019 06:26:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39D1D208C3 for ; Tue, 14 May 2019 06:26:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="aey9i1BR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726274AbfENGZ7 (ORCPT ); Tue, 14 May 2019 02:25:59 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:13974 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbfENGZ6 (ORCPT ); Tue, 14 May 2019 02:25:58 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 13 May 2019 23:25:52 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 13 May 2019 23:25:56 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 13 May 2019 23:25:56 -0700 Received: from [10.24.47.172] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 14 May 2019 06:25:51 +0000 Subject: Re: [PATCH V5 10/16] dt-bindings: PCI: tegra: Add device tree support for T194 To: Rob Herring CC: Lorenzo Pieralisi , Bjorn Helgaas , Mark Rutland , Thierry Reding , Jon Hunter , Kishon Vijay Abraham I , Catalin Marinas , Will Deacon , Jingoo Han , Gustavo Pimentel , Mikko Perttunen , , , , "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , , Manikanta Maddireddy , References: <20190424052004.6270-1-vidyas@nvidia.com> <20190424052004.6270-11-vidyas@nvidia.com> <20190426154306.GA16455@bogus> <504abd8f-9eb3-1089-953c-a6372c34b346@nvidia.com> X-Nvconfidentiality: public From: Vidya Sagar Message-ID: <4b1fe488-c99f-3deb-e6f0-a67eb65b2278@nvidia.com> Date: Tue, 14 May 2019 11:55:48 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1557815152; bh=aymdfMw16yHSs7vet1wRgqNK0BlRIZ7Ycz6RCAS99N0=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=aey9i1BRHiCSfhSf1vClKCQmwTvcMOR82sYIz9bKYoXRvI3vXJ/Oha8Hds/elNyEJ 6E7I3LEGq2Q+hHWAr6WlxEE3ubFXOb9I8WilE6OBU8E/dJumpE34n2UHeklhKy3iMw HDQQpyi0ojbwzbB5Nt10qCtZa8aCAPpQDT/8Cl0SmP1id2XoCxwVKlRdJLVCBHmqQV LKjZhwNPds3PjPDGsyn1rwNfOe9pkq+97sC2EiQU2L4qLYcKUCjp1Uq6FzKyfUBU3+ OJQXPGukJJkaBw0Qg2QoRell9a16uzVDniOyvrWBukg9GbZBVbA9o9TGzSF8yVZ8n7 O/cob961AVKhA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/13/2019 8:50 PM, Rob Herring wrote: > On Tue, May 7, 2019 at 4:20 AM Vidya Sagar wrote: >> >> On 4/26/2019 9:13 PM, Rob Herring wrote: >>> On Wed, Apr 24, 2019 at 10:49:58AM +0530, Vidya Sagar wrote: >>>> Add support for Tegra194 PCIe controllers. These controllers are based >>>> on Synopsys DesignWare core IP. >>>> >>>> Signed-off-by: Vidya Sagar >>>> --- > >>>> +- nvidia,bpmp: Must contain a phandle to BPMP controller node. >>>> +- nvidia,controller-id : Controller specific ID >>>> + 0: C0 >>>> + 1: C1 >>>> + 2: C2 >>>> + 3: C3 >>>> + 4: C4 >>>> + 5: C5 >>> >>> We don't normal put device indexes into DT. Why do you need this. >>> Perhaps for accessing the BPMP? If so, make nvidia,bpmp a phandle+cell. >> BPMP needs to know the controller number to enable it hence it needs to be >> passed to BPMP. Just for accessing BPMP, I already added 'nvidia,bpmp' property. > > Then make nvidia,bpmp take the phandle and this number. Ok. I'll take care of it in next patch series. > > >>>> +- nvidia,disable-aspm-states: Controls advertisement of ASPM states >>>> + bit-0 to '1': Disables advertisement of ASPM-L0s >>>> + bit-1 to '1': Disables advertisement of ASPM-L1. This also disables >>>> + advertisement of ASPM-L1.1 and ASPM-L1.2 >>>> + bit-2 to '1': Disables advertisement of ASPM-L1.1 >>>> + bit-3 to '1': Disables advertisement of ASPM-L1.2 >>> >>> Can't this cover what 'supports-clkreq' does? >> Well, they are related partially. i.e. if a platform doesn't have 'supports-clkreq' set, >> then, by definition, it can't advertise support for ASPM L1.1 and L1.2 states. But, ASPM-L0s >> and ASPM-L1 states don't depend on 'supports-clkreq' property. >> Having this property gives more granularity as to support for which particular ASPM state >> shouldn't be advertised by the root port. > > Okay, then it should be a common property then. I'm planning to remove this given we have sysfs way (Heiner's patch series @ http://patchwork.ozlabs.org/project/linux-pci/list/?series=107392 to control which ASPM states can be enabled run time. In case if that is not going to work for a given use case, I'll push patches separately for controlling ASPM states advertisement/working. > > Rob > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F22B0C04AB4 for ; Tue, 14 May 2019 06:26:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C51BA208C3 for ; Tue, 14 May 2019 06:26:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="phZOXwNK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="aey9i1BR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C51BA208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R8jQMSZvYX82n7Dt5wjlIcnlSfYDSxWS5+9elJCqpxA=; b=phZOXwNKEMW+FQeZ9/d7C1vYD SvALl+M04wO30r2ldSvFru6aNV2bvK1RDA60O2udolc0OOytjABl3Lsef/C20DejxzPQdreTY3LFS ZDh7lVVJb2ktagfMOSa0SogDkx9VNxAfSoIgI3vgmiC0Clwr6bNPsofcX4m9UpepvcnOGGAP6YIFX MeGVWwuvS95VTVPZzNgbWaTKKFHo3XqQFT01RGWmJsaKgury68W9JWew/sxaa8a9W1l5svzKu8mAt btwwEzy9nsReetVotIuEw8NigcykklL27vtkda48pcZhUhvg0lIPzQve6cG8BGZxYJccqHmcxKE/T HkYZJ7e2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQQsy-0007yQ-S3; Tue, 14 May 2019 06:26:00 +0000 Received: from hqemgate16.nvidia.com ([216.228.121.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQQsv-0007y0-Gz for linux-arm-kernel@lists.infradead.org; Tue, 14 May 2019 06:25:59 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 13 May 2019 23:25:52 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 13 May 2019 23:25:56 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 13 May 2019 23:25:56 -0700 Received: from [10.24.47.172] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 14 May 2019 06:25:51 +0000 Subject: Re: [PATCH V5 10/16] dt-bindings: PCI: tegra: Add device tree support for T194 To: Rob Herring References: <20190424052004.6270-1-vidyas@nvidia.com> <20190424052004.6270-11-vidyas@nvidia.com> <20190426154306.GA16455@bogus> <504abd8f-9eb3-1089-953c-a6372c34b346@nvidia.com> X-Nvconfidentiality: public From: Vidya Sagar Message-ID: <4b1fe488-c99f-3deb-e6f0-a67eb65b2278@nvidia.com> Date: Tue, 14 May 2019 11:55:48 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1557815152; bh=aymdfMw16yHSs7vet1wRgqNK0BlRIZ7Ycz6RCAS99N0=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=aey9i1BRHiCSfhSf1vClKCQmwTvcMOR82sYIz9bKYoXRvI3vXJ/Oha8Hds/elNyEJ 6E7I3LEGq2Q+hHWAr6WlxEE3ubFXOb9I8WilE6OBU8E/dJumpE34n2UHeklhKy3iMw HDQQpyi0ojbwzbB5Nt10qCtZa8aCAPpQDT/8Cl0SmP1id2XoCxwVKlRdJLVCBHmqQV LKjZhwNPds3PjPDGsyn1rwNfOe9pkq+97sC2EiQU2L4qLYcKUCjp1Uq6FzKyfUBU3+ OJQXPGukJJkaBw0Qg2QoRell9a16uzVDniOyvrWBukg9GbZBVbA9o9TGzSF8yVZ8n7 O/cob961AVKhA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190513_232557_574825_863CEBEC X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Lorenzo Pieralisi , Mikko Perttunen , Manikanta Maddireddy , linux-pci@vger.kernel.org, Catalin Marinas , Will Deacon , "linux-kernel@vger.kernel.org" , kthota@nvidia.com, Kishon Vijay Abraham I , linux-tegra@vger.kernel.org, Thierry Reding , Gustavo Pimentel , Jingoo Han , Bjorn Helgaas , Jon Hunter , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , sagar.tv@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/13/2019 8:50 PM, Rob Herring wrote: > On Tue, May 7, 2019 at 4:20 AM Vidya Sagar wrote: >> >> On 4/26/2019 9:13 PM, Rob Herring wrote: >>> On Wed, Apr 24, 2019 at 10:49:58AM +0530, Vidya Sagar wrote: >>>> Add support for Tegra194 PCIe controllers. These controllers are based >>>> on Synopsys DesignWare core IP. >>>> >>>> Signed-off-by: Vidya Sagar >>>> --- > >>>> +- nvidia,bpmp: Must contain a phandle to BPMP controller node. >>>> +- nvidia,controller-id : Controller specific ID >>>> + 0: C0 >>>> + 1: C1 >>>> + 2: C2 >>>> + 3: C3 >>>> + 4: C4 >>>> + 5: C5 >>> >>> We don't normal put device indexes into DT. Why do you need this. >>> Perhaps for accessing the BPMP? If so, make nvidia,bpmp a phandle+cell. >> BPMP needs to know the controller number to enable it hence it needs to be >> passed to BPMP. Just for accessing BPMP, I already added 'nvidia,bpmp' property. > > Then make nvidia,bpmp take the phandle and this number. Ok. I'll take care of it in next patch series. > > >>>> +- nvidia,disable-aspm-states: Controls advertisement of ASPM states >>>> + bit-0 to '1': Disables advertisement of ASPM-L0s >>>> + bit-1 to '1': Disables advertisement of ASPM-L1. This also disables >>>> + advertisement of ASPM-L1.1 and ASPM-L1.2 >>>> + bit-2 to '1': Disables advertisement of ASPM-L1.1 >>>> + bit-3 to '1': Disables advertisement of ASPM-L1.2 >>> >>> Can't this cover what 'supports-clkreq' does? >> Well, they are related partially. i.e. if a platform doesn't have 'supports-clkreq' set, >> then, by definition, it can't advertise support for ASPM L1.1 and L1.2 states. But, ASPM-L0s >> and ASPM-L1 states don't depend on 'supports-clkreq' property. >> Having this property gives more granularity as to support for which particular ASPM state >> shouldn't be advertised by the root port. > > Okay, then it should be a common property then. I'm planning to remove this given we have sysfs way (Heiner's patch series @ http://patchwork.ozlabs.org/project/linux-pci/list/?series=107392 to control which ASPM states can be enabled run time. In case if that is not going to work for a given use case, I'll push patches separately for controlling ASPM states advertisement/working. > > Rob > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel