From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 453E7C433E2 for ; Tue, 1 Sep 2020 14:56:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15CDA2067C for ; Tue, 1 Sep 2020 14:56:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728692AbgIAO4o (ORCPT ); Tue, 1 Sep 2020 10:56:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:39942 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728637AbgIAOyn (ORCPT ); Tue, 1 Sep 2020 10:54:43 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D50A6ACC3; Tue, 1 Sep 2020 14:54:41 +0000 (UTC) Subject: Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , linux-kernel@vger.kernel.org Cc: Oleksandr Andrushchenko , David Airlie , Daniel Vetter , Boris Ostrovsky , Stefano Stabellini , Dan Carpenter , Wei Liu , Yan Yankovskyi , dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, David Hildenbrand , Michal Hocko , Dan Williams References: <20200901083326.21264-1-roger.pau@citrix.com> <20200901083326.21264-4-roger.pau@citrix.com> <20200901144539.GI753@Air-de-Roger> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <4b24c8c3-fb0f-23ad-09c5-81fcfdb6a2b5@suse.com> Date: Tue, 1 Sep 2020 16:54:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200901144539.GI753@Air-de-Roger> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.09.20 16:45, Roger Pau Monné wrote: > On Tue, Sep 01, 2020 at 10:33:26AM +0200, Roger Pau Monne wrote: >> +static int fill_list(unsigned int nr_pages) >> +{ >> + struct dev_pagemap *pgmap; >> + void *vaddr; >> + unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION); >> + int nid, ret; >> + >> + pgmap = kzalloc(sizeof(*pgmap), GFP_KERNEL); >> + if (!pgmap) >> + return -ENOMEM; >> + >> + pgmap->type = MEMORY_DEVICE_GENERIC; >> + pgmap->res.name = "Xen scratch"; >> + pgmap->res.flags = IORESOURCE_MEM | IORESOURCE_BUSY; >> + >> + ret = allocate_resource(&iomem_resource, &pgmap->res, >> + alloc_pages * PAGE_SIZE, 0, -1, >> + PAGES_PER_SECTION * PAGE_SIZE, NULL, NULL); >> + if (ret < 0) { >> + pr_err("Cannot allocate new IOMEM resource\n"); >> + kfree(pgmap); >> + return ret; >> + } >> + >> + nid = memory_add_physaddr_to_nid(pgmap->res.start); > > I think this is not needed ... > >> + >> +#ifdef CONFIG_XEN_HAVE_PVMMU >> + /* >> + * memremap will build page tables for the new memory so >> + * the p2m must contain invalid entries so the correct >> + * non-present PTEs will be written. >> + * >> + * If a failure occurs, the original (identity) p2m entries >> + * are not restored since this region is now known not to >> + * conflict with any devices. >> + */ >> + if (!xen_feature(XENFEAT_auto_translated_physmap)) { >> + xen_pfn_t pfn = PFN_DOWN(pgmap->res.start); >> + >> + for (i = 0; i < alloc_pages; i++) { >> + if (!set_phys_to_machine(pfn + i, INVALID_P2M_ENTRY)) { >> + pr_warn("set_phys_to_machine() failed, no memory added\n"); >> + release_resource(&pgmap->res); >> + kfree(pgmap); >> + return -ENOMEM; >> + } >> + } >> + } >> +#endif >> + >> + vaddr = memremap_pages(pgmap, nid); > > ... and NUMA_NO_NODE should be used here instead, as this memory is just > fictitious space to map foreign memory, and shouldn't be related to > any NUMA node. > > The following chunk should be folded in, or I can resend. I can fold it in. Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8217EC433E2 for ; Tue, 1 Sep 2020 14:54:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 589EA2078B for ; Tue, 1 Sep 2020 14:54:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 589EA2078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D5D306E448; Tue, 1 Sep 2020 14:54:44 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id EDCAC6E448 for ; Tue, 1 Sep 2020 14:54:42 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D50A6ACC3; Tue, 1 Sep 2020 14:54:41 +0000 (UTC) Subject: Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , linux-kernel@vger.kernel.org References: <20200901083326.21264-1-roger.pau@citrix.com> <20200901083326.21264-4-roger.pau@citrix.com> <20200901144539.GI753@Air-de-Roger> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <4b24c8c3-fb0f-23ad-09c5-81fcfdb6a2b5@suse.com> Date: Tue, 1 Sep 2020 16:54:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200901144539.GI753@Air-de-Roger> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Oleksandr Andrushchenko , David Airlie , Yan Yankovskyi , David Hildenbrand , dri-devel@lists.freedesktop.org, Michal Hocko , linux-mm@kvack.org, xen-devel@lists.xenproject.org, Boris Ostrovsky , Dan Williams , Dan Carpenter Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMDEuMDkuMjAgMTY6NDUsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6Cj4gT24gVHVlLCBTZXAg MDEsIDIwMjAgYXQgMTA6MzM6MjZBTSArMDIwMCwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOgo+PiAr c3RhdGljIGludCBmaWxsX2xpc3QodW5zaWduZWQgaW50IG5yX3BhZ2VzKQo+PiArewo+PiArCXN0 cnVjdCBkZXZfcGFnZW1hcCAqcGdtYXA7Cj4+ICsJdm9pZCAqdmFkZHI7Cj4+ICsJdW5zaWduZWQg aW50IGksIGFsbG9jX3BhZ2VzID0gcm91bmRfdXAobnJfcGFnZXMsIFBBR0VTX1BFUl9TRUNUSU9O KTsKPj4gKwlpbnQgbmlkLCByZXQ7Cj4+ICsKPj4gKwlwZ21hcCA9IGt6YWxsb2Moc2l6ZW9mKCpw Z21hcCksIEdGUF9LRVJORUwpOwo+PiArCWlmICghcGdtYXApCj4+ICsJCXJldHVybiAtRU5PTUVN Owo+PiArCj4+ICsJcGdtYXAtPnR5cGUgPSBNRU1PUllfREVWSUNFX0dFTkVSSUM7Cj4+ICsJcGdt YXAtPnJlcy5uYW1lID0gIlhlbiBzY3JhdGNoIjsKPj4gKwlwZ21hcC0+cmVzLmZsYWdzID0gSU9S RVNPVVJDRV9NRU0gfCBJT1JFU09VUkNFX0JVU1k7Cj4+ICsKPj4gKwlyZXQgPSBhbGxvY2F0ZV9y ZXNvdXJjZSgmaW9tZW1fcmVzb3VyY2UsICZwZ21hcC0+cmVzLAo+PiArCQkJCWFsbG9jX3BhZ2Vz ICogUEFHRV9TSVpFLCAwLCAtMSwKPj4gKwkJCQlQQUdFU19QRVJfU0VDVElPTiAqIFBBR0VfU0la RSwgTlVMTCwgTlVMTCk7Cj4+ICsJaWYgKHJldCA8IDApIHsKPj4gKwkJcHJfZXJyKCJDYW5ub3Qg YWxsb2NhdGUgbmV3IElPTUVNIHJlc291cmNlXG4iKTsKPj4gKwkJa2ZyZWUocGdtYXApOwo+PiAr CQlyZXR1cm4gcmV0Owo+PiArCX0KPj4gKwo+PiArCW5pZCA9IG1lbW9yeV9hZGRfcGh5c2FkZHJf dG9fbmlkKHBnbWFwLT5yZXMuc3RhcnQpOwo+IAo+IEkgdGhpbmsgdGhpcyBpcyBub3QgbmVlZGVk IC4uLgo+IAo+PiArCj4+ICsjaWZkZWYgQ09ORklHX1hFTl9IQVZFX1BWTU1VCj4+ICsgICAgICAg IC8qCj4+ICsgICAgICAgICAqIG1lbXJlbWFwIHdpbGwgYnVpbGQgcGFnZSB0YWJsZXMgZm9yIHRo ZSBuZXcgbWVtb3J5IHNvCj4+ICsgICAgICAgICAqIHRoZSBwMm0gbXVzdCBjb250YWluIGludmFs aWQgZW50cmllcyBzbyB0aGUgY29ycmVjdAo+PiArICAgICAgICAgKiBub24tcHJlc2VudCBQVEVz IHdpbGwgYmUgd3JpdHRlbi4KPj4gKyAgICAgICAgICoKPj4gKyAgICAgICAgICogSWYgYSBmYWls dXJlIG9jY3VycywgdGhlIG9yaWdpbmFsIChpZGVudGl0eSkgcDJtIGVudHJpZXMKPj4gKyAgICAg ICAgICogYXJlIG5vdCByZXN0b3JlZCBzaW5jZSB0aGlzIHJlZ2lvbiBpcyBub3cga25vd24gbm90 IHRvCj4+ICsgICAgICAgICAqIGNvbmZsaWN0IHdpdGggYW55IGRldmljZXMuCj4+ICsgICAgICAg ICAqLwo+PiArCWlmICgheGVuX2ZlYXR1cmUoWEVORkVBVF9hdXRvX3RyYW5zbGF0ZWRfcGh5c21h cCkpIHsKPj4gKwkJeGVuX3Bmbl90IHBmbiA9IFBGTl9ET1dOKHBnbWFwLT5yZXMuc3RhcnQpOwo+ PiArCj4+ICsJCWZvciAoaSA9IDA7IGkgPCBhbGxvY19wYWdlczsgaSsrKSB7Cj4+ICsJCQlpZiAo IXNldF9waHlzX3RvX21hY2hpbmUocGZuICsgaSwgSU5WQUxJRF9QMk1fRU5UUlkpKSB7Cj4+ICsJ CQkJcHJfd2Fybigic2V0X3BoeXNfdG9fbWFjaGluZSgpIGZhaWxlZCwgbm8gbWVtb3J5IGFkZGVk XG4iKTsKPj4gKwkJCQlyZWxlYXNlX3Jlc291cmNlKCZwZ21hcC0+cmVzKTsKPj4gKwkJCQlrZnJl ZShwZ21hcCk7Cj4+ICsJCQkJcmV0dXJuIC1FTk9NRU07Cj4+ICsJCQl9Cj4+ICsgICAgICAgICAg ICAgICAgfQo+PiArCX0KPj4gKyNlbmRpZgo+PiArCj4+ICsJdmFkZHIgPSBtZW1yZW1hcF9wYWdl cyhwZ21hcCwgbmlkKTsKPiAKPiAuLi4gYW5kIE5VTUFfTk9fTk9ERSBzaG91bGQgYmUgdXNlZCBo ZXJlIGluc3RlYWQsIGFzIHRoaXMgbWVtb3J5IGlzIGp1c3QKPiBmaWN0aXRpb3VzIHNwYWNlIHRv IG1hcCBmb3JlaWduIG1lbW9yeSwgYW5kIHNob3VsZG4ndCBiZSByZWxhdGVkIHRvCj4gYW55IE5V TUEgbm9kZS4KPiAKPiBUaGUgZm9sbG93aW5nIGNodW5rIHNob3VsZCBiZSBmb2xkZWQgaW4sIG9y IEkgY2FuIHJlc2VuZC4KCkkgY2FuIGZvbGQgaXQgaW4uCgoKSnVlcmdlbgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK