musb: fix remote wakeup racing with suspend

["Daniel Glöckner" <dg@emlix.com>]

Hi,

Am 05/02/18 um 14:40 schrieb Bin Liu:
> On Wed, May 02, 2018 at 03:12:16AM +0200, Daniel Glöckner wrote:
>> On Tue, May 01, 2018 at 08:48:11AM -0500, Bin Liu wrote:
>>> On Fri, Apr 27, 2018 at 03:00:05PM +0200, Daniel Glöckner wrote:
>>>> This commit returns -EBUSY when musb_bus_suspend is called while remote
>>>> wakeup is signalled and thus avoids to reset the RESUME bit. Remember that
>>>> resume can be signalled only when the bus was already suspended, so it is
>>>> safe to skip the following steps even when musb_hub_control ignores the
>>>
>>> what do you mean by "skip the following steps"?
>>
>> Setting USB_PORT_STAT_SUSPEND in musb->port1_status, changing
>> musb->xceiv->otg->state, setting musb->is_active, etc.
> 
> Okay, but I am not sure how "even musb_hub_control ignores the error..."
> is relevant in this statement. The steps are safely skipped in
> musb_port_suspend() when MUSB_POWER_RESUME bit is set, no matter how
> musb_hub_control() to deal with the return code from
> musb_port_suspend(). Did I misunderstand anything?

No, I just wanted to point out that musb_hub_control does not need
to clean up after the error.


>> I'll test without that part and make a v2 patch if it works.

It works without changing that line. v2 follows.

Best regards,

  Daniel